public inbox for [email protected]
help / color / mirror / Atom feedFrom: Drouvot, Bertrand <[email protected]>
To: Zhijie Hou (Fujitsu) <[email protected]>
To: Amit Kapila <[email protected]>
Cc: shveta malik <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Ashutosh Sharma <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Ajin Cherian <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Subject: Re: Synchronizing slots from primary to standby
Date: Mon, 27 Nov 2023 13:46:05 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <OS3PR01MB57189F9B066488E61B29E28994BDA@OS3PR01MB5718.jpnprd01.prod.outlook.com>
References: <CAJpy0uC+2agRtF3H=n-hW5JkoPfaZkjPXJr==y3_PRE04dQvhw@mail.gmail.com>
<CAJpy0uCMptLCgg-fWWTEcgtRfXAeObaXLUw=i2L4vhPRVXGJMA@mail.gmail.com>
<[email protected]>
<CAJpy0uCQQb=UK3h5RWO4_r_MVuLKEGZ34hYrqGmDm+3zVvcJgQ@mail.gmail.com>
<[email protected]>
<CAJpy0uC0xa3_uOxeYd29sbnYbLoJjEOsHGotgPqmYzBk3b6=4A@mail.gmail.com>
<CAJpy0uDv01ctC3z7fV3cbvVw8o+micn7zkD+VBxFm4TnsQh3OQ@mail.gmail.com>
<CAA4eK1KDJ5ctcn+JTKmcCRsxQ2cWZD-uy7zv+cXCwXv=P95yyQ@mail.gmail.com>
<OS0PR01MB571646BD1D0198060112A4F994A6A@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<OS0PR01MB57168A5C52E69FCE8A84DFC794A6A@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<CAA4eK1++T5K1SKE_=y8PPZa-VxkFrRPA8XjbttUCx9VpVXS-yw@mail.gmail.com>
<OS0PR01MB57164C4C576A2BB8FEB61D6F94AAA@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<[email protected]>
<OS3PR01MB57189F9B066488E61B29E28994BDA@OS3PR01MB5718.jpnprd01.prod.outlook.com>
Hi,
On 11/27/23 1:23 PM, Zhijie Hou (Fujitsu) wrote:
> On Monday, November 27, 2023 8:05 PM Drouvot, Bertrand <[email protected]> wrote:
>> Did not look in details but it looks like there is more to do here as
>> this is failing (with v39_2):
>>
>> "
>> postgres@primary: psql replication=database
>> psql (17devel)
>> Type "help" for help.
>>
>> postgres=# CREATE_REPLICATION_SLOT test_logical20 LOGICAL pgoutput
>> FAILOVER;
>> ERROR: syntax error
>
> I think the command you executed is of old syntax style, which was kept for
> compatibility with older releases. And I think we can avoid supporting new
> option for the old syntax as described in the original thread[1] of commit
> 0266e98. So, the "syntax error" is as expected IIUC.
>
> The new style command is like:
> CREATE_REPLICATION_SLOT test_logical20 LOGICAL pgoutput (FAILOVER);
>
> [1] https://www.postgresql.org/message-id/CA%2BTgmobAczXDRO_Gr2euo_TxgzaH1JxbNxvFx%3DHYvBinefNH8Q%40mail...
>
Oh, I see, thanks for pointing out.
Well, not related to that thread but it seems weird to me that the backward
compatibility is done at the "option" level then.
I think it would make more sense to support all the options if the old
syntax is still supported.
For example, having
postgres=# CREATE_REPLICATION_SLOT test_logical2 LOGICAL pgoutput TWO_PHASE;
working fine but
CREATE_REPLICATION_SLOT test_logical3 LOGICAL pgoutput FAILOVER;
failing looks weird to me.
But that's probably out of this thread's context anyway.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Synchronizing slots from primary to standby
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox