Feedback-ID: ie0a040ee:Fastmail
Content-Type: multipart/mixed; boundary="------------0wNRQi0NcyX4MWgf0AnVMK0R"
Message-ID: <bfc015b8-eaea-423d-9a09-1d39c4fe9947@eisentraut.org>
Date: Sat, 13 Dec 2025 14:59:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM
 on-access)
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>,
 Andrey Borodin <x4mmm@yandex-team.ru>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Heikki Linnakangas <hlinnaka@iki.fi>, Kirill Reshke <reshkekirill@gmail.com>
References: 
 <CAAKRu_YX0NP_yhXvPnvDRjVxxprsRBM-_MZzAJskfMydMQ=ETA@mail.gmail.com>
 <yn4zp35kkdsjx6wf47zcfmxgexxt4h2og47pvnw2x5ifyrs3qc@7uw6jyyxuyf7>
 <CAAKRu_ZiuR+YcUc7=TrgANbRakpzCu8X9zqR=Tf0fE6uDbfP1g@mail.gmail.com>
 <CA+TgmoYgCs=SEsohP6Z6R3KKsGaqFqvqxH8vQ_-nY4t+7rK8jg@mail.gmail.com>
 <CAAKRu_ZP-3=SaZykpwDBMJOdUKyW3Wm5JZfPFRR3L5Ac8ouq4w@mail.gmail.com>
 <CAAKRu_bgkOQqu3K5n4YLRsNBZqJ9Rjg80ROqgKSr2UGz4b5hUg@mail.gmail.com>
 <2wk7jo4m4qwh5sn33pfgerdjfujebbccsmmlownybddbh6nawl@mdyyqpqzxjek>
 <CAAKRu_YR-COJ9aGnMUQqt5yoWmUBjikqrd4jGNZYouHaXpis9g@mail.gmail.com>
 <CALdSSPhiCwJwWwgJP1NmqRmnp9RS2tGOBY0gQrfLCbB+OS5_KQ@mail.gmail.com>
 <CAAKRu_YS+Ocm=OzMaZnG4egFiE9v4VYfZ25DXd6jbwegqmGYbQ@mail.gmail.com>
 <CAAKRu_ZGZSqhGt-RcmmfiSheC+1fjQdxy6_+oM-1jMn8hyVptQ@mail.gmail.com>
 <CALdSSPg+B8RTzTXhJvCcKJBqgzhPZkq0E2oqxQdv74ZNZOMVzg@mail.gmail.com>
 <CAAKRu_Zha7HcdQBv8tTtQrcry5332J6kHnOc1X=TT03LzUXDow@mail.gmail.com>
 <CAAKRu_amF00f2T_H8N6pbbe75C22EeX1OqA=svpj8LNO1sdUuw@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAAKRu_amF00f2T_H8N6pbbe75C22EeX1OqA=svpj8LNO1sdUuw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/bfc015b8-eaea-423d-9a09-1d39c4fe9947%40eisentraut.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------0wNRQi0NcyX4MWgf0AnVMK0R
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 20.11.25 18:19, Melanie Plageman wrote:
> +	prstate->deadoffsets = (OffsetNumber *) presult->deadoffsets;

In your patch 
v22-0001-Split-heap_page_prune_and_freeze-into-helpers.patch, the 
assignment above casts away the const qualification of the function 
argument presult:

+static void
+prune_freeze_setup(PruneFreezeParams *params,
+				   TransactionId new_relfrozen_xid,
+				   MultiXactId new_relmin_mxid,
+				   const PruneFreezeResult *presult,
+				   PruneState *prstate)

(The cast is otherwise unnecessary, since the underlying type is the 
same on both sides.)

Since prstate->deadoffsets is in fact later modified, this makes the 
original const qualification invalid.

I suggest the attached patch to remove the faulty const qualification 
and the then-unnecessary cast.

--------------0wNRQi0NcyX4MWgf0AnVMK0R
Content-Type: text/plain; charset=UTF-8;
 name="0001-Fix-const-qualification-in-prune_freeze_setup.patch.nocfbot"
Content-Disposition: attachment;
 filename*0="0001-Fix-const-qualification-in-prune_freeze_setup.patch.noc";
 filename*1="fbot"
Content-Transfer-Encoding: base64

RnJvbSAzMzZhYTg3YWRkMWE4NWFjYTg0ZDhjYTc1MWM0MTg3YTA4YWE5ZDdmIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogU2F0LCAxMyBEZWMgMjAyNSAxNDo0NTowOCArMDEwMApTdWJqZWN0
OiBbUEFUQ0hdIEZpeCBjb25zdCBxdWFsaWZpY2F0aW9uIGluIHBydW5lX2ZyZWV6ZV9zZXR1
cCgpCgpUaGUgY29uc3QgcXVhbGlmaWNhdGlvbiBvZiB0aGUgcHJlc3VsdCBhcmd1bWVudCBp
cyBsYXRlciBjYXN0IGF3YXksIHNvCml0IHdhcyBub3QgY29ycmVjdC4KLS0tCiBzcmMvYmFj
a2VuZC9hY2Nlc3MvaGVhcC9wcnVuZWhlYXAuYyB8IDYgKysrLS0tCiAxIGZpbGUgY2hhbmdl
ZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9i
YWNrZW5kL2FjY2Vzcy9oZWFwL3BydW5laGVhcC5jIGIvc3JjL2JhY2tlbmQvYWNjZXNzL2hl
YXAvcHJ1bmVoZWFwLmMKaW5kZXggY2E0NDIyNWExMGUuLjRlYjQ5MzgwYjkyIDEwMDY0NAot
LS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvaGVhcC9wcnVuZWhlYXAuYworKysgYi9zcmMvYmFj
a2VuZC9hY2Nlc3MvaGVhcC9wcnVuZWhlYXAuYwpAQCAtMTYwLDcgKzE2MCw3IEBAIHR5cGVk
ZWYgc3RydWN0CiBzdGF0aWMgdm9pZCBwcnVuZV9mcmVlemVfc2V0dXAoUHJ1bmVGcmVlemVQ
YXJhbXMgKnBhcmFtcywKIAkJCQkJCQkgICBUcmFuc2FjdGlvbklkICpuZXdfcmVsZnJvemVu
X3hpZCwKIAkJCQkJCQkgICBNdWx0aVhhY3RJZCAqbmV3X3JlbG1pbl9teGlkLAotCQkJCQkJ
CSAgIGNvbnN0IFBydW5lRnJlZXplUmVzdWx0ICpwcmVzdWx0LAorCQkJCQkJCSAgIFBydW5l
RnJlZXplUmVzdWx0ICpwcmVzdWx0LAogCQkJCQkJCSAgIFBydW5lU3RhdGUgKnByc3RhdGUp
Owogc3RhdGljIHZvaWQgcHJ1bmVfZnJlZXplX3BsYW4oT2lkIHJlbG9pZCwgQnVmZmVyIGJ1
ZmZlciwKIAkJCQkJCQkgIFBydW5lU3RhdGUgKnByc3RhdGUsCkBAIC0zMjcsNyArMzI3LDcg
QEAgc3RhdGljIHZvaWQKIHBydW5lX2ZyZWV6ZV9zZXR1cChQcnVuZUZyZWV6ZVBhcmFtcyAq
cGFyYW1zLAogCQkJCSAgIFRyYW5zYWN0aW9uSWQgKm5ld19yZWxmcm96ZW5feGlkLAogCQkJ
CSAgIE11bHRpWGFjdElkICpuZXdfcmVsbWluX214aWQsCi0JCQkJICAgY29uc3QgUHJ1bmVG
cmVlemVSZXN1bHQgKnByZXN1bHQsCisJCQkJICAgUHJ1bmVGcmVlemVSZXN1bHQgKnByZXN1
bHQsCiAJCQkJICAgUHJ1bmVTdGF0ZSAqcHJzdGF0ZSkKIHsKIAkvKiBDb3B5IHBhcmFtZXRl
cnMgdG8gcHJzdGF0ZSAqLwpAQCAtMzgyLDcgKzM4Miw3IEBAIHBydW5lX2ZyZWV6ZV9zZXR1
cChQcnVuZUZyZWV6ZVBhcmFtcyAqcGFyYW1zLAogCXByc3RhdGUtPnJlY2VudGx5X2RlYWRf
dHVwbGVzID0gMDsKIAlwcnN0YXRlLT5oYXN0dXAgPSBmYWxzZTsKIAlwcnN0YXRlLT5scGRl
YWRfaXRlbXMgPSAwOwotCXByc3RhdGUtPmRlYWRvZmZzZXRzID0gKE9mZnNldE51bWJlciAq
KSBwcmVzdWx0LT5kZWFkb2Zmc2V0czsKKwlwcnN0YXRlLT5kZWFkb2Zmc2V0cyA9IHByZXN1
bHQtPmRlYWRvZmZzZXRzOwogCXByc3RhdGUtPmZyel9jb25mbGljdF9ob3Jpem9uID0gSW52
YWxpZFRyYW5zYWN0aW9uSWQ7CiAKIAkvKgotLSAKMi41Mi4wCgo=

--------------0wNRQi0NcyX4MWgf0AnVMK0R--