From: Alexander Lakhin <exclusion@gmail.com>
Subject: make installcheck-world in a clean environment
To: pgsql-hackers@postgresql.org
Message-ID: <bfee872b-ab16-ec7c-8f8a-b3949add1c1b@gmail.com>
Date: Mon, 2 Apr 2018 12:12:12 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------557C1BCDF691D2BBEFC24A2B"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------557C1BCDF691D2BBEFC24A2B
Content-Type: multipart/alternative;
 boundary="------------853CB57B83DFDA210D9304F6"


--------------853CB57B83DFDA210D9304F6
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Hello,

I am trying to perform "make installcheck-world" after "make clean" (or 
after installing a precompiled binaries), but it fails.
The error I get is related to ECPG regression test:
make -C test installcheck
make[2]: Entering directory 
`/home/postgres/postgres/src/interfaces/ecpg/test'
gcc -Wall -Wmissing-prototypes -Wpointer-arith 
-Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute 
-Wformat-security -fno-strict-aliasing -fwrapv 
-fexcess-precision=standard -O2 '-I../../../../src/port' 
'-I../../../../src/test/regress' '-DHOST_TUPLE="x86_64-pc-linux-gnu"' 
'-DSHELLPROG="/bin/sh"' '-DDLSUFFIX=".so"' -I../../../../src/include  
-D_GNU_SOURCE   -c -o pg_regress_ecpg.o pg_regress_ecpg.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith 
-Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute 
-Wformat-security -fno-strict-aliasing -fwrapv 
-fexcess-precision=standard -O2 -L../../../../src/port 
-L../../../../src/common -Wl,--as-needed 
-Wl,-rpath,'/usr/local/pgsql/lib',--enable-new-dtags pg_regress_ecpg.o 
../../../../src/test/regress/pg_regress.o -lpgcommon -lpgport -lpthread 
-lz -lreadline -lrt -lcrypt -ldl -lm  -o pg_regress
make -C connect all
make[3]: Entering directory 
`/home/postgres/postgres/src/interfaces/ecpg/test/connect'
make[3]: *** No rule to make target `test1.c', needed by `test1.o'.  Stop.
make[3]: Leaving directory 
`/home/postgres/postgres/src/interfaces/ecpg/test/connect'

Is it a supported scenario to make installcheck-world without performing 
"make" first?
(If I do "make -C src/interfaces/ecpg" and then "make 
installcheck-world", then this error is gone. And when I set up all the 
extensions, all tests passed successfully.)
And even if we need to perform make, I wonder, should the recompiled 
ecpg binary be checked instead of installed one?
I tried to modify Makefile to target installed ecpg binary and it's libs 
(see the patch attached), it works, but this fix is only suited for 
installcheck.
So if this scenario should be supported, a more elaborated fix is needed.

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


--------------853CB57B83DFDA210D9304F6
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit

<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Hello,<br>
    <br>
    I am trying to perform "<font color="#000000"><span
        style="background: #ffffff">make
        installcheck-world"</span> </font>after "make clean" (or after
    installing a precompiled binaries), but it fails.<br>
    The error I get is related to ECPG regression test:<br>
    <tt>make -C test installcheck</tt><tt><br>
    </tt><tt>make[2]: Entering directory
      `/home/postgres/postgres/src/interfaces/ecpg/test'</tt><tt><br>
    </tt><tt>gcc -Wall -Wmissing-prototypes -Wpointer-arith
      -Wdeclaration-after-statement -Wendif-labels
      -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
      -fwrapv -fexcess-precision=standard -O2 '-I../../../../src/port'
      '-I../../../../src/test/regress'
      '-DHOST_TUPLE="x86_64-pc-linux-gnu"' '-DSHELLPROG="/bin/sh"'
      '-DDLSUFFIX=".so"' -I../../../../src/include  -D_GNU_SOURCE   -c
      -o pg_regress_ecpg.o pg_regress_ecpg.c</tt><tt><br>
    </tt><tt>gcc -Wall -Wmissing-prototypes -Wpointer-arith
      -Wdeclaration-after-statement -Wendif-labels
      -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
      -fwrapv -fexcess-precision=standard -O2 -L../../../../src/port
      -L../../../../src/common -Wl,--as-needed
      -Wl,-rpath,'/usr/local/pgsql/lib',--enable-new-dtags 
      pg_regress_ecpg.o ../../../../src/test/regress/pg_regress.o
      -lpgcommon -lpgport -lpthread -lz -lreadline -lrt -lcrypt -ldl
      -lm  -o pg_regress</tt><tt><br>
    </tt><tt>make -C connect all</tt><tt><br>
    </tt><tt>make[3]: Entering directory
      `/home/postgres/postgres/src/interfaces/ecpg/test/connect'</tt><tt><br>
    </tt><tt>make[3]: *** No rule to make target `test1.c', needed by
      `test1.o'.  Stop.</tt><tt><br>
    </tt><tt>make[3]: Leaving directory
      `/home/postgres/postgres/src/interfaces/ecpg/test/connect'</tt><tt><br>
    </tt><br>
    Is it a supported scenario to <font color="#000000"><span
        style="background: #ffffff">make
        installcheck-world without performing "make" first?</span></font><br>
    <font color="#000000"><span style="background: #ffffff">(If I do
        "make -C src/interfaces/ecpg" and then "</span></font><font
      color="#000000"><span style="background: #ffffff"><font
          color="#000000"><span style="background: #ffffff">make
            installcheck-world</span></font>", then this error is gone.
        And when I set up all the extensions, all tests passed
        successfully.)<br>
        And even if we need to perform make, I wonder, should the
        recompiled ecpg binary be checked instead of installed one?<br>
        I tried to modify Makefile to target installed ecpg binary and
        it's libs </span></font><font color="#000000"><span
        style="background: #ffffff"><font color="#000000"><span
            style="background: #ffffff">(see the patch attached)</span>,
          it works, </font>but this fix is only suited for
        installcheck.<br>
        So if this scenario should be supported, a more elaborated fix
        is needed.<br>
        <br>
      </span></font><font color="#000000"><span style="background:
        #ffffff">Best regards,
        <br>
        ------
        <br>
        Alexander Lakhin
        <br>
        Postgres Professional: <a class="moz-txt-link-freetext"
          href="http://www.postgrespro.com">http://www.postgrespro.com</a>
        <br>
        The Russian Postgres Company<br>
        <br>
      </span></font>
  </body>
</html>

--------------853CB57B83DFDA210D9304F6--

--------------557C1BCDF691D2BBEFC24A2B
Content-Type: text/x-patch;
 name="ecpg-installcheck.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="ecpg-installcheck.patch"

diff --git a/src/interfaces/ecpg/test/Makefile.regress b/src/interfaces/ecpg/test/Makefile.regress
index b3d7c1e..5df1a44 100644
--- a/src/interfaces/ecpg/test/Makefile.regress
+++ b/src/interfaces/ecpg/test/Makefile.regress
@@ -5,14 +5,14 @@ override CPPFLAGS := -I../../include -I$(top_srcdir)/src/interfaces/ecpg/include
        -I$(libpq_srcdir) $(CPPFLAGS)
 override CFLAGS += $(PTHREAD_CFLAGS)
 
-override LDFLAGS := -L../../ecpglib -L../../pgtypeslib $(filter-out -l%, $(libpq)) $(LDFLAGS)
+override LDFLAGS := -L'$(DESTDIR)$(libdir)/' $(filter-out -l%, $(libpq)) $(LDFLAGS)
 override LIBS := -lecpg -lpgtypes $(filter -l%, $(libpq)) $(LIBS) $(PTHREAD_LIBS)
 
 # Standard way to invoke the ecpg preprocessor
-ECPG = ../../preproc/ecpg --regression -I$(srcdir)/../../include -I$(srcdir)
+ECPG = '$(DESTDIR)$(bindir)/ecpg' --regression -I$(srcdir)/../../include -I$(srcdir)
 
 # Files that most or all ecpg preprocessor test outputs depend on
-ECPG_TEST_DEPENDENCIES = ../../preproc/ecpg$(X) \
+ECPG_TEST_DEPENDENCIES =  \
        $(srcdir)/../regression.h \
        $(srcdir)/../../include/sqlca.h \
        $(srcdir)/../../include/sqlda.h \

--------------557C1BCDF691D2BBEFC24A2B--