Feedback-ID: ie0a040ee:Fastmail
Message-ID: <bff1d798-2fc4-48a8-b4eb-7a550be46d07@eisentraut.org>
Date: Thu, 16 Apr 2026 10:07:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Make copyObject work in C++
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>
References: <2h2n2gyw2f4ucicbl3drtdkjt2wzf6b2r4wqm7xwks6vpx5j7n@imymv4hkz5jz>
 <DGDRHFD14I7Z.30DSV2XVI6V93@jeltef.nl>
 <5291d173-1227-4619-b8fd-62336ad292b3@eisentraut.org>
 <CAGECzQSB=rBZ2n1WeCRAQ09xHzHSpyVBk-+NWEAcLsegsRXPzA@mail.gmail.com>
 <6dff90f6-2afb-44a3-9524-b017924d71da@eisentraut.org>
 <DHFMW63NP35Z.3RRS8PIYV508K@jeltef.nl>
 <7ddb8894-3939-4846-8d7f-d886b2cb42ab@eisentraut.org>
 <CAGECzQRauVYN19Y-DTiCTCkdNabh+ZqhdaLrUHR6CAU4wm2TFQ@mail.gmail.com>
 <8f4a2a1e-6142-4481-bc21-76fd33419103@eisentraut.org>
 <adeQc3I/4dwpeqEb@ip-10-97-1-34.eu-west-3.compute.internal>
 <ad48tOVLN5Vg73jR@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <ad48tOVLN5Vg73jR@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/bff1d798-2fc4-48a8-b4eb-7a550be46d07%40eisentraut.org>
Precedence: bulk

On 14.04.26 15:10, Bertrand Drouvot wrote:
> Hi,
> 
> On Thu, Apr 09, 2026 at 11:41:39AM +0000, Bertrand Drouvot wrote:
>> Hi,
>>
>> On Wed, Apr 01, 2026 at 07:54:07AM +0200, Peter Eisentraut wrote:
>>>
>>> Ok, I have committed the shown patch.
>>
>> d50c86e74375 added a comment mentionning that StaticAssertStmt is deprecated, so
>> we really need the one added in test_cplusplusext.cpp?
> 
> Now that 66ad764c8d5 is in, the only remaining use of StaticAssertStmt() is in
> test_cplusplusext.cpp. What about the attached to get rid of it?

This is a test module.  Even if the construct is deprecated, we can 
still test it.