Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lwLNn-00039k-Vh
	for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Jun 2021 09:10:47 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lwLNm-0007I1-RR
	for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Jun 2021 09:10:46 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <boris@codesynthesis.com>)
	id 1lwLNm-0007Hr-Js
	for pgsql-hackers@lists.postgresql.org; Thu, 24 Jun 2021 09:10:46 +0000
Received: from codesynthesis.com ([188.40.148.39])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <boris@codesynthesis.com>)
	id 1lwLNl-0002OK-HE
	for pgsql-hackers@lists.postgresql.org; Thu, 24 Jun 2021 09:10:46 +0000
Received: from brak.codesynthesis.com (unknown [105.225.47.95])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by codesynthesis.com (Postfix) with ESMTPSA id D761E5FB23;
	Thu, 24 Jun 2021 09:10:44 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codesynthesis.com;
	s=mail1; t=1624525845;
	bh=Ikq7qL4GGV5Eq55zY6SXd/o8hl3jtot+m9jLA3uOJLw=;
	h=Date:From:To:Subject:Message-ID:MIME-Version:From;
	b=gOYgkixJDnkw9zZgukbbmU5PtOaC+iDMgeuT83Oc07U+1z3NCZVm7G++PjRtePGwi
	 seXLz3SP1/yIpjVl4FgDIBLECrPclnvKhlCGRnkLRV8FHMuVOMKdn2oMG6SYMHPS/2
	 VQGfBiKgWsMatVMoUv3VWcIfrTYnfba72VQbLdddwm7nJoTs1GNK4QSp4Ocf+ZX8dV
	 EgHvakoWhZjukghL3qnM/PE/ZM3Ul3Nf1wZcLeoFR54QXDw9ceq3huvwagfOOUmdlJ
	 AXHKA5uoJYV+U4PIwV/9PkF9YyRAotRhEjvQaJpzwxxevyuYE6qfDxvDWLH+76tMjK
	 Sbpf4apNDCkZQ==
Received: by brak.codesynthesis.com (Postfix, from userid 1000)
	id 63BFD1A802C0; Thu, 24 Jun 2021 11:10:41 +0200 (SAST)
Date: Thu, 24 Jun 2021 11:10:41 +0200
From: Boris Kolpackov <boris@codesynthesis.com>
To: Alvaro Herrera <alvaro.herrera@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Pipeline mode and PQpipelineSync()
Message-ID: <boris.20210624110900@codesynthesis.com>
References: <boris.20210623125826@codesynthesis.com>
 <202106231655.5tkagqvcxej5@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202106231655.5tkagqvcxej5@alvherre.pgsql>
Organization: Code Synthesis
User-Agent: Mutt/1.5.24 (2015-08-30)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/boris.20210624110900%40codesynthesis.com>
Precedence: bulk

Alvaro Herrera <alvaro.herrera@2ndquadrant.com> writes:

> Subject: [PATCH] Clarify that pipeline sync is mandatory
> 
> ---
>  doc/src/sgml/libpq.sgml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
> index 441cc0da3a..0217f8d8c7 100644
> --- a/doc/src/sgml/libpq.sgml
> +++ b/doc/src/sgml/libpq.sgml
> @@ -5103,10 +5103,12 @@ int PQflush(PGconn *conn);
>       The server executes statements, and returns results, in the order the
>       client sends them.  The server will begin executing the commands in the
>       pipeline immediately, not waiting for the end of the pipeline.
> +     Do note that results are buffered on the server side; a synchronization
> +     point, establshied with <function>PQpipelineSync</function>, is necessary
> +     in order for all results to be flushed to the client.

s/establshied/established/

Otherwise, LGTM, thanks!