Date: Mon, 28 Jun 2021 14:56:43 +0200
From: Boris Kolpackov <boris@codesynthesis.com>
To: Alvaro Herrera <alvaro.herrera@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Pipeline mode and PQpipelineSync()
Message-ID: <boris.20210628145337@codesynthesis.com>
References: <202106252350.t76x73nt643j@alvherre.pgsql>
 <202106252352.5ca4byasfun5@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202106252352.5ca4byasfun5@alvherre.pgsql>
Organization: Code Synthesis
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/boris.20210628145337%40codesynthesis.com>
Precedence: bulk

Alvaro Herrera <alvaro.herrera@2ndquadrant.com> writes:

> I forgot to mention:
> 
> > +	/* XXX useless without a flush ...? */
> > +	pqFlush(conn);
> > +
> > +	return 1;
> > +}
> 
> I'm not sure if it's a good idea for PQrequestFlush to itself flush
> libpq's buffer.  We can just document that PQflush is required ...
> opinions?

Yes, I think not calling PQflush() gives more flexibility. For example,
an application may "insert" them periodically after a certain number of
queries but call PQflush() at different intervals.