Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1m1YoJ-0003Q4-L9
	for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Jul 2021 18:31:44 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1m1YoI-000396-Ko
	for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Jul 2021 18:31:42 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <boris@codesynthesis.com>)
	id 1m1YoI-00038x-9K
	for pgsql-hackers@lists.postgresql.org; Thu, 08 Jul 2021 18:31:42 +0000
Received: from codesynthesis.com ([188.40.148.39])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <boris@codesynthesis.com>)
	id 1m1YoF-0000ct-RY
	for pgsql-hackers@lists.postgresql.org; Thu, 08 Jul 2021 18:31:41 +0000
Received: from brak.codesynthesis.com (unknown [105.187.34.11])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by codesynthesis.com (Postfix) with ESMTPSA id E5AD35F16D;
	Thu,  8 Jul 2021 18:31:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codesynthesis.com;
	s=mail1; t=1625769097;
	bh=539h8hKlqYCu9EFXu3/SWtNi9+p2x1t4laKE1lgJoEc=;
	h=Date:From:To:Subject:Message-ID:MIME-Version:From;
	b=NI8zt9Qn43i51GGL4pO8Y51eJhaiRovUw6iEXGXnnpaARY6cYsibNKwxlrDho8Nh9
	 DHi4FItl+r88gDW/YnZc2Aj5FWoGpt2oD7EGEGE+5fjHtaNrOnmV0XOcs/uBrlWEWZ
	 DMfneHM2DWTbBNj8a9hO78Zqi1C6KUCoYNAolKcXGgbVmTXx3m0nBOI6kbTgLRDFhL
	 +HF4d0Xd7NfEHb4fBc1nZDsQsnX2QU1Rd2R8pFrNCYUpyarmZWCwgVc8MgEXMFnE62
	 fxgevFbubMWJx/FjGDd5qnQoY3qpq2yH3bZYT/HIdGBLtgTlYox7kZ/yndvzUwf/YW
	 r/1XQfDtQtmaQ==
Received: by brak.codesynthesis.com (Postfix, from userid 1000)
	id A01E31A800C4; Thu,  8 Jul 2021 20:31:32 +0200 (SAST)
Date: Thu, 8 Jul 2021 20:31:32 +0200
From: Boris Kolpackov <boris@codesynthesis.com>
To: Alvaro Herrera <alvaro.herrera@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org,
	Michael Paquier <michael@paquier.xyz>,
	Andrew Dunstan <andrew@dunslane.net>, Peter Geoghegan <pg@bowt.ie>
Subject: Re: Pipeline mode and PQpipelineSync()
Message-ID: <boris.20210708201732@codesynthesis.com>
References: <boris.20210708165230@codesynthesis.com>
 <202107081729.osyyji4ewzjk@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202107081729.osyyji4ewzjk@alvherre.pgsql>
Organization: Code Synthesis
User-Agent: Mutt/1.5.24 (2015-08-30)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/boris.20210708201732%40codesynthesis.com>
Precedence: bulk

Alvaro Herrera <alvaro.herrera@2ndquadrant.com> writes:

> To be honest, I am hesitant to changing the charter in that way; I fear
> it may have consequences I don't foresee.  I think the workaround is not
> *that* bad.

Ok, fair enough. I've updated my code to account for this and it seems
to be working fine now.


> I'm having a bit of trouble documenting this.  I modified the paragraph in the
> pipeline mode docs to read:
> 
>     <para>
>      <function>PQisBusy</function>, <function>PQconsumeInput</function>, etc
>      operate as normal when processing pipeline results.  Note that if no
>      queries are pending receipt of the corresponding results,
>      <function>PQisBusy</function> returns 0.
>     </para>

How about the following for the second sentence:

"In particular, a call to <function>PQisBusy</function> in the middle
of a pipeline returns 0 if all the results for queries issued so far
have been consumed."