Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8LWf-0006qM-BI for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Mar 2019 09:04:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h8LWe-0008Ir-44 for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Mar 2019 09:04:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8LWd-0008Cr-Jj for pgsql-hackers@lists.postgresql.org; Mon, 25 Mar 2019 09:04:11 +0000 Received: from cyclops.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h8LWa-0003sP-9B for pgsql-hackers@lists.postgresql.org; Mon, 25 Mar 2019 09:04:10 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id BEA5021C3E65; Mon, 25 Mar 2019 12:04:05 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from [192.168.27.200] (gw.postgrespro.ru [93.174.131.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 6278C21C3E64; Mon, 25 Mar 2019 12:04:05 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1553504645; bh=zcmzKNA/tANrfip9BEel4eNOADZhNDszZGX3gptR3Pk=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=OgZJ3OsYU2V8+rwPW6mdu0NyafyXHXHA0m9v2ah9otEPRbEPdhi0zncAj2HCevhKb o4XNoG6KTymAjAN+yyjF4Lxtp3ef02t/0/Fy8ByXYUQ1/ZE0wVFArQdPtnJ2owVqB1 wAldYYYPVWrzlvcvhW4yrkR5ugqw+CDD/P8rRRDo= Subject: Re: libpq compression To: David Steele Cc: Tomas Vondra , Peter Eisentraut , Robbie Harwood , Thomas Munro , Grigory Smolkin , PostgreSQL Hackers References: <429cf55b-a8bf-c4ba-196d-5b45420145a1@postgrespro.ru> <36db5d02-45e6-b863-1418-825ef20ae4c6@postgrespro.ru> <3b0260da-fe47-2341-da01-51383fe9172d@postgrespro.ru> <739641a6-f64d-0f2b-8483-34ab23e2dcd6@2ndquadrant.com> <2bc25ca4-2d60-a635-b0bc-5f7fd12ea4eb@pgmasters.net> From: Konstantin Knizhnik Message-ID: Date: Mon, 25 Mar 2019 12:04:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <2bc25ca4-2d60-a635-b0bc-5f7fd12ea4eb@pgmasters.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 25.03.2019 11:06, David Steele wrote: > Konstantin, > > > This patch appears to be failing tests so I have marked it Waiting on > Author. > > I have also removed the reviewer since no review had been done. Maybe > somebody else will have a look. > > Regards, Can you please inform me which tests are failed? I have done "make check-world" and there were no failed tests. Actually if compression is not enabled (and it is disabled by default unless explicitly requested by client), there should be no difference with vanilla Postgres. So it will be strange if some tests are failed without using compression. -- Konstantin Knizhnik Postgres Professional: http://www.postgrespro.com The Russian Postgres Company