Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1AQY-0005qV-Gd for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Mar 2018 12:43:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f1AQX-0005Ij-AE for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Mar 2018 12:43:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1AQX-0005Ia-2q for pgsql-hackers@lists.postgresql.org; Wed, 28 Mar 2018 12:43:41 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1AQT-0003rq-RL for pgsql-hackers@lists.postgresql.org; Wed, 28 Mar 2018 12:43:40 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 2B99B218C7; Wed, 28 Mar 2018 08:43:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 28 Mar 2018 08:43:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Q5x3BE uppuEGidQVlYTMTZ6HbvGxnCrDzxde3tkb2vc=; b=USceur6VS04fSIuNsOPkdn cwBxxwO8pItrVhWRqZwLwilKIY1UlCu4nsdG6+UTBILu2+BRM+CUP7pMCHcTFY6t 20HBMpzeyQh7OilUaPehniTsdZ9HXsijIBC3DELDzXl2Ntqo7wQdS7EYD29jU+iY xEL/J5c4PXh8l98i42XblNXmjvifIeXn1vBO/EWO+7nPS/ypg68WC6gXWiG2Q63w TyZ6kSyToqjjsgVcvnr8xb/n9J7jY+ptW+olVzxn8xXcQy9cSQFV6uR1+fzf6E0m wfneNIGOl7JcoDHZoXvOEcRwwbDLdHmQb0uGwqVBSw+yajcmiUjhYPonZmgBxmpw == X-ME-Sender: Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 3E53C102A0; Wed, 28 Mar 2018 08:43:34 -0400 (EDT) Subject: Re: Jsonb transform for pl/python From: Peter Eisentraut To: Nikita Glukhov , Aleksander Alekseev , pgsql-hackers@lists.postgresql.org References: <20171025145100.3a19933f@anthony-24-g082ur> <20180112140425.41174bd3@anthony-24-g082ur> <151577178706.20515.9599911730425998398.pgcf@coridan.postgresql.org> <84a3eaf4-32f6-d2dd-7139-e9c5dd3fec2d@2ndquadrant.com> Cc: Anthony Bykov Organization: 2ndQuadrant Message-ID: Date: Wed, 28 Mar 2018 08:43:33 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <84a3eaf4-32f6-d2dd-7139-e9c5dd3fec2d@2ndquadrant.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 3/21/18 18:50, Peter Eisentraut wrote: > On 3/12/18 11:26, Nikita Glukhov wrote: >> I have reviewed this patch. Attached new 6th version of the patch with >> v5-v6 delta-patch. > > Thanks for the update. I'm working on committing this. Committed. Everything seemed to work well. I just did a bit of cosmetic cleanups. I did a fair amount of tweaking on the naming of functions, the extensions and library names, etc., to make it look like the existing plpython transforms. I also changed it so that the transform would support mappings and sequences other than dict and list. I removed the non-ASCII test and the test with the huge numbers. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services