Feedback-ID: ie0a040ee:Fastmail
Message-ID: <c03e069d-7220-453d-9c5d-9fcc74518be0@eisentraut.org>
Date: Wed, 6 Nov 2024 17:11:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: doc: pgevent.dll location
To: "Ryohei Takahashi (Fujitsu)" <r.takahashi_2@fujitsu.com>,
 'Dave Page' <dpage@pgadmin.org>, Robert Haas <robertmhaas@gmail.com>
Cc: Gurjeet Singh <gurjeet@singh.im>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <TY3PR01MB118912125614599641CA881B782522@TY3PR01MB11891.jpnprd01.prod.outlook.com>
 <CABwTF4WczBfnRcqPpF+bfGbBXnv69TtauScokDSRYUvEHSSKDw@mail.gmail.com>
 <CA+Tgmoa_kC1T5PR0C7K0cGo1OEPx2c4zQ13ziwqm=pz7K_367g@mail.gmail.com>
 <CA+OCxoywke+6M7yO7-eUD4RwJiuGk-ydCJqh3bkbG3PjoLAhWg@mail.gmail.com>
 <TY3PR01MB118914759E215A415D418B42B82532@TY3PR01MB11891.jpnprd01.prod.outlook.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <TY3PR01MB118914759E215A415D418B42B82532@TY3PR01MB11891.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/c03e069d-7220-453d-9c5d-9fcc74518be0%40eisentraut.org>
Precedence: bulk

On 06.11.24 13:57, Ryohei Takahashi (Fujitsu) wrote:
> The dll install paths are changed as follows on Windows.
> 
> (1) pgevent.dll
> PG16: lib/
> PG17: bin/
> 
> (2) dll for user (like libpq.dll, libecpg.dll)
> PG16: Both in lib/ and bin/
> PG17: bin/
> 
> (3) contrib dll (like amcheck.dll)
> PG16: lib/
> PG17: lib/
> 
> 
> I understand that Dave says (1) and (2) should exist on bin/ directory
> and the paths in PG17 are correct.
> 
> So, I think it is correct to update documentation.

I don't have Windows handy to test it out, but looking at the respective 
build system source files, in master, pgevent is built and installed 
like a normal shared library in both meson.build and Makefile, so it 
should end up somewhere in lib.

In src/tools/msvc in REL_16_STABLE, I see some code that appears to 
suggest that it installs in bin.

Again, this is just reading the code, but it seems to be backwards from 
what is claimed earlier.

The statements like "in PGxxx it did this" are not precise enough 
because there are three possible build systems.  We need to know what 
each build system is doing.  Also, the consideration of consistency 
should go in two dimensions: Consistency between versions and 
consistency between build systems.