Message-ID: <c045d18e-7aee-4c6e-9dbd-df48b3cd44f2@vondra.me>
Date: Thu, 2 Jul 2026 10:29:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Changing the state of data checksums in a running cluster
To: Palak Chaturvedi <chaturvedipalak1911@gmail.com>,
 pgsql-hackers@postgresql.org
References: <7357A519-3391-4F07-BC69-5C9C2B120792@yesql.se>
 <4020B0AE-6286-462F-BD50-3AAD170F08C9@yesql.se>
 <30E2C103-2F50-4F9D-8868-E057250F55CA@yesql.se>
 <A65FA3A1-A5B6-44E6-B726-2A7D3692B1A6@yesql.se>
 <d4265f6d-ae6a-4a52-999a-092a883d9f46@iki.fi>
 <B3162DDF-435A-4BFD-A99B-32A038F57051@yesql.se>
 <F2EA770C-275F-41B3-A6F8-9AB12FE12BFD@yesql.se>
 <CAHg+QDfRk4-S7DMmdbXJnQ-xF=sUpMAKuh8b83ObLqYVKx5QLA@mail.gmail.com>
 <17BD06EB-3741-4921-AF60-6575FB4784ED@yesql.se>
 <9197F930-DDEB-4CAC-82A2-16FEC715CCE8@yesql.se>
 <CAHg+QDfS0Ckw2HT-TWkdvB1pq9rrFzm1Pk_AUwuFL+Er23ZOFA@mail.gmail.com>
 <F78D7C71-A999-4604-B1B9-FE06D21E63C5@yesql.se>
 <CAJTYsWUq96LR=DSh0jcbZLwJekT06Z2PGND6GYaS0SANFC9E7A@mail.gmail.com>
 <6011EEE0-2D34-4A63-8B88-2437173486FE@yesql.se>
 <CAHg+QDeGrpZbNZdLjd_T4b43xKEEXZN0HGhkFm-1bkBdyzK7AQ@mail.gmail.com>
 <525E0691-FDAD-4194-9228-592A2DB96749@yesql.se>
 <9e1331e1-93a0-4e27-934a-17b89342be4d@vondra.me>
 <CALfch1-earbZTedkbb_3=PgywzBVAc1FXZfz834bb0DKZGDEXw@mail.gmail.com>
Content-Language: en-US
From: Tomas Vondra <tomas@vondra.me>
In-Reply-To: 
 <CALfch1-earbZTedkbb_3=PgywzBVAc1FXZfz834bb0DKZGDEXw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/c045d18e-7aee-4c6e-9dbd-df48b3cd44f2%40vondra.me>
Precedence: bulk


On 7/2/26 07:06, Palak Chaturvedi wrote:
> Hi Tomas,
> 
> Thanks for these test patches. They are quite useful. I've been going
> through them because we think they'll also help with the TAP tests for
> the online shared_buffers resize work , where I'm ending up reusing
> several of the same helpers (attach_injection_points,
> background_rw_pgbench, and a couple of others).
> Would you be open to lifting these helpers out into a shared Perl module
> (for example under src/test/perl/PostgreSQL/Test/…) so both test suites
> can consume them instead of each copy-pasting? I'm happy to prepare a
> small prep patch on top of your latest version if that sounds reasonable
> to you.
> 

I suppose you mean the functions for managing injection points (waiting,
waking, attachin/detaching, ...)? Yes, it might be useful to have that
in a Perl module, so feel free to create one.


regards

-- 
Tomas Vondra