Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPWS8-00061n-Eu for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Feb 2023 22:28:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pPWS6-0007qq-U9 for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Feb 2023 22:28:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPWS6-0007qh-K5 for pgsql-hackers@lists.postgresql.org; Tue, 07 Feb 2023 22:28:38 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPWS3-0006Hq-Ne for pgsql-hackers@lists.postgresql.org; Tue, 07 Feb 2023 22:28:38 +0000 Received: by mail-wm1-x330.google.com with SMTP id n13so12067557wmr.4 for ; Tue, 07 Feb 2023 14:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JzEj86auMEki/jSUlNELkDbhv6OdIVi/W1ipyTOr9Gc=; b=MIy8KRsiwGOo/lm6apZRqSlgnRiqHrIex6lY5I33ptpgT4cvPNgSynezv2tA0dSZii 6Y28sxsJitvb4mtOpEWnjcRt6AvAUsJlJyKrT2VmfN6Gmhwax4RxBKNU4vTXkqzgGec/ ONHcjef8O7vtiih7QhilsjDR0YAM1zCyLSpKJKi75MeAzTQmR1uiUMP1Z1r8Ldvit2oR /hJpdpvgPBjBOmP+HU0EIC3ucQMW89DBJrC9Kou4WyALPs4xqOwZNweROVf3CiNGoU5X 1Qv07a6lfwnlnhjQWHk4z8jJq/RAU2hdy1UHZ1Ph2jsGXVZFRnMv445pmDllCOxrtHii TAKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JzEj86auMEki/jSUlNELkDbhv6OdIVi/W1ipyTOr9Gc=; b=G0jgGJ3y81f0+Z0tDp/8cj+/yRstPyKnyRhvyFBWYHQAhSuCUb5vxlpPdIqjX1nBjU xTMAfSIJEI6gxyRJLYFxLbSRZDLolGwU17F5vVDWA++uVsPl6y1Vgs+s2g9MJZPpHT8k bqXQCvnnnT9rpILxlbD0RsVdanYfYiWLsGfmdqEqoq9iN4/JVi1ahxEiZnMtZjCYDgui fkdy4Z76jmRZlzEiC3CCZIedi3Wh1KQoGGelqk1hfq30IE/x7crB64MScr1j7PgBo6Y/ GQ2BxybFDFpXeZ38PYPI0qtAiz1K5uytRQqIQWtlTv5ij9Lb79n6R76gxOYaHMasKoOd LnMA== X-Gm-Message-State: AO0yUKXCABMbp3XDvpTrmxCvAZQBEpjkmIrXPtA4WOJUb6ng2SgSfNT4 pC0hAqy9TC483/2HS5hwyNZwjtT5u3BCxgh190D+R0lyiudVfrAp427boPDcB4P65WjzYWyrPsx t2isII55w+qQ4Zm0XDaNx2RP8Gtqdsi0ta9aro5YOyybHMUdDswlHqvSN/uAIpTuebH/nK9aVwO HCYJXDS9kW1VkTqZ2SKFJGZ1fWlI7SNcf0XZVzW5x9V1Tk1pVP5JghCdqwV9YAR8UrpPoldvGll zFQznYV6aOhEvx2bxAMZBkdhlNg8NSji2yKUbBjw1KBjLE3uv+SqO3kToh3bJr65oJkoqM= X-Google-Smtp-Source: AK7set8957MTJzr5nf9Luio6b4UANAN/+37YEd+ShpFMmJu7Aj9CiifwrTex7LuHjUH9hCeaTGPlkw== X-Received: by 2002:a05:600c:4da4:b0:3dc:443e:420e with SMTP id v36-20020a05600c4da400b003dc443e420emr4416768wmp.2.1675808914372; Tue, 07 Feb 2023 14:28:34 -0800 (PST) Received: from [10.137.0.17] (ip-86-49-228-162.bb.vodafone.cz. [86.49.228.162]) by smtp.gmail.com with ESMTPSA id z4-20020a05600c220400b003dfe8c4c497sm78504wml.39.2023.02.07.14.28.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 14:28:34 -0800 (PST) Message-ID: Date: Tue, 7 Feb 2023 23:28:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: daitch_mokotoff module To: Paul Ramsey , Dag Lem Cc: PostgreSQL Hackers References: <20221225130136.oyfh5jcw3xxkvq34@alvherre.pgsql> <889A5DE5-D123-4A2A-B390-D59AE5117E28@cleverelephant.ca> Content-Language: en-US From: Tomas Vondra In-Reply-To: <889A5DE5-D123-4A2A-B390-D59AE5117E28@cleverelephant.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2/7/23 18:08, Paul Ramsey wrote: > > >> On Feb 7, 2023, at 6:47 AM, Dag Lem wrote: >> >> I just went by to check the status of the patch, and I noticed that >> you've added yourself as reviewer earlier - great! >> >> Please tell me if there is anything I can do to help bring this across >> the finish line. > > Honestly, I had set it to Ready for Committer, but then I went to run regression one more time and my regression blew up. I found I couldn't enable the UTF tests without things failing. And I don't blame you! I think my installation is probably out-of-alignment in some way, but I didn't want to flip the Ready flag without having run everything through to completion, so I flipped it back. Also, are the UTF tests enabled by default? It wasn't clear to me that they were? > The utf8 tests are enabled depending on the encoding returned by getdatabaseencoding(). Systems with other encodings will simply use the alternate .out file. And it works perfectly fine for me. IMHO it's ready for committer. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company