Sounds like we have a consensus. I have committed the three bug-fix
patches (unrelated to the retry-loop stuff) ...
Thanks again for committing these fixes, Robert! With all the fixes
in
place, I and SQLsmith have reached another error:
CREATE TABLE t1(a int);
CREATE TABLE t2(b int);
SELECT 1 FROM t1 WHERE EXISTS
(SELECT 1 FROM
(SELECT 1 FROM
(SELECT 1) LEFT JOIN t2 ON true),
t2 WHERE a = b);
ERROR: XX000: unique semijoin found for relids (b 3 5 7) but not
observed during planning
LOCATION: pgpa_plan_walker, pgpa_walker.c:153