Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vaf1C-00Badg-1y for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Dec 2025 19:04:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vaf1A-004ZaT-1A for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Dec 2025 19:04:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vaf19-004ZaJ-2s for pgsql-hackers@lists.postgresql.org; Tue, 30 Dec 2025 19:04:28 +0000 Received: from mail.postgrespro.ru ([93.174.132.70]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vaf17-003NbK-2n for pgsql-hackers@postgresql.org; Tue, 30 Dec 2025 19:04:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1767121461; bh=hHjSWG5x5sC7zLHfQTUGritI3tp7Iu4luGwjKxPSLzk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID:From; b=fOZJowiZU6fgLE2et3IFP2uy/BbH4MhrEsBi/VCGmQ8P4a3X8WJ/q2ukhAFJbUiFP OP6Ql3afAD1Q4xz8kNx/nr9DD/EQXy3LFFqATQPb3KbDc1pm/GW3WHsngJw2SIvuyd yvqaj3X1m+uGMRYOoYKNEmrmEhSERn7HGR5Ik6Si34PUaZjmGAvP+zBKXyBGHk72Ct zLDuM4UWQIbAo3FpzFHQRHGaDPGsPif0eHa4rfxPc5pAJf1wZRttNYvlyFczaodf7x 9+s4tYlpKFoKyIQdArkhMUik5R9h3zi7Dh7B8+iQM/Wq4g2+FFfEbA78W4qyPicrb3 Ct9VeFkIcLo/A== Received: from mail.postgrespro.ru (webmail-slave-mstn.l.postgrespro.ru [192.168.2.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: a.pyhalov@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id A55EF601D7; Tue, 30 Dec 2025 22:04:21 +0300 (MSK) MIME-Version: 1.0 Date: Tue, 30 Dec 2025 22:04:21 +0300 From: Alexander Pyhalov To: Matheus Alcantara Cc: Alena Rybakina , Pgsql Hackers Subject: Re: Asynchronous MergeAppend In-Reply-To: References: <59be194c5a409fb9fc9f2031581b8a44@postgrespro.ru> <764dd8b8-6374-4f5a-aac7-d8e3f6ebe5fd@postgrespro.ru> <159b591411bb2c81332018927acbd509@postgrespro.ru> <2fb1d9923b6995492e7b163e6cb95402@postgrespro.ru> Message-ID: X-Sender: a.pyhalov@postgrespro.ru Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-KSMG-AntiPhishing: NotDetected X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/12/30 17:56:00 #28076292 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Matheus Alcantara писал(а) 2025-12-30 18:04: > On Tue Dec 30, 2025 at 10:15 AM -03, Alexander Pyhalov wrote: >> Looks good. What do you think about >> classify_matching_subplans_common()? >> Should it stay where it is or should we hide it to >> src/include/executor/execAppend.h ? >> > Yeah, sounds better to me to move classify_matching_subplans_common to > execAppend.h since it very specific for the MergeAppend and Append > execution. I've declared the function as static inline on execAppend.h > but I'm not sure if it's the best approach. > > I've also wrote a proper commit message for this new version. Looks good to me. -- Best regards, Alexander Pyhalov, Postgres Professional