Message-ID: <c0e0bf99-bda0-429f-a2bf-583097da4f1c@iki.fi>
Date: Fri, 4 Apr 2025 12:58:15 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: Network failure may prevent promotion
To: Yura Sokolov <y.sokolov@postgrespro.ru>,
 Robert Haas <robertmhaas@gmail.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: masao.fujii@gmail.com, andres@anarazel.de, michael@paquier.xyz,
 pgsql-hackers@lists.postgresql.org
References: <CAHGQGwGSQratfsnAwAH6kygmdfv7u+S3UzcwbwB66YzoWZiFaQ@mail.gmail.com>
 <20240123.172410.1596193222420636986.horikyota.ntt@gmail.com>
 <ea7b8012-b739-436e-afe4-be0b2f69b304@iki.fi>
 <20240129.163206.738744107103873975.horikyota.ntt@gmail.com>
 <CA+TgmoZneP50v-dFe6U2Tcrdm2MPOMaiB=o3EVgbHQky53mpEg@mail.gmail.com>
 <d0c357e9-0978-466e-9830-148f816d9367@postgrespro.ru>
Content-Language: en-US
In-Reply-To: <d0c357e9-0978-466e-9830-148f816d9367@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/c0e0bf99-bda0-429f-a2bf-583097da4f1c%40iki.fi>
Precedence: bulk

On 21/03/2025 15:24, Yura Sokolov wrote:
> I've just rebased patches and merged last two fix-commits (0003 and 0004)
> into 0002.

Thanks for reviving this! I looked over this again and committed.

On May 14, 2024 at 14:16 Robert Haas <robertmhaas@gmail.com> wrote:
> I think it would be helpful to make it more clear exactly what's going
> on here. It looks 0001 is intended to revert
> 21ef4d4d897563adb2f7920ad53b734950f1e0a4, which was itself a revert of
> 728f86fec65537eade8d9e751961782ddb527934, and then I guess the
> remaining patches are to fix up issues created by that commit, but the
> commit messages aren't meaningful so it's hard to understand what is
> being fixed.

Yes, that's exactly what's going on here :-). I squashed the patches 
together and explained that in the commit message.

> I think it would also be useful to clarify whether this is imagined to
> be for master only, or something to be back-patched. In addition to
> mentioning that here, it would be good to add that information to the
> target version field of  https://commitfest.postgresql.org/48/4748/

A lot of time and v17 release passed since you wrote this, but for sake 
of completeness: This is for v18 only. It's not a bug fix. There was an 
bug with the original commit 728f86fec6, which was resolved by reverting 
it in v16 and v17. This commit brings it back in v17, hopefully bug-free 
this time.

-- 
Heikki Linnakangas
Neon (https://neon.tech)