public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: jian he <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Dean Rasheed <[email protected]>
Subject: Re: Virtual generated columns
Date: Wed, 8 Jan 2025 17:17:13 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxHG+T4de6sSyxuM+SL7M1xM5sX+eTv1+C4SQGzigY=9uA@mail.gmail.com>
References: <[email protected]>
	<CACJufxHxoz_KVQxcQ=cSvJc+PNbh=FaHbcMZCOisoOaGAgjy4w@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAEZATCV=RX0M58-uqSR6tFjwQAFnEcx3hvW-9ZZfRQJLg5LzRw@mail.gmail.com>
	<[email protected]>
	<CAEZATCU3q=znAL7X1aSxuMpjfSyB1cT5j398HPb9ix9ci_HUqA@mail.gmail.com>
	<[email protected]>
	<CAEZATCVLfMzNwT1J0bnvtv6YbmNSN9QSXb+1QSGyX6vK4q67Ow@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAEZATCUHnmOu7RtDuP+PCtS_dqvU8hFsAYYFPdiB8gyFszj5WQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CACJufxHG+T4de6sSyxuM+SL7M1xM5sX+eTv1+C4SQGzigY=9uA@mail.gmail.com>

On 04.12.24 05:55, jian he wrote:
> On Fri, Nov 29, 2024 at 6:13 PM Peter Eisentraut <[email protected]> wrote:
>>
>> - Added support for virtual columns in trigger column lists.  (For that,
>> I renamed ExecInitStoredGenerated() to ExecInitGenerated(), which
>> handles the computation of ri_extraUpdatedCols.)
>>
> 
> why not duplicate some code from ExecInitStoredGenerated to
> ExecGetExtraUpdatedCols?

This answers itself: I'd rather not duplicate code.  I don't see that as 
an improvement.

> * now the expression is that something initiated for the virtual
> generated column. which may not be necessary for virtual columns.
> let's make ResultRelInfo->ri_GeneratedExprsI,
> ResultRelInfo->ri_GeneratedExprsU be NULL for virtual columns.
> 
> currently it may look like this:
> (gdb) p resultRelInfo->ri_GeneratedExprsU
> $20 = (ExprState **) 0x34f9638
> (gdb) p resultRelInfo->ri_GeneratedExprsU[0]
> $21 = (ExprState *) 0x0
> (gdb) p resultRelInfo->ri_GeneratedExprsU[1]
> $22 = (ExprState *) 0x0
> (gdb) p resultRelInfo->ri_GeneratedExprsU[2]
> $23 = (ExprState *) 0x40

I have fixed that in v11.

> * ExecInitStoredGenerated main used in ExecComputeStoredGenerated.
> * we also need to slightly change ExecInitGenerated's comments.

also fixed

> * in InitResultRelInfo, do we need explicit set ri_Generated_valid to false?

Doesn't seem necessary.  The struct is initialized to zero at the beginning.

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Virtual generated columns
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox