MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Fri, 02 Nov 2018 07:55:05 +0100
From: Erik Rijkers <er@xs4all.nl>
To: Euler Taveira <euler@timbira.com.br>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Suzuki Hironobu
 <hironobu@interdb.jp>
Subject: Re: row filtering for logical replication
In-Reply-To: 
 <CAHE3wggmjJCj=-u7G=WQGvDOxwfr3Tikqh240LUhtfYcyBDuKw@mail.gmail.com>
References: 
 <CAHE3wggb715X+mK_DitLXF25B=jE6xyNCH4YOwM860JR7HarGQ@mail.gmail.com>
 <CAHE3wgiHOdFHcEpm_w5f8vAXiugDmTciTiegNGVktezMbFkkrg@mail.gmail.com>
 <37d16603194380f43b0630ee1357d46f@xs4all.nl>
 <0bfccedb6ee196b3f5f4e3a96adadb03@xs4all.nl>
 <CAHE3wggmjJCj=-u7G=WQGvDOxwfr3Tikqh240LUhtfYcyBDuKw@mail.gmail.com>
Message-ID: <c1791604db16e94b40ccae60ccaa7a64@xs4all.nl>
User-Agent: XS4ALL Webmail
Precedence: bulk

On 2018-11-02 02:59, Euler Taveira wrote:
> Em qui, 1 de nov de 2018 às 05:30, Erik Rijkers <er@xs4all.nl> 
> escreveu:
>> > I ran pgbench-over-logical-replication with a WHERE-clause and could
>> > not get this to do a correct replication.  Below is the output of the
>> > attached test program.
>> >
>> >
>> > $ ./logrep_rowfilter.sh
>> 
> Erik, thanks for testing.
> 
>> So it seems this bug is due to some timing error in your patch (or
>> possibly in logical replication itself).
>> 
> It is a bug in the new synchronization code. I'm doing some code
> cleanup/review and will post a new patchset after I finish it. If you
> want to give it a try again, apply the following patch.
> 
> diff --git a/src/backend/replication/logical/tablesync.c
> b/src/backend/replication/logical/tablesync.c
> index e0eb73c..4797e0b 100644
> --- a/src/backend/replication/logical/tablesync.c
> +++ b/src/backend/replication/logical/tablesync.c
> [...]


That does indeed fix it.

Thank you,

Erik Rijkers