Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJzAP-0002cw-8V for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jan 2023 15:55:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pJzAN-0000bT-IM for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jan 2023 15:55:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJzAM-0000bC-PE for pgsql-hackers@lists.postgresql.org; Mon, 23 Jan 2023 15:55:27 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJzAJ-0003L5-H8 for pgsql-hackers@postgresql.org; Mon, 23 Jan 2023 15:55:25 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id B98502B06826; Mon, 23 Jan 2023 10:55:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 23 Jan 2023 10:55:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674489320; x= 1674496520; bh=438MRxL1x7t3OJnt3def4178Zpom+uDDPmVpk7c8CEk=; b=C YZPpjFBP1D2iNFiZttC4xb/Bqj3geVsenVpRvZi0GUd2NvtsdxbW48bddfTE4AiF 1P6IwdlpuXO17J6ya9U5yxRcuAdW3mnDFkHL8rK4LCyUq2Mrtao37fIDXkP4cXfo IUh1DtSHGwgbrxKWM2k2TCC2P0f+KLPBQybYeN0eMnAeYWeKRAcrYMM7oHiPKEZ9 lIAmkjxOBOLBgZtVBl2doa0L2wMMuXaBZrEQh/gVHPM69THTYLYTeQ9wSlHuMYKK P8afTGaHfq9RtZoH446V/V9Wxb635eL8YbP8E38fAEvG3HM1ElLXbrb4MxlAUOmB DODbGc7KmRTRsF+vPD6qA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddukedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehleffgeegudejteei hfelteduvdeifffhffdvjedvffegjeekudeludehudeifeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 Jan 2023 10:55:19 -0500 (EST) Message-ID: Date: Mon, 23 Jan 2023 16:55:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Non-decimal integer literals To: Dean Rasheed Cc: David Rowley , John Naylor , pgsql-hackers , Tom Lane References: <2317133.1643155358@sss.pgh.pa.us> <97aa22d7-b80f-efa1-f368-3dbf73a15980@enterprisedb.com> <071c40f2-15cf-5db3-8799-dbac041bb881@enterprisedb.com> <791aee01-f488-0706-2694-08c5b57a3bdd@enterprisedb.com> <164fea20-dae9-d0fb-9917-772cd0068d29@enterprisedb.com> <404b6297-a22f-afea-cdcb-848543c39193@enterprisedb.com> <6e7d5b72-eaa6-e481-71d4-61a0a057949c@enterprisedb.com> Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 13.01.23 11:01, Dean Rasheed wrote: > So I'm feeling quite good about the end result -- I set out hoping not > to make performance noticeably worse, but ended up making it > significantly better. This is great! How do you want to proceed? You also posted an updated patch in the "underscores" thread and suggested some additional work there. In which order should these be addressed, in your opinion?