Subject: Re: I propose killing PL/Tcl's "modules" infrastructure
To: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan
	<andrew.dunstan@2ndquadrant.com>
References: <22067.1488046447@sss.pgh.pa.us>
 <234c68e3-47ee-4db1-fe6d-6a5de56575b6@2ndQuadrant.com>
 <23184.1488048288@sss.pgh.pa.us>
 <33fe0208-74df-1a03-08af-9a4f0d1ed14d@2ndQuadrant.com>
 <24478.1488050485@sss.pgh.pa.us>
 <45faa542-212a-5225-2b62-c80a8df2d0fd@2ndQuadrant.com>
 <18606.1488138882@sss.pgh.pa.us>
 <b8362f6c-1638-4164-7bbe-f68fb6531258@2ndQuadrant.com>
 <21254.1488228146@sss.pgh.pa.us>
CC: <pgsql-hackers@postgresql.org>, Jan Wieck <jan@wi3ck.info>
From: Jim Nasby <Jim.Nasby@BlueTreble.com>
Message-ID: <c1d9adea-f80c-4ea7-d8a4-efdceb277bb2@BlueTreble.com>
Date: Wed, 1 Mar 2017 16:31:36 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <21254.1488228146@sss.pgh.pa.us>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2017 01:50:03.5555 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1635
X-Pg-Spam-Score: -0.4 (/)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 2/27/17 2:42 PM, Tom Lane wrote:
> + SET pltcl.start_proc = 'no_such_function';
> + select tcl_int4add(1, 2);
> + ERROR:  function no_such_function() does not exist

Can the error message be more explicit somehow? Otherwise people will be 
quite confused as to where no_such_function() is coming from.

<begin creature-feep>
BTW, I'd think this functionality would be valuable for every PL. Maybe 
it's worth adding formal support for it to pg_language et all and leave 
it up to each language to decide whether it's supported or not? Multiple 
init functions might be useful too, similar to how we support multiple 
hook functions (though presumably a field of regproc[] is a better way 
to handle that...)

I'm also wondering if there'd be value to supporting code that runs on 
each function invocation.
-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers