Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8yCu-00070a-31 for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Jul 2022 06:08:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yCs-0002JB-Vq for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Jul 2022 06:08:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8yCs-0002Hc-Hv for pgsql-hackers@lists.postgresql.org; Wed, 06 Jul 2022 06:08:14 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8yCp-0006PG-Eu for pgsql-hackers@postgresql.org; Wed, 06 Jul 2022 06:08:13 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BDD085C014E; Wed, 6 Jul 2022 02:08:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 06 Jul 2022 02:08:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657087690; x= 1657174090; bh=j0/2UPwAw8uokQT4G5tA+VQHkRmIxKblRHdukz30O7Y=; b=n f2RK+d8j/EdbR4rRrHxeqxM9J2sfdYrYmGa+7WIndo0dgRVrkHV5EdyznfIADcUe VqKeCCS08c49zwX4Zkyx87oTPpZ0jgcwzTkReLBF62pw+B4FOiqzwTbogeWji4Ym 4TsCCwgHwOsmUnlRTw2tC0QbwoHD6vMYKjL6F15si1setLMnm3HKeEQWz4hcRIhf Z8o891VJwLOX7lEE9uwrO2mY2Ln3NM2omADOlE+pl9tvSumZ39LTgJ+vPUnQXLGf YMoZincmVIY+vK1Q7t7PmNlpgSIxquQKLtITkFj8ApPyIq3ORSfDJbpC05eFI2hI 4fr6hg+Ra1uvvELMR+vww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeivddguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvvehfhfgjtgfgse htjeertddtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvght vghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtf frrghtthgvrhhnpeehleffgeegudejteeihfelteduvdeifffhffdvjedvffegjeekudel udehudeifeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehpvghtvghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 02:08:10 -0400 (EDT) Message-ID: Date: Wed, 6 Jul 2022 08:08:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Unify DLSUFFIX on Darwin Content-Language: en-US To: Tom Lane Cc: pgsql-hackers References: <3336874.1655905520@sss.pgh.pa.us> <348725.1656080031@sss.pgh.pa.us> From: Peter Eisentraut In-Reply-To: <348725.1656080031@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 24.06.22 16:13, Tom Lane wrote: > [ thinks for a bit... ] Might be worth double-checking that pg_upgrade > doesn't get confused in a cross-version upgrade. A quick grep doesn't > find that it refers to DLSUFFIX anywhere, but it definitely does pay > attention to extensions' shared library names. pg_upgrade just checks that it can "LOAD" whatever it finds in probin. So this will work if extensions use the recommended extension-free file names. If they don't, they should get a clean failure. If this becomes a problem in practice, we could make pg_dump automatically adjust the probin on upgrade from an old version. I have committed this now. We can see how it goes.