Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vaZZp-00APKs-2t for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Dec 2025 13:15:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vaZZo-0044L8-2o for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Dec 2025 13:15:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vaZZo-0044L0-1K for pgsql-hackers@lists.postgresql.org; Tue, 30 Dec 2025 13:15:53 +0000 Received: from mail.postgrespro.ru ([93.174.132.70]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vaZZm-003LF3-0x for pgsql-hackers@postgresql.org; Tue, 30 Dec 2025 13:15:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1767100546; bh=/ss9nsjZAglJdLiMDuASjyJpbBfGs3aP1KUm+PCIW/A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID:From; b=SzV3MjY6ai0rrb8ibENOvB48fBDTJer25hYqiZvJUPz8cc1K0QeoS0KaZTPAQWjr/ A3IwgpBZfL9sYS3pA9U5y3wQ4XUwTtCEslKJlz6ZH+T5WeoqVBlIx8YSXKMfIXKiLo 2Ukjxbjo/bPec/79rDi7BhDfmCzaGij3jL9OT9oASQA3ab8gsm/MJ5Xm3jKiZ8NrFg 6/Ks09jBMVeSLsJilTy+j4j5KWgMfBT6gLVkluxgNIMYNzTaJU5S27ui3IV+ALF71s IgmxBy4t9BSmIlJ0LZ0OEYf9968q3js9zvnjdGBAhZGl70MMtpsiJVSCQAZj2TjTrC 6qK8bFBDk9tiw== Received: from mail.postgrespro.ru (webmail-slave-mstn.l.postgrespro.ru [192.168.2.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: a.pyhalov@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id D89A3600C9; Tue, 30 Dec 2025 16:15:45 +0300 (MSK) MIME-Version: 1.0 Date: Tue, 30 Dec 2025 16:15:45 +0300 From: Alexander Pyhalov To: Matheus Alcantara Cc: Alena Rybakina , Pgsql Hackers Subject: Re: Asynchronous MergeAppend In-Reply-To: References: <59be194c5a409fb9fc9f2031581b8a44@postgrespro.ru> <764dd8b8-6374-4f5a-aac7-d8e3f6ebe5fd@postgrespro.ru> <159b591411bb2c81332018927acbd509@postgrespro.ru> <2fb1d9923b6995492e7b163e6cb95402@postgrespro.ru> Message-ID: X-Sender: a.pyhalov@postgrespro.ru Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-KSMG-AntiPhishing: NotDetected, bases: 2025/12/30 12:54:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/12/30 11:52:00 #28075520 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Matheus Alcantara писал(а) 2025-12-29 16:43: > On Tue Dec 23, 2025 at 5:50 AM -03, Alexander Pyhalov wrote: >> I've looked through updated patch. Tested it (also with our fdw). >> Overall looks good. >> > Thanks for testing. > >> In execAppend.c there's still reference to as_valid_subplans. Also we >> could perhaps use palloc0_array() in some more places, for example, >> for >> for state->asyncrequests and state->asyncresults. >> > Fixed on the new attached version. > > -- > Matheus Alcantara > EDB: https://www.enterprisedb.com Hi. Looks good. What do you think about classify_matching_subplans_common()? Should it stay where it is or should we hide it to src/include/executor/execAppend.h ? -- Best regards, Alexander Pyhalov, Postgres Professional