Feedback-ID: i0c21471d:Fastmail
MIME-Version: 1.0
Date: Thu, 04 Dec 2025 17:11:15 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Aleksander Alekseev" <aleksander@tigerdata.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: "Michael Paquier" <michael@paquier.xyz>,
 "Peter Eisentraut" <peter@eisentraut.org>
Message-Id: <c269e7e1-2ef0-4fb2-8ecd-18ab2db13e3b@app.fastmail.com>
In-Reply-To: 
 <CAJ7c6TOgh15gX1ZXVEHVOBahR30pVU=HLL-30u1Rt38uxDKVkQ@mail.gmail.com>
References: <435df33a-129e-4f0c-a803-f3935c5a5ecb@eisentraut.org>
 <aSaDfIrZIhZwAe42@paquier.xyz>
 <c822b84c-b104-4fb4-92f3-3008cce50bf9@app.fastmail.com>
 <CAJ7c6TOgh15gX1ZXVEHVOBahR30pVU=HLL-30u1Rt38uxDKVkQ@mail.gmail.com>
Subject: Re: change default default_toast_compression to lz4?
Content-Type: multipart/mixed;
 boundary=0b1f26b1c669412c9334f86c40dfa66c
Archived-At: 
 <https://www.postgresql.org/message-id/c269e7e1-2ef0-4fb2-8ecd-18ab2db13e3b%40app.fastmail.com>
Precedence: bulk

--0b1f26b1c669412c9334f86c40dfa66c
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Thu, Nov 27, 2025, at 6:44 AM, Aleksander Alekseev wrote:
> Many thanks for working on this. Unfortunately the patch is
> incomplete. I think we also agreed that lz4 should be opt-out.
>

Aleksander, I missed this point.

Here it is v2. It enforces the lz4 dependency. It works the same as other
dependencies (readline, icu, zlib); error if the dependency could not be found.
Regarding meson, I'm confused. If any of the referred dependencies (icu,
readline, zlib) is not found, there is no hard error. Instead, the feature is
disabled. I searched for a discussion about this decision but couldn't find.
For this patch, I decided to use the same pattern (no error) but I added a
warning message (similar to zlib).

$ meson setup build --prefix=/tmp/pg | grep -i warning
meson.build:1100: WARNING: did not find lz4
meson.build:1675: WARNING: did not find zlib

The other alternative is to always 'enabled' lz4 in meson_options.txt. This
requires you to explicitly enable/disable lz4 if you are using -Dauto_features
option.

Should it report an error (like autoconf) instead of silently disable the
feature that is a requirement? If yes, then we should add error messages for
these 3 dependencies.

$ ./configure --prefix=/tmp/pg
.
.
checking whether to build with ICU support... yes
checking for icu-uc icu-i18n... no
configure: error: Package requirements (icu-uc icu-i18n) were not met:

Package 'icu-uc', required by 'virtual:world', not found
Package 'icu-i18n', required by 'virtual:world', not found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables ICU_CFLAGS
and ICU_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

$ git clean -dfxq
$ meson setup build --prefix=/tmp/pg
.
.
Run-time dependency icu-uc found: NO (tried pkgconfig and cmake)
Run-time dependency icu found: NO (tried cmake)
.
.
Run-time dependency readline found: NO (tried pkgconfig and cmake)
Library readline found: NO
.
.
  External libraries
    bonjour                : NO
    bsd_auth               : NO
    docs                   : NO
    docs_pdf               : NO
    gss                    : NO
    icu                    : NO
    ldap                   : NO
    libcurl                : NO
    libnuma                : NO
    liburing               : NO
    libxml                 : NO
    libxslt                : NO
    llvm                   : NO
    lz4                    : NO
    nls                    : YES
    openssl                : NO
    pam                    : NO
    plperl                 : NO 5.40.1
    plpython               : NO
    pltcl                  : NO
    readline               : NO
    selinux                : NO
    systemd                : NO
    uuid                   : NO
    zlib                   : NO
    zstd                   : NO

  User defined options
    prefix                 : /tmp/pg

Found ninja-1.12.1 at /usr/bin/ninja


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/
--0b1f26b1c669412c9334f86c40dfa66c
Content-Disposition: attachment;
	filename*0="v2-0001-Change-default_toast_compression-to-lz4.patch"
Content-Type: text/x-patch;
	name="=?UTF-8?Q?v2-0001-Change-default=5Ftoast=5Fcompression-to-lz4.patch?="
Content-Transfer-Encoding: base64

RnJvbSBkNzAwNjA5YjJjMTk0ZTAwYzdkZWQ2ZWQ5YTE2ZGQ2MDQyN2ZmODQ2IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBFdWxlciBUYXZlaXJhIDxldWxlckBldWxlcnRvLmNv
bT4KRGF0ZTogV2VkLCAyNiBOb3YgMjAyNSAxMjo0MDo0MyAtMDMwMApTdWJqZWN0OiBbUEFU
Q0ggdjJdIENoYW5nZSBkZWZhdWx0X3RvYXN0X2NvbXByZXNzaW9uIHRvIGx6NAoKVGhlIGRl
ZmF1bHQgdmFsdWUgZm9yIGRlZmF1bHRfdG9hc3RfY29tcHJlc3Npb24gd2FzIHBnbHouIFRo
ZSBtYWluCnJlYXNvbiBpcyB0aGF0IHRoaXMgb3B0aW9uIGlzIGFsd2F5cyBhdmFpbGFibGUu
IEhvd2V2ZXIsIGl0IGlzIGtub3duCnRoYXQgcGdseiB1c2VzIG1vcmUgQ1BVIHRoYW4gbHo0
LiBUaGUgZGVmYXVsdCB2YWx1ZSB3aWxsIGJlIGx6NCBpZiBsejQKc3VwcG9ydCBpcyBidWls
dCwgb3RoZXJ3aXNlLCBwZ2x6LgotLS0KIGNvbmZpZ3VyZS5hYyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8ICAyICstCiBkb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwgICAg
ICAgICAgICAgICAgICAgICAgfCAgMyArKy0KIGRvYy9zcmMvc2dtbC9pbnN0YWxsYXRpb24u
c2dtbCAgICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysrKwogbWVzb24uYnVpbGQgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDIgKysKIHNyYy9iYWNrZW5kL2Fj
Y2Vzcy9jb21tb24vdG9hc3RfY29tcHJlc3Npb24uYyB8ICAyICstCiBzcmMvYmFja2VuZC91
dGlscy9taXNjL2d1Y19wYXJhbWV0ZXJzLmRhdCAgICAgfCAgMiArLQogc3JjL2Jpbi9pbml0
ZGIvaW5pdGRiLmMgICAgICAgICAgICAgICAgICAgICAgIHwgIDUgKysrKysKIHNyYy9pbmNs
dWRlL2FjY2Vzcy90b2FzdF9jb21wcmVzc2lvbi5oICAgICAgICB8ICA5ICsrKysrKysrKwog
OCBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlm
ZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCBjMjQxMzcyMGEx
OC4uMGE0NTk4ZTUxMWQgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1
cmUuYWMKQEAgLTExMzMsNyArMTEzMyw3IEBAIEFDX1NVQlNUKHdpdGhfemxpYikKICMgTFo0
CiAjCiBBQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIgdG8gYnVpbGQgd2l0aCBMWjQgc3VwcG9y
dF0pCi1QR0FDX0FSR19CT09MKHdpdGgsIGx6NCwgbm8sIFtidWlsZCB3aXRoIExaNCBzdXBw
b3J0XSwKK1BHQUNfQVJHX0JPT0wod2l0aCwgbHo0LCB5ZXMsIFtidWlsZCB3aXRob3V0IExa
NCBzdXBwb3J0XSwKICAgICAgICAgICAgICAgW0FDX0RFRklORShbVVNFX0xaNF0sIDEsIFtE
ZWZpbmUgdG8gMSB0byBidWlsZCB3aXRoIExaNCBzdXBwb3J0LiAoLS13aXRoLWx6NCldKV0p
CiBBQ19NU0dfUkVTVUxUKFskd2l0aF9sejRdKQogQUNfU1VCU1Qod2l0aF9sejQpCmRpZmYg
LS1naXQgYS9kb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwgYi9kb2Mvc3JjL3NnbWwvY29uZmln
LnNnbWwKaW5kZXggNDA1Yzk2ODliZDAuLjczZWIzM2UyZDk5IDEwMDY0NAotLS0gYS9kb2Mv
c3JjL3NnbWwvY29uZmlnLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2NvbmZpZy5zZ21sCkBA
IC05OTEwLDcgKzk5MTAsOCBAQCBDT1BZIHBvc3RncmVzX2xvZyBGUk9NICcvZnVsbC9wYXRo
L3RvL2xvZ2ZpbGUuY3N2JyBXSVRIIGNzdjsKICAgICAgICAgVGhlIHN1cHBvcnRlZCBjb21w
cmVzc2lvbiBtZXRob2RzIGFyZSA8bGl0ZXJhbD5wZ2x6PC9saXRlcmFsPiBhbmQKICAgICAg
ICAgKGlmIDxwcm9kdWN0bmFtZT5Qb3N0Z3JlU1FMPC9wcm9kdWN0bmFtZT4gd2FzIGNvbXBp
bGVkIHdpdGgKICAgICAgICAgPG9wdGlvbj4tLXdpdGgtbHo0PC9vcHRpb24+KSA8bGl0ZXJh
bD5sejQ8L2xpdGVyYWw+LgotICAgICAgICBUaGUgZGVmYXVsdCBpcyA8bGl0ZXJhbD5wZ2x6
PC9saXRlcmFsPi4KKyAgICAgICAgVGhlIGRlZmF1bHQgaXMgPGxpdGVyYWw+bHo0PC9saXRl
cmFsPiAoaWYgYXZhaWxhYmxlKTsgb3RoZXJ3aXNlLAorICAgICAgICA8bGl0ZXJhbD5wZ2x6
PC9saXRlcmFsPi4KICAgICAgICA8L3BhcmE+CiAgICAgICA8L2xpc3RpdGVtPgogICAgICA8
L3Zhcmxpc3RlbnRyeT4KZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9pbnN0YWxsYXRpb24u
c2dtbCBiL2RvYy9zcmMvc2dtbC9pbnN0YWxsYXRpb24uc2dtbAppbmRleCBmZThkNzNlMWY4
Yy4uZjhiNDNhOGNiN2IgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9pbnN0YWxsYXRpb24u
c2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvaW5zdGFsbGF0aW9uLnNnbWwKQEAgLTEzMTUsNiAr
MTMxNSwxOCBAQCBidWlsZC1wb3N0Z3Jlc3FsOgogICAgICAgIDwvbGlzdGl0ZW0+CiAgICAg
ICA8L3Zhcmxpc3RlbnRyeT4KIAorICAgICAgPHZhcmxpc3RlbnRyeSBpZD0iY29uZmlndXJl
LW9wdGlvbi13aXRob3V0LWx6NCI+CisgICAgICAgPHRlcm0+PG9wdGlvbj4tLXdpdGhvdXQt
bHo0PC9vcHRpb24+PC90ZXJtPgorICAgICAgIDxsaXN0aXRlbT4KKyAgICAgICAgPHBhcmE+
CisgICAgICAgICA8aW5kZXh0ZXJtPgorICAgICAgICAgIDxwcmltYXJ5Pmx6NDwvcHJpbWFy
eT4KKyAgICAgICAgIDwvaW5kZXh0ZXJtPgorICAgICAgICAgUHJldmVudHMgdXNlIG9mIHRo
ZSA8YXBwbGljYXRpb24+TFo0PC9hcHBsaWNhdGlvbj4gbGlicmFyeS4KKyAgICAgICAgPC9w
YXJhPgorICAgICAgIDwvbGlzdGl0ZW0+CisgICAgICA8L3Zhcmxpc3RlbnRyeT4KKwogICAg
ICA8L3ZhcmlhYmxlbGlzdD4KIAogICAgPC9zZWN0Mz4KZGlmZiAtLWdpdCBhL21lc29uLmJ1
aWxkIGIvbWVzb24uYnVpbGQKaW5kZXggNmU3ZGRkNzQ2ODMuLjFkYTUzYmYwMTM4IDEwMDY0
NAotLS0gYS9tZXNvbi5idWlsZAorKysgYi9tZXNvbi5idWlsZApAQCAtMTA5Niw2ICsxMDk2
LDggQEAgaWYgbm90IGx6NG9wdC5kaXNhYmxlZCgpCiAgIGlmIGx6NC5mb3VuZCgpCiAgICAg
Y2RhdGEuc2V0KCdVU0VfTFo0JywgMSkKICAgICBjZGF0YS5zZXQoJ0hBVkVfTElCTFo0Jywg
MSkKKyAgZWxzZQorICAgIHdhcm5pbmcoJ2RpZCBub3QgZmluZCBsejQnKQogICBlbmRpZgog
CiBlbHNlCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9hY2Nlc3MvY29tbW9uL3RvYXN0X2Nv
bXByZXNzaW9uLmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvY29tbW9uL3RvYXN0X2NvbXByZXNz
aW9uLmMKaW5kZXggOTI2ZjFlNDAwOGEuLjRiYjI5NjY1ZWFiIDEwMDY0NAotLS0gYS9zcmMv
YmFja2VuZC9hY2Nlc3MvY29tbW9uL3RvYXN0X2NvbXByZXNzaW9uLmMKKysrIGIvc3JjL2Jh
Y2tlbmQvYWNjZXNzL2NvbW1vbi90b2FzdF9jb21wcmVzc2lvbi5jCkBAIC0yMyw3ICsyMyw3
IEBACiAjaW5jbHVkZSAidmFyYXR0LmgiCiAKIC8qIEdVQyAqLwotaW50CQkJZGVmYXVsdF90
b2FzdF9jb21wcmVzc2lvbiA9IFRPQVNUX1BHTFpfQ09NUFJFU1NJT047CitpbnQJCQlkZWZh
dWx0X3RvYXN0X2NvbXByZXNzaW9uID0gREVGQVVMVF9UT0FTVF9DT01QUkVTU0lPTjsKIAog
I2RlZmluZSBOT19DT01QUkVTU0lPTl9TVVBQT1JUKG1ldGhvZCkgXAogCWVyZXBvcnQoRVJS
T1IsIFwKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjX3BhcmFtZXRl
cnMuZGF0IGIvc3JjL2JhY2tlbmQvdXRpbHMvbWlzYy9ndWNfcGFyYW1ldGVycy5kYXQKaW5k
ZXggM2I5ZDgzNDkwNzguLmNiZTliZjA1NWIzIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91
dGlscy9taXNjL2d1Y19wYXJhbWV0ZXJzLmRhdAorKysgYi9zcmMvYmFja2VuZC91dGlscy9t
aXNjL2d1Y19wYXJhbWV0ZXJzLmRhdApAQCAtNzM1LDcgKzczNSw3IEBACiB7IG5hbWUgPT4g
J2RlZmF1bHRfdG9hc3RfY29tcHJlc3Npb24nLCB0eXBlID0+ICdlbnVtJywgY29udGV4dCA9
PiAnUEdDX1VTRVJTRVQnLCBncm91cCA9PiAnQ0xJRU5UX0NPTk5fU1RBVEVNRU5UJywKICAg
c2hvcnRfZGVzYyA9PiAnU2V0cyB0aGUgZGVmYXVsdCBjb21wcmVzc2lvbiBtZXRob2QgZm9y
IGNvbXByZXNzaWJsZSB2YWx1ZXMuJywKICAgdmFyaWFibGUgPT4gJ2RlZmF1bHRfdG9hc3Rf
Y29tcHJlc3Npb24nLAotICBib290X3ZhbCA9PiAnVE9BU1RfUEdMWl9DT01QUkVTU0lPTics
CisgIGJvb3RfdmFsID0+ICdERUZBVUxUX1RPQVNUX0NPTVBSRVNTSU9OJywKICAgb3B0aW9u
cyA9PiAnZGVmYXVsdF90b2FzdF9jb21wcmVzc2lvbl9vcHRpb25zJywKIH0sCiAKZGlmZiAt
LWdpdCBhL3NyYy9iaW4vaW5pdGRiL2luaXRkYi5jIGIvc3JjL2Jpbi9pbml0ZGIvaW5pdGRi
LmMKaW5kZXggOTJmZTJmNTMxZjcuLjkyYjEyMGQ4YWI4IDEwMDY0NAotLS0gYS9zcmMvYmlu
L2luaXRkYi9pbml0ZGIuYworKysgYi9zcmMvYmluL2luaXRkYi9pbml0ZGIuYwpAQCAtMTQy
NCw2ICsxNDI0LDExIEBAIHNldHVwX2NvbmZpZyh2b2lkKQogCQkJCQkJCQkJICAiMDY0MCIs
IGZhbHNlKTsKIAl9CiAKKyNpZiBVU0VfTFo0CisJY29uZmxpbmVzID0gcmVwbGFjZV9ndWNf
dmFsdWUoY29uZmxpbmVzLCAiZGVmYXVsdF90b2FzdF9jb21wcmVzc2lvbiIsCisJCQkJCQkJ
CSAgImx6NCIsIHRydWUpOworI2VuZGlmCisKIAkvKgogCSAqIE5vdyByZXBsYWNlIGFueXRo
aW5nIHRoYXQncyBvdmVycmlkZGVuIHZpYSAtYyBzd2l0Y2hlcy4KIAkgKi8KZGlmZiAtLWdp
dCBhL3NyYy9pbmNsdWRlL2FjY2Vzcy90b2FzdF9jb21wcmVzc2lvbi5oIGIvc3JjL2luY2x1
ZGUvYWNjZXNzL3RvYXN0X2NvbXByZXNzaW9uLmgKaW5kZXggMTNjNDYxMmNlZWQuLjc1MjZl
YTUwYzVhIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9hY2Nlc3MvdG9hc3RfY29tcHJlc3Np
b24uaAorKysgYi9zcmMvaW5jbHVkZS9hY2Nlc3MvdG9hc3RfY29tcHJlc3Npb24uaApAQCAt
NTIsNiArNTIsMTUgQEAgdHlwZWRlZiBlbnVtIFRvYXN0Q29tcHJlc3Npb25JZAogCiAjZGVm
aW5lIENvbXByZXNzaW9uTWV0aG9kSXNWYWxpZChjbSkgICgoY20pICE9IEludmFsaWRDb21w
cmVzc2lvbk1ldGhvZCkKIAorLyoKKyAqIENob29zZSBhbiBhcHByb3ByaWF0ZSBkZWZhdWx0
IHRvYXN0IGNvbXByZXNzaW9uIG1ldGhvZC4gSWYgbHo0IGlzCisgKiBjb21waWxlZC1pbiwg
dXNlIGl0LCBvdGhlcndpc2UsIHVzZSBwZ2x6LgorICovCisjaWZkZWYgVVNFX0xaNAorI2Rl
ZmluZSBERUZBVUxUX1RPQVNUX0NPTVBSRVNTSU9OCVRPQVNUX0xaNF9DT01QUkVTU0lPTgor
I2Vsc2UKKyNkZWZpbmUgREVGQVVMVF9UT0FTVF9DT01QUkVTU0lPTglUT0FTVF9QR0xaX0NP
TVBSRVNTSU9OCisjZW5kaWYKIAogLyogcGdseiBjb21wcmVzc2lvbi9kZWNvbXByZXNzaW9u
IHJvdXRpbmVzICovCiBleHRlcm4gc3RydWN0IHZhcmxlbmEgKnBnbHpfY29tcHJlc3NfZGF0
dW0oY29uc3Qgc3RydWN0IHZhcmxlbmEgKnZhbHVlKTsKLS0gCjIuMzkuNQoK

--0b1f26b1c669412c9334f86c40dfa66c--