Message-ID: <c2bc08dfec336c03f7a7165d1347e2b52cf98b17.camel@j-davis.com>
Subject: Re: Statistics Import and Export
From: Jeff Davis <pgsql@j-davis.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, jian he <jian.universality@gmail.com>,
  Matthias van de Meent <boekewurm+postgres@gmail.com>, Tom Lane
 <tgl@sss.pgh.pa.us>, Nathan Bossart <nathandbossart@gmail.com>,  Magnus
 Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Peter Smith
 <smithpb2250@gmail.com>,  PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>, alvherre@alvh.no-ip.org
Date: Sat, 07 Dec 2024 11:27:51 -0800
In-Reply-To: <CADkLM=fcAneLoFrd41zdxm_1mMZz+wTp5gLJ=Av5JtBi5cBnDQ@mail.gmail.com>
References: 
	<CADkLM=eu72o_=s2ARNe8yB-16AUm+_iU0tq_ALeeUUxCCqJkOQ@mail.gmail.com>
	 <11bb2c7403d4a7421fe8b09df6737aa83976266e.camel@j-davis.com>
	 <CACJufxHrJb3L66kzYWeFvN_7RNROaHKUo_JuXK6B64c+TkWOhA@mail.gmail.com>
	 <CADkLM=edhVxHr5OGZHnUeoMkjFYNpE==puOKbB1E_7j1=QsbBw@mail.gmail.com>
	 <CACJufxGmdV-9c7M_fs-2mGBMj1XiVqdOkW0NvibmpBJqedo1uQ@mail.gmail.com>
	 <CADkLM=eErgzn7ECDpwFcptJKOk9SxZEk5Pot4d94eVTZsvj3gw@mail.gmail.com>
	 <be7de51af6e969d501f69426c7137af6bde17fdc.camel@j-davis.com>
	 <CADkLM=eSnbrOPfof8JeSZriFXnqpYcyRw8-WhL5nesbkduDdUQ@mail.gmail.com>
	 <CADkLM=fR7TwH0cLREQkf5_=KLcOYVxJw0Km0i5MpaWeuDwVo6g@mail.gmail.com>
	 <CADkLM=fBaHichB7oS=LZNfTpGHSOTO44OKR28BwNmwu+9PicOg@mail.gmail.com>
	 <ZzuZzDMxe3ClqAgF@momjian.us>
	 <CADkLM=cxNaU3O40Y5zGARJBWm-uAvb2hvgZxd=tOu-zTsrHpkQ@mail.gmail.com>
	 <5d3a24216d15ce8a50d0fc085a13a410202014ca.camel@j-davis.com>
	 <CADkLM=fcAneLoFrd41zdxm_1mMZz+wTp5gLJ=Av5JtBi5cBnDQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/c2bc08dfec336c03f7a7165d1347e2b52cf98b17.camel%40j-davis.com>
Precedence: bulk

On Tue, 2024-11-26 at 17:11 -0500, Corey Huinker wrote:
>=20
> > * Why does binary upgrade cause statistics to be dumped? Can you
> > just
> > make pg_upgrade specify the appropriate set of flags?
> >=20
>=20
>=20
> That decision goes back a ways, I tried to dig in the archives last
> night but I was getting a Server Error on postgresql.org.

I suggest that pg_upgrade be changed to pass --no-data to pg_dump,
rather than --schema-only.

That way, you don't need to create a special case for the pg_dump
default that depends on whether it's a binary upgrade or not.

If wanted, there could also be a new option to pg_upgrade to specify --
with-statistics (default, passes --no-data to pg_dump) or --no-
statistics (passes --schema-only to pg_dump). But that option is
probably not necessary; everyone upgrading probably wants the stats.

Regards,
	Jeff Davis