Reply-To: jesper.pedersen@redhat.com
Subject: Re: pread() and pwrite()
From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Oskari Saarenmaa <os@ohmu.fi>, Pg Hackers <pgsql-hackers@postgresql.org>,
 Tobias Oberstein <tobias.oberstein@gmail.com>
References: 
 <CAEepm=02rapCpPR3ZGF2vW=SBHSdFYO_bz_f-wwWJonmA3APgw@mail.gmail.com>
 <20180720081459.GC22214@saarenmaa.fi>
 <CAEepm=2qRXWM+uX26dPn6S=TAqi8FfuAZ9vG8tZW9Jo7w6YeQw@mail.gmail.com>
 <7f379440-dfec-70ca-8a0d-942f1381936b@redhat.com>
Organization: Red Hat
Message-ID: <c2f56d0a-cadd-3df1-ae48-b84dc8128c37@redhat.com>
Date: Thu, 6 Sep 2018 10:17:45 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <7f379440-dfec-70ca-8a0d-942f1381936b@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 09/05/2018 02:42 PM, Jesper Pedersen wrote:
> On 07/26/2018 10:04 PM, Thomas Munro wrote:
>> Done.  Rebased.
>>
> 
> This needs a rebase again.
> 

Would it be of benefit to update these call sites

* slru.c
   - SlruPhysicalReadPage
   - SlruPhysicalWritePage
* xlogutils.c
   - XLogRead
* pg_receivewal.c
   - FindStreamingStart
* rewriteheap.c
   - heap_xlog_logical_rewrite
* walreceiver.c
   - XLogWalRcvWrite

too ?

Best regards,
  Jesper