public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Tom Lane <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: astreamer fixes
Date: Sun, 29 Mar 2026 09:16:16 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>


On 2026-03-28 Sa 3:46 PM, Tom Lane wrote:
> Andrew Dunstan<[email protected]> writes:
>> On 2026-03-28 Sa 1:48 PM, Tom Lane wrote:
>>> but I don't like the other bit
>>>
>>> +		/* If we've hit the end of the compressed stream, stop. */
>>> +		if (res == Z_STREAM_END)
>>> +			break;
>>>
>>> Paying attention to the amount of data consumed seems just as
>>> good and takes less code.
>> So IIUC, you agree with the patch except for this last piece, on which I
>> agree with your reasoning.
> Right, I would leave out the above-quoted hunk but the rest of it
> looks good.
>
> 			


Thanks. pushed.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: astreamer fixes
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox