public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Ayush Tiwari <[email protected]>
Cc: [email protected]
Cc: Tom Lane <[email protected]>
Subject: Re: [PATCH] Reject ENCODING option for COPY TO FORMAT JSON
Date: Sat, 30 May 2026 09:20:16 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAJTYsWXy5u_EVHeKPM=_FfJutJ79xGPh4tYUMd4OowO4scmx9A@mail.gmail.com>
References: <CAJTYsWVTarpEyFyx=ivXO88ORcAM35FNwgO35nnNSNGdEhN1aw@mail.gmail.com>
<[email protected]>
<CAJTYsWU24n==-H_agoUguFxZjFV6jCzNamuJzj4ZgiFPUp2bRg@mail.gmail.com>
<CAJTYsWX-jsLzxGRAb-dWnEpGYRPbDYHwce8LctVE92LiDfM2Jw@mail.gmail.com>
<CAJTYsWXtmAAYCymBFLPTgp6TJTOsrsV2KcmzjQWS+7PLi_r_Ng@mail.gmail.com>
<[email protected]>
<CAJTYsWXy5u_EVHeKPM=_FfJutJ79xGPh4tYUMd4OowO4scmx9A@mail.gmail.com>
On 2026-05-04 Mo 10:43 AM, Ayush Tiwari wrote:
> Hi,
>
> On Mon, 4 May 2026 at 19:49, Andrew Dunstan <[email protected]> wrote:
>
> Basically good, I think. I have modified your test a bit, testing
> more directly for the presence of the LATIN-1 encoded character
> and the absence of the UTF-8 encoded character, by reading in the
> file with pg_read_binary_file, and adding a test for implicit
> encoding by setting client_encoding.
>
>
> The revised tests look better to me. Checking the raw bytes with
> pg_read_binary_file() directly verifies that LATIN1 output does not
> contain
> the UTF-8 sequence, and the added implicit client_encoding case too
> looks good.
>
> Thanks for improving the test coverage.
>
>
pushed.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
view thread (11+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Reject ENCODING option for COPY TO FORMAT JSON
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox