MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_da70811290c281b0e5b3e713166f8e61"
Content-Transfer-Encoding: 7bit
Date: Thu, 27 Jun 2024 19:27:33 +0900
From: ikedarintarof <ikedarintarof@oss.nttdata.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: pgsql-hackers@postgresql.org
Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
In-Reply-To: 
 <CAGECzQQ+bpYVuF6GpVdc9vzHOObs5HJLmj5YohOb2d-ctmCffg@mail.gmail.com>
References: <6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com>
 <CAGECzQRjJkCQ9AUQA_7kJw8c4iUwVAXPfD_VQu+-DVcd-LCT8A@mail.gmail.com>
 <9c15a4b74d09348d03b02934fc429c94@oss.nttdata.com>
 <CAGECzQQ+bpYVuF6GpVdc9vzHOObs5HJLmj5YohOb2d-ctmCffg@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <c380192faada009af9aa5bfcd06e140d@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/c380192faada009af9aa5bfcd06e140d%40oss.nttdata.com>
Precedence: bulk

--=_da70811290c281b0e5b3e713166f8e61
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

Thanks for your suggestion. I used ChatGPT to choose the wording, but 
it's still difficult for me.

The new patch includes your suggestion.

On 2024-06-27 17:18, Jelte Fennema-Nio wrote:
> On Thu, 27 Jun 2024 at 09:09, ikedarintarof
> <ikedarintarof@oss.nttdata.com> wrote:
>> 
>> Thank you for your comment!
>> 
>> I've added the must_use_password argument. A new patch is attached.
> 
> s/whther/whether
> 
> nit: "it will do nothing" sounds a bit strange to me (but I'm not
> native english). Something like this reads more natural to me:
> 
> an error. If must_use_password is true, the function raises an error
> if no password is provided in the connection string. In any other case
> it successfully completes.

--=_da70811290c281b0e5b3e713166f8e61
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch
Content-Disposition: attachment;
 filename=0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch;
 size=1257

RnJvbSBjMDFjYWRjYjk1NWQ3OWZmNTI1OTkyOTg1YmQ1OTczNmM2NzMxYWJlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSaW50YXJvIElrZWRhIDw1MTM5NDc2NityaW5pa2VkYUB1c2Vy
cy5ub3JlcGx5LmdpdGh1Yi5jb20+CkRhdGU6IFRodSwgMjcgSnVuIDIwMjQgMTY6MDQ6MDggKzA5
MDAKU3ViamVjdDogW1BBVENIXSBtb2RpZnkgdGhlIGNvbW1uZXQgaW4gbGlicHFyY3ZfY2hlY2tf
Y29ubmluZm8oKQoKLS0tCiBzcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9saWJwcXdhbHJlY2VpdmVy
L2xpYnBxd2FscmVjZWl2ZXIuYyB8IDUgKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlv
bnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvcmVwbGljYXRp
b24vbGlicHF3YWxyZWNlaXZlci9saWJwcXdhbHJlY2VpdmVyLmMgYi9zcmMvYmFja2VuZC9yZXBs
aWNhdGlvbi9saWJwcXdhbHJlY2VpdmVyL2xpYnBxd2FscmVjZWl2ZXIuYwppbmRleCAwMmYxMmYy
OTIxLi40ZjdiNjlhNzNkIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9saWJw
cXdhbHJlY2VpdmVyL2xpYnBxd2FscmVjZWl2ZXIuYworKysgYi9zcmMvYmFja2VuZC9yZXBsaWNh
dGlvbi9saWJwcXdhbHJlY2VpdmVyL2xpYnBxd2FscmVjZWl2ZXIuYwpAQCAtMzA5LDggKzMwOSw5
IEBAIGJhZF9jb25uZWN0aW9uOgogICogbG9jYWwgZmlsZXN5c3RlbSBhY2Nlc3MgdG8gYmUgYXR0
ZW1wdGVkLgogICoKICAqIElmIHRoZSBjb25uZWN0aW9uIHN0cmluZyBjYW4ndCBiZSBwYXJzZWQs
IHRoaXMgZnVuY3Rpb24gd2lsbCByYWlzZQotICogYW4gZXJyb3IgYW5kIHdpbGwgbm90IHJldHVy
bi4gSWYgaXQgY2FuLCBpdCB3aWxsIHJldHVybiB0cnVlIGlmIHRoaXMKLSAqIGNvbm5lY3Rpb24g
c3RyaW5nIHNwZWNpZmllcyBhIHBhc3N3b3JkIGFuZCBmYWxzZSBvdGhlcndpc2UuCisgKiBhbiBl
cnJvci4gSWYgbXVzdF91c2VfcGFzc3dvcmQgaXMgdHJ1ZSwgdGhlIGZ1bmN0aW9uIHJhaXNlcyBh
biBlcnJvcgorICogaWYgbm8gcGFzc3dvcmQgaXMgcHJvdmlkZWQgaW4gdGhlIGNvbm5lY3Rpb24g
c3RyaW5nLiBJbiBhbnkgb3RoZXIgY2FzZQorICogaXQgc3VjY2Vzc2Z1bGx5IGNvbXBsZXRlcy4K
ICAqLwogc3RhdGljIHZvaWQKIGxpYnBxcmN2X2NoZWNrX2Nvbm5pbmZvKGNvbnN0IGNoYXIgKmNv
bm5pbmZvLCBib29sIG11c3RfdXNlX3Bhc3N3b3JkKQotLSAKMi4zOS4zIChBcHBsZSBHaXQtMTQ2
KQoK
--=_da70811290c281b0e5b3e713166f8e61--