Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSS5G-00DqpS-Ca for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Jan 2024 01:29:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rSS5E-000onR-9t for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Jan 2024 01:29:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSS5D-000onJ-EJ for pgsql-hackers@lists.postgresql.org; Wed, 24 Jan 2024 01:29:39 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSS56-0033FR-BG for pgsql-hackers@lists.postgresql.org; Wed, 24 Jan 2024 01:29:38 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7C70D5C015E; Tue, 23 Jan 2024 20:29:31 -0500 (EST) Received: from imap49 ([10.202.2.99]) by compute2.internal (MEProxy); Tue, 23 Jan 2024 20:29:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1706059771; x=1706146171; bh=OngQwtJmam LfAIj7kOvLC1vcWisgAyvfwUE9xhbwFL4=; b=IkMdrIRD/5NHaLfs468qR8NVrj fUfxuIDGx4aREs5qkHM1POH/n34yK0Ct7F6DfEgj0ecq4xJLzQnT4mQonCucJ5b+ dr9jWtkiCX9vplqmfpzL6FmqU15vNEMEl1fq1EjIDC7M+DZi5WPLcEzxSbdLzWeN oJkbj+xqP1OksmsNZx3ujQL/GpFLwGG1w01KpH3b8otmhC5IHxtF2n89vKaYiXn+ iZXo55qx4vW/87AQzS7ZfDmnFa6kUvAsS+lTWmHzp73hlUihbEC8jdKuofAezOpr BRfu2nhGGGGhg9JrmJAVVnZpSoNQQGnOGjy+WQp0MNcxbhaeBvU4hzaUFLNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1706059771; x=1706146171; bh=OngQwtJmamLfAIj7kOvLC1vcWisg AyvfwUE9xhbwFL4=; b=ywIP//qzR9IB/pKJ89gSOR+6LekCO3UyzyCD09sGbPPZ O2gfosQDOhjtj7PoRzWmBpWHUGHZ9MbexqEfLQ7lpyIxnuE8GG/Qy6BBVoFn82Bq rz58ad30YvjU8cARrQmilVL3bfKzzCNFry3qVNcWtI7fSdNIbAZr7KguKwMDrp8A w3I4tzpKguTc+aGPhwhzhjN/tNz3v6dS9Y7V3itQccZPSIjizfF4kNxX6CsXXw5B kRwcMe5ykIHTB0LXJZ+0laWDfkL/uLSDLjubjaveUtdOws/PACGEsjDplDa+ROtH HwyJrzoUCsF2bD1yO23g1R29agOVrFF2EoEZG6eRDw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeltddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsegrtderreerredtnecuhfhrohhmpedfgfhu lhgvrhcuvfgrvhgvihhrrgdfuceovghulhgvrhesvghulhgvrhhtohdrtghomheqnecugg ftrfgrthhtvghrnhepgfffjedviedvkedviedvteduieekudeivedthffhuddvteegleet ieffkeeghfdvnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegvuhhlvghrsegv uhhlvghrthhordgtohhm X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0442115A0092; Tue, 23 Jan 2024 20:29:30 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-119-ga8b98d1bd8-fm-20240108.001-ga8b98d1b MIME-Version: 1.0 Message-Id: In-Reply-To: References: <5ac50071-f2ed-4ace-a8fd-b892cffd33eb@www.fastmail.com> <4710d895-689a-4ae6-b8e3-344286dbf970@app.fastmail.com> <96e3b739-d63d-4d35-90a3-7869465b7167@eisentraut.org> <2736443c-58e3-42df-8cc4-8c66106e3da5@app.fastmail.com> Date: Tue, 23 Jan 2024 22:29:09 -0300 From: "Euler Taveira" To: "Shlok Kyal" , "kuroda.hayato@fujitsu.com" Cc: "pgsql-hackers@lists.postgresql.org" , "vignesh C" , "Michael Paquier" , "Peter Eisentraut" , "Andres Freund" , "Ashutosh Bapat" , "Amit Kapila" Subject: Re: speed up a logical replica setup Content-Type: multipart/alternative; boundary=cc1211280c8541319e4fb4bdca81ba7e List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --cc1211280c8541319e4fb4bdca81ba7e Content-Type: text/plain On Mon, Jan 22, 2024, at 6:30 AM, Shlok Kyal wrote: > We fixed some of the comments posted in the thread. We have created it > as top-up patch 0002 and 0003. Cool. > 0002 patch contains the following changes: > * Add a timeout option for the recovery option, per [1]. The code was > basically ported from pg_ctl.c. > * Reject if the target server is not a standby, per [2] > * Raise FATAL error if --subscriber-conninfo specifies non-local server, per [3] > (not sure it is really needed, so feel free reject the part.) > * Add check for max_replication_slots and wal_level; as per [4] > * Add -u and -p options; as per [5] > * Addressed comment except 5 and 8 in [6] and comment in [7] My suggestion is that you create separate patches for each change. It helps with review and alternative proposals. Some of these items conflict with what I have in my local branch and removing one of them is time consuming. For this one, I did the job but let's avoid rework. > 0003 patch contains fix for bug reported in [8]. LGTM. As I said in the other email, I included it. I'll post a new one soon. -- Euler Taveira EDB https://www.enterprisedb.com/ --cc1211280c8541319e4fb4bdca81ba7e Content-Type: text/html Content-Transfer-Encoding: quoted-printable
On Mon, Jan 22,= 2024, at 6:30 AM, Shlok Kyal wrote:
We fixed some of the comments posted in the th= read. We have created it
as top-up patch 0002 and 0003.

Cool.

0002 patch contains the fo= llowing changes:
* Add a timeout option for the recovery o= ption, per [1]. The code was
basically ported from pg_ctl.= c.
* Reject if the target server is not a standby, per [2]=
* Raise FATAL error if --subscriber-conninfo specifies no= n-local server, per [3]
  (not sure it is really need= ed, so feel free reject the part.)
* Add check for max_rep= lication_slots and wal_level; as per [4]
* Add -u and -p o= ptions; as per [5]
* Addressed comment except 5 and 8 in [= 6] and comment in [7]

My sugge= stion is that you create separate patches for each change. It helps
<= /div>
with review and alternative proposals. Some of these items con= flict with what I
have in my local branch and removing one= of them is time consuming. For this
one, I did the job bu= t let's avoid rework.

0003 patch contains fix for bug reported in [8= ].

LGTM. As I said in the othe= r email, I included it.

I'll post a new one= soon.


<= div class=3D"signature">--
Euler Tavei= ra
EDB   https://www.enterprisedb.com/
=

--cc1211280c8541319e4fb4bdca81ba7e--