Message-ID: <c43ef413-f65b-46a5-b8a1-28949daaa889@tantorlabs.com>
Date: Mon, 15 Sep 2025 23:46:04 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Vacuum statistics
To: Alena Rybakina <a.rybakina@postgrespro.ru>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Alexander Korotkov <aekorotkov@gmail.com>,
 Amit Kapila <amit.kapila16@gmail.com>, Jim Nasby <jnasby@upgrade.com>,
 Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 Kirill Reshke <reshkekirill@gmail.com>, Andrei Zubkov <zubkov@moonset.ru>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 Melanie Plageman <melanieplageman@gmail.com>,
 jian he <jian.universality@gmail.com>, a.lepikhov@postgrespro.ru,
 Sami Imseih <samimseih@gmail.com>, vignesh C <vignesh21@gmail.com>
References: <86f76aa5-1ab5-4e2e-9b15-405051852a2a@postgrespro.ru>
 <fb8f05ad-096a-4865-9beb-08d4460222bb@postgrespro.ru>
 <333c2306-c401-4959-9f0c-a44c670a11a9@postgrespro.ru>
 <513f0188-b093-4cc8-98cf-4c324570d525@postgrespro.ru>
 <47a7b784-5218-43f2-96e3-65f9a729c5a5@tantorlabs.com>
 <d78a21c5-68ae-45b8-82a8-60f391b89d43@postgrespro.ru>
 <CAMFBP2oXkhX_k9FTqtW-LdTBepVq0PDuBEGO8-LpNGbyHTBrNw@mail.gmail.com>
 <Z9J+cRHwpBt4cQv3@ip-10-97-1-34.eu-west-3.compute.internal>
 <e66086a1-641a-4758-b3fc-5e92c74c9239@postgrespro.ru>
 <5583261b-eede-4341-b3b1-91650fefc1cf@postgrespro.ru>
 <2a04ad18-5572-4633-848b-eb57209e7ac0@postgrespro.ru>
 <CAA4eK1JOUn+EqWSfRgKfgBZOXT7Q2dw2enmSZZgOhoMOFwopPA@mail.gmail.com>
 <2f48399f-2959-4483-938f-64edb863ca76@postgrespro.ru>
 <CAPpHfdtQd29O15Cmp1qeqTCerQF0Y+BGh63qtX3RkA7k=0TZ1Q@mail.gmail.com>
 <18169b68-5b10-40fd-9657-be04f2bd0161@postgrespro.ru>
 <cb205605-d24c-41a3-9205-fe59e13af9ed@postgrespro.ru>
 <f5097647-89f9-4288-9010-9f690778dd53@postgrespro.ru>
Content-Language: en-US
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
In-Reply-To: <f5097647-89f9-4288-9010-9f690778dd53@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/c43ef413-f65b-46a5-b8a1-28949daaa889%40tantorlabs.com>
Precedence: bulk

Hi Alena,

Thanks for the work you=E2=80=99ve done.

On 01.09.2025 22:13, Alena Rybakina wrote:
> I've rebased the patches to the current HEAD.


Right now there is a bug: when I run a simple

SELECT * FROM pg_stat_vacuum_database;

psql crashes.

The root cause is an incorrect zeroing of a local variable:
PgStat_VacuumDBCounts allzero;
- memset(&allzero, 0, sizeof(PgStat_VacuumRelationCounts));
+ memset(&allzero, 0, sizeof(PgStat_VacuumDBCounts));

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC,
https://tantorlabs.com