Feedback-ID: ie0a040ee:Fastmail
Content-Type: multipart/mixed; boundary="------------Dc97Sw0Tbk93cHiLyBc9Udst"
Message-ID: <c44f28a7-542c-4044-b8b2-d578bd4e9926@eisentraut.org>
Date: Thu, 28 Nov 2024 10:35:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Virtual generated columns
From: Peter Eisentraut <peter@eisentraut.org>
To: jian he <jian.universality@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 Dean Rasheed <dean.a.rasheed@gmail.com>
References: <a368248e-69e4-40be-9c07-6c3b5880b0a6@eisentraut.org>
 <fd6d260b-a401-4355-8688-e3bcb7e93527@eisentraut.org>
 <CACJufxGh=XX7q5xTci---HikSJsOwP7_qCNyyDHdp2YL4NLZCg@mail.gmail.com>
 <CACJufxHxoz_KVQxcQ=cSvJc+PNbh=FaHbcMZCOisoOaGAgjy4w@mail.gmail.com>
 <732a9543-0312-4f0c-a471-857b507a3546@eisentraut.org>
 <ebd1e0e9-115f-4dfa-98b8-e9b8e2f9eb2d@eisentraut.org>
 <CAEZATCV=RX0M58-uqSR6tFjwQAFnEcx3hvW-9ZZfRQJLg5LzRw@mail.gmail.com>
 <0f811f71-8c86-4e1b-b3bb-6a535674a440@eisentraut.org>
 <CAEZATCU3q=znAL7X1aSxuMpjfSyB1cT5j398HPb9ix9ci_HUqA@mail.gmail.com>
 <cd7c0fea-6c4b-4bdd-af3b-4d4dabb32ca1@eisentraut.org>
 <CAEZATCVLfMzNwT1J0bnvtv6YbmNSN9QSXb+1QSGyX6vK4q67Ow@mail.gmail.com>
 <ef7c466d-e3b9-4d60-bc03-cd9b48581442@eisentraut.org>
 <09800cb1-43aa-4239-8918-46b71ede4900@eisentraut.org>
 <536b281b-2cb3-4477-971f-c64838bc6263@eisentraut.org>
 <CACJufxF8fmM=Dbm4pDFuV_nKGz2-No0k4YifhrF3-rjXTWJM3w@mail.gmail.com>
 <41f64e3c-db80-43b2-9a21-7ecc515f889f@eisentraut.org>
Content-Language: en-US
In-Reply-To: <41f64e3c-db80-43b2-9a21-7ecc515f889f@eisentraut.org>
Archived-At: <https://www.postgresql.org/message-id/c44f28a7-542c-4044-b8b2-d578bd4e9926%40eisentraut.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------Dc97Sw0Tbk93cHiLyBc9Udst
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 12.11.24 17:08, Peter Eisentraut wrote:
> On 11.11.24 12:37, jian he wrote:
>> On Wed, Nov 6, 2024 at 12:17 AM Peter Eisentraut 
>> <peter@eisentraut.org> wrote:
>>>
>>> New patch version.  I've gone through the whole thread again and looked
>>> at all the feedback and various bug reports and test cases and made sure
>>> they are all addressed in the latest patch version.  (I'll send some
>>> separate messages to respond to some individual messages, but I'm
>>> keeping the latest patch here.)
>>
>> just quickly note the not good error message before you rebase.
>>
>> src7=# create domain d_fail as int4 constraint cc GENERATED ALWAYS AS 
>> (2) ;
>> ERROR:  unrecognized constraint subtype: 4
>> src7=# create domain d_fail as int4 constraint cc GENERATED ALWAYS AS
>> (2) stored;
>> ERROR:  unrecognized constraint subtype: 4
>> src7=# create domain d_fail as int4 constraint cc GENERATED ALWAYS AS
>> (2) virtual;
>> ERROR:  unrecognized constraint subtype: 4
>>
>> reading gram.y, typedef struct Constraint seems cannot distinguish, we
>> are creating a domain or create table.
>> I cannot found a way to error out in gram.y.
>>
>> so we have to error out at DefineDomain.
> 
> This appears to be a very old problem independent of this patch.  I'll 
> take a look at fixing it.

Here is a patch.

I'm on the fence about taking out the default case.  It does catch the 
missing enum values, and I suppose if the struct arrives in 
DefineDomain() with a corrupted contype value that is none of the enum 
values, then we'd just do nothing with it.  Maybe go ahead with this, 
but for backpatching leave the default case in place?


--------------Dc97Sw0Tbk93cHiLyBc9Udst
Content-Type: text/plain; charset=UTF-8;
 name="0001-Fix-handling-of-CREATE-DOMAIN-with-GENERATED-constra.patch"
Content-Disposition: attachment;
 filename*0="0001-Fix-handling-of-CREATE-DOMAIN-with-GENERATED-constra.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSAwOWY5NDg0ZjBkMjk5MGI0YjliZThkMmE4YjkwN2MxMzRkNmQ1ZWU3IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogVGh1LCAyOCBOb3YgMjAyNCAxMDoyMzoyNiArMDEwMApTdWJqZWN0
OiBbUEFUQ0hdIEZpeCBoYW5kbGluZyBvZiBDUkVBVEUgRE9NQUlOIHdpdGggR0VORVJBVEVE
IGNvbnN0cmFpbnQKIHN5bnRheAoKU3R1ZmYgbGlrZQoKICAgIENSRUFURSBET01BSU4gZm9v
IEFTIGludCBDT05TVFJBSU5UIGNjIEdFTkVSQVRFRCBBTFdBWVMgQVMgKDIpIFNUT1JFRAoK
aXMgbm90IHN1cHBvcnRlZCBmb3IgZG9tYWlucywgYnV0IHRoZSBwYXJzZXIgYWxsb3dzIGl0
LCBiZWNhdXNlIGl0J3MKdGhlIHNhbWUgc3ludGF4IGFzIGZvciB0YWJsZSBjb25zdHJhaW50
cy4gIEJ1dCBDcmVhdGVEb21haW4oKSBkaWQgbm90CmV4cGxpY2l0bHkgaGFuZGxlIGFsbCBD
b25zdHJUeXBlIHZhbHVlcywgc28gdGhlIGFib3ZlIHdvdWxkIGdldCBhbgppbnRlcm5hbCBl
cnJvciBsaWtlCgogICAgRVJST1I6ICB1bnJlY29nbml6ZWQgY29uc3RyYWludCBzdWJ0eXBl
OiA0CgpGaXggdGhhdCBieSBwcm92aWRpbmcgYSB1c2VyLWZhY2luZyBlcnJvciBtZXNzYWdl
IGZvciBhbGwgQ29uc3RyVHlwZQp2YWx1ZXMuICBBbHNvLCByZW1vdmUgdGhlIHN3aXRjaCBk
ZWZhdWx0IGNhc2UsIHNvIGZ1dHVyZSBhZGRpdGlvbnMgdG8KQ29uc3RyVHlwZSBhcmUgY2F1
Z2h0LgoKUmVwb3J0ZWQtYnk6IEppYW4gSGUgPGppYW4udW5pdmVyc2FsaXR5QGdtYWlsLmNv
bT4KRGlzY3Vzc2lvbjogaHR0cHM6Ly93d3cucG9zdGdyZXNxbC5vcmcvbWVzc2FnZS1pZC9D
QUNKdWZ4RjhmbU09RGJtNHBERnVWX25LR3oyLU5vMGs0WWlmaHJGMy1yalhUV0pNM3dAbWFp
bC5nbWFpbC5jb20KLS0tCiBzcmMvYmFja2VuZC9jb21tYW5kcy90eXBlY21kcy5jIHwgMTAg
KysrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlv
bnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jb21tYW5kcy90eXBlY21kcy5jIGIv
c3JjL2JhY2tlbmQvY29tbWFuZHMvdHlwZWNtZHMuYwppbmRleCA4NTllMjE5MWYwOC4uMTMw
NzQxZTc3N2UgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3R5cGVjbWRzLmMK
KysrIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvdHlwZWNtZHMuYwpAQCAtMTAxMSwxMCArMTAx
MSwxNCBAQCBEZWZpbmVEb21haW4oQ3JlYXRlRG9tYWluU3RtdCAqc3RtdCkKIAkJCQkJCSBl
cnJtc2coInNwZWNpZnlpbmcgY29uc3RyYWludCBkZWZlcnJhYmlsaXR5IG5vdCBzdXBwb3J0
ZWQgZm9yIGRvbWFpbnMiKSkpOwogCQkJCWJyZWFrOwogCi0JCQlkZWZhdWx0OgotCQkJCWVs
b2coRVJST1IsICJ1bnJlY29nbml6ZWQgY29uc3RyYWludCBzdWJ0eXBlOiAlZCIsCi0JCQkJ
CSAoaW50KSBjb25zdHItPmNvbnR5cGUpOworCQkJY2FzZSBDT05TVFJfR0VORVJBVEVEOgor
CQkJY2FzZSBDT05TVFJfSURFTlRJVFk6CisJCQkJZXJlcG9ydChFUlJPUiwKKwkJCQkJCShl
cnJjb2RlKEVSUkNPREVfRkVBVFVSRV9OT1RfU1VQUE9SVEVEKSwKKwkJCQkJCSBlcnJtc2co
InNwZWNpZnlpbmcgR0VORVJBVEVEIG5vdCBzdXBwb3J0ZWQgZm9yIGRvbWFpbnMiKSkpOwog
CQkJCWJyZWFrOworCisJCQkJLyogbm8gZGVmYXVsdCwgdG8gbGV0IGNvbXBpbGVyIHdhcm4g
YWJvdXQgbWlzc2luZyBjYXNlICovCiAJCX0KIAl9CiAKLS0gCjIuNDcuMAoK

--------------Dc97Sw0Tbk93cHiLyBc9Udst--