Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0mXv-0002n5-7q for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Dec 2022 16:36:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p0mXu-00065o-4W for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Dec 2022 16:36:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0mXt-00065e-Ma for pgsql-hackers@lists.postgresql.org; Thu, 01 Dec 2022 16:36:21 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p0mXo-0005Gq-26 for pgsql-hackers@postgresql.org; Thu, 01 Dec 2022 16:36:20 +0000 Received: from mail.postgrespro.ru (cyclops.postgrespro.ru [93.174.131.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 1777F21C4B88; Thu, 1 Dec 2022 19:36:13 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1669912573; bh=duqnHcElxQBVONy488A2IugdaNak2bsMXPZqzYHYCF4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=bAFH1SGaXSg+nwYedisgWP0nkm9YN6t5tWqaR9VF8zbEBZl4mQy0C0O8/FKLupAh9 aWwPIBgEvMmGlRr3AYY7hCM43mKBzQE/Q1ZQCpP0h9/67Fey5pQT2Wv7euyAtx4cCD R3p7aw/0s3+2JyFcKxZopZyX7mvBwpEeVPet4xhE= MIME-Version: 1.0 Date: Thu, 01 Dec 2022 19:36:12 +0300 From: Alexander Pyhalov To: "Fujii.Yuki@df.MitsubishiElectric.co.jp" Cc: Tomas Vondra , PostgreSQL-development , Andres Freund , Julien Rouhaud , Daniel Gustafsson , Ilya Gladyshev Subject: Re: Partial aggregates pushdown In-Reply-To: References: <05d98f67a4f44b31d90dfb977db4ad71@postgrespro.ru> <317f8de58ce9889e056f2944e200a44d@postgrespro.ru> <2ed9ad03bc17cfb86da900d541a270b0@postgrespro.ru> <20220114121653.mjzqelwgnzwqhkoa@jrouhaud> <0cc653ad90dbfc5ca0fd8bb1ca57e1a7@postgrespro.ru> <2ad047732a8b8a9aaaad06fef59fb283@postgrespro.ru> <925e2d3f11283d8b2707fc5d827fc3e9@postgrespro.ru> <20220322004914.opkwl3beedl4uhks@alap3.anarazel.de> <57db913f-02c6-66af-2928-513e2b1c65f7@enterprisedb.com> <8dc86e502fbd9d04da0dc6cdd4156f84@postgrespro.ru> <313df801f860f653ebb8c6422794a5b5@postgrespro.ru> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: a.pyhalov@postgrespro.ru Content-Type: multipart/mixed; boundary="=_d8d83689d62c91f907beb6c247f94ff9" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_d8d83689d62c91f907beb6c247f94ff9 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed Fujii.Yuki@df.MitsubishiElectric.co.jp писал 2022-12-01 05:23: > Hi Mr.Pyhalov. > Hi. Attaching minor fixes. I haven't proof-read all comments (but perhaps, they need attention from some native speaker). Tested it with queries from https://github.com/swarm64/s64da-benchmark-toolkit, works as expected. -- Best regards, Alexander Pyhalov, Postgres Professional --=_d8d83689d62c91f907beb6c247f94ff9 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; charset=us-ascii; name=1.patch Content-Disposition: attachment; filename=1.patch; size=1114 ZGlmZiAtLWdpdCBhL2NvbnRyaWIvcG9zdGdyZXNfZmR3L2RlcGFyc2UuYyBiL2NvbnRyaWIvcG9z dGdyZXNfZmR3L2RlcGFyc2UuYwppbmRleCAzNWYyZDEwMjM3NC4uYmQ4YTRhY2MxMTIgMTAwNjQ0 Ci0tLSBhL2NvbnRyaWIvcG9zdGdyZXNfZmR3L2RlcGFyc2UuYworKysgYi9jb250cmliL3Bvc3Rn cmVzX2Zkdy9kZXBhcnNlLmMKQEAgLTM0NzIsOSArMzQ3Miw5IEBAIGRlcGFyc2VBZ2dyZWYoQWdn cmVmICpub2RlLCBkZXBhcnNlX2V4cHJfY3h0ICpjb250ZXh0KQogCQlpZiAoKGFnZ2Zvcm0tPmFn Z3RyYW5zdHlwZSAhPSBJTlRFUk5BTE9JRCkgJiYgKGFnZ2Zvcm0tPmFnZ2ZpbmFsZm4gPT0gSW52 YWxpZE9pZCkpIHsKIAkJCWFwcGVuZEZ1bmN0aW9uTmFtZShub2RlLT5hZ2dmbm9pZCwgY29udGV4 dCk7CiAJCX0gZWxzZSBpZihhZ2dmb3JtLT5wYXJ0aWFsYWdnZm4pIHsKLQkJCWFwcGVuZEZ1bmN0 aW9uTmFtZSgoT2lkKShhZ2dmb3JtLT5wYXJ0aWFsYWdnZm4pLCBjb250ZXh0KTsKKwkJCWFwcGVu ZEZ1bmN0aW9uTmFtZShhZ2dmb3JtLT5wYXJ0aWFsYWdnZm4sIGNvbnRleHQpOwogCQl9IGVsc2Ug ewotCQkJZWxvZyhFUlJPUiwgInRoZXJlIGluIG5vIHBhcnRpYWxhZ2dmbiAldSIsIG5vZGUtPmFn Z2Zub2lkKTsKKwkJCWVsb2coRVJST1IsICJ0aGVyZSBpcyBubyBwYXJ0aWFsYWdnZm4gJXUiLCBu b2RlLT5hZ2dmbm9pZCk7CiAJCX0KIAkJUmVsZWFzZVN5c0NhY2hlKGFnZ3R1cCk7CiAJfQpAQCAt Mzk4Niw3ICszOTg2LDggQEAgZ2V0X3JlbGF0aW9uX2NvbHVtbl9hbGlhc19pZHMoVmFyICpub2Rl LCBSZWxPcHRJbmZvICpmb3JlaWducmVsLAogfQogCiAvKgotICogQ2hlY2sgdGhhdCBwYXJ0aWFs IGFnZ3JlZ2F0ZSBmdW5jdGlvbiBvZiBhZ2dmb3JtIGV4c2l0cyBpbiByZW1vdGUKKyAqIENoZWNr IHRoYXQgcGFydGlhbCBhZ2dyZWdhdGUgZnVuY3Rpb24sIGRlc2NyaWJlZCBieSBhZ2dmb3JtLAor ICogZXhpc3RzIG9uIHJlbW90ZSBzZXJ2ZXIsIGRlc2NyaWJlZCBieSBmcGluZm8uCiAgKi8KIHN0 YXRpYyBib29sCiBwYXJ0aWFsX2FnZ19jb21wYXRpYmxlKEZvcm1fcGdfYWdncmVnYXRlIGFnZ2Zv cm0sIFBnRmR3UmVsYXRpb25JbmZvICpmcGluZm8pCg== --=_d8d83689d62c91f907beb6c247f94ff9--