To: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Subject: TAP tests and symlinks on Windows
Organization: 2ndQuadrant
Message-ID: <c50a646c-d9bb-7c62-a4bf-8256ff6ff338@2ndquadrant.com>
Date: Mon, 8 Jun 2020 14:44:31 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------C75023C1DF3A9960E6D043DC"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------C75023C1DF3A9960E6D043DC
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

The tests

src/bin/pg_basebackup/t/010_pg_basebackup.pl
src/bin/pg_rewind/t/004_pg_xlog_symlink.pl

both contain a TAP skip notice "symlinks not supported on Windows".

This is untrue.  Symlinks certainly work on Windows, and we have other 
TAP tests using them, for example for tablespaces.

pg_rewind/t/004_pg_xlog_symlink.pl passes for me on Windows if I just 
remove the skip stuff.  My attached patch does that.

If I remove the skip stuff in pg_basebackup/t/010_pg_basebackup.pl, it 
fails in various interesting ways.  Apparently, some more work is needed 
to get the various paths handled correct on Windows.  (At least a 
TestLib::perl2host call appears to be required.)  I don't have the 
enthusiasm to fix this right now, but my patch at least updates the 
comment from "this isn't supported" to "this doesn't work correctly yet".

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--------------C75023C1DF3A9960E6D043DC
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="0001-Enable-some-symlink-tests-on-Windows.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="0001-Enable-some-symlink-tests-on-Windows.patch"

RnJvbSA4MjI1ODNhMDFkYzRmMTZkNzMzOTBlMjY2NzM1ZDc1OGUxNTA3NjM2IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogU2F0LCA2IEp1biAyMDIwIDA5OjM4OjU0ICswMjAwClN1YmplY3Q6
IFtQQVRDSCAxLzJdIEVuYWJsZSBzb21lIHN5bWxpbmsgdGVzdHMgb24gV2luZG93cwoKLS0t
CiBzcmMvYmluL3BnX2Jhc2ViYWNrdXAvdC8wMTBfcGdfYmFzZWJhY2t1cC5wbCB8ICA2ICsr
Ky0tLQogc3JjL2Jpbi9wZ19yZXdpbmQvdC8wMDRfcGdfeGxvZ19zeW1saW5rLnBsICAgfCAx
MSArLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDEzIGRl
bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfYmFzZWJhY2t1cC90LzAxMF9w
Z19iYXNlYmFja3VwLnBsIGIvc3JjL2Jpbi9wZ19iYXNlYmFja3VwL3QvMDEwX3BnX2Jhc2Vi
YWNrdXAucGwKaW5kZXggMjA4ZGY1NTdiOC4uYTEwZDIwMTM3OCAxMDA2NDQKLS0tIGEvc3Jj
L2Jpbi9wZ19iYXNlYmFja3VwL3QvMDEwX3BnX2Jhc2ViYWNrdXAucGwKKysrIGIvc3JjL2Jp
bi9wZ19iYXNlYmFja3VwL3QvMDEwX3BnX2Jhc2ViYWNrdXAucGwKQEAgLTIxMSwxMSArMjEx
LDExIEBACiAJJ3BnX2Jhc2ViYWNrdXAgdGFyIHdpdGggbG9uZyBuYW1lIGZhaWxzJyk7CiB1
bmxpbmsgIiRwZ2RhdGEvJHN1cGVybG9uZ25hbWUiOwogCi0jIFRoZSBmb2xsb3dpbmcgdGVz
dHMgdGVzdCBzeW1saW5rcy4gV2luZG93cyBkb2Vzbid0IGhhdmUgc3ltbGlua3MsIHNvCi0j
IHNraXAgb24gV2luZG93cy4KKyMgVGhlIGZvbGxvd2luZyB0ZXN0cyBuZWVkIHNvbWUgd29y
ayB0byB3b3JrIGNvcnJlY3RseSBvbiBXaW5kb3dzLCBzbworIyBza2lwIGZvciBub3cuCiBT
S0lQOgogewotCXNraXAgInN5bWxpbmtzIG5vdCBzdXBwb3J0ZWQgb24gV2luZG93cyIsIDE4
IGlmICgkd2luZG93c19vcyk7CisJc2tpcCAic3ltbGluayB0ZXN0cyBub3Qgc3VwcG9ydGVk
IG9uIFdpbmRvd3MiLCAxOCBpZiAoJHdpbmRvd3Nfb3MpOwogCiAJIyBNb3ZlIHBnX3JlcGxz
bG90IG91dCBvZiAkcGdkYXRhIGFuZCBjcmVhdGUgYSBzeW1saW5rIHRvIGl0LgogCSRub2Rl
LT5zdG9wOwpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wZ19yZXdpbmQvdC8wMDRfcGdfeGxvZ19z
eW1saW5rLnBsIGIvc3JjL2Jpbi9wZ19yZXdpbmQvdC8wMDRfcGdfeGxvZ19zeW1saW5rLnBs
CmluZGV4IDYzOWVlYjljOTEuLmUyNzFhNGFiMTYgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdf
cmV3aW5kL3QvMDA0X3BnX3hsb2dfc3ltbGluay5wbAorKysgYi9zcmMvYmluL3BnX3Jld2lu
ZC90LzAwNF9wZ194bG9nX3N5bWxpbmsucGwKQEAgLTYsMTYgKzYsNyBAQAogdXNlIEZpbGU6
OkNvcHk7CiB1c2UgRmlsZTo6UGF0aCBxdyhybXRyZWUpOwogdXNlIFRlc3RMaWI7Ci11c2Ug
VGVzdDo6TW9yZTsKLWlmICgkd2luZG93c19vcykKLXsKLQlwbGFuIHNraXBfYWxsID0+ICdz
eW1saW5rcyBub3Qgc3VwcG9ydGVkIG9uIFdpbmRvd3MnOwotCWV4aXQ7Ci19Ci1lbHNlCi17
Ci0JcGxhbiB0ZXN0cyA9PiA1OwotfQordXNlIFRlc3Q6Ok1vcmUgdGVzdHMgPT4gNTsKIAog
dXNlIEZpbmRCaW47CiB1c2UgbGliICRGaW5kQmluOjpSZWFsQmluOwotLSAKMi4yNy4wCgo=
--------------C75023C1DF3A9960E6D043DC--