Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzHQ5-0004sg-JT for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Dec 2021 12:05:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mzHQ4-0000Zz-Fb for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Dec 2021 12:05:32 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzHQ4-0000Zq-1u for pgsql-hackers@lists.postgresql.org; Mon, 20 Dec 2021 12:05:32 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzHPz-00028V-Vw for pgsql-hackers@postgresql.org; Mon, 20 Dec 2021 12:05:31 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id E322E6083D; Mon, 20 Dec 2021 21:05:23 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.4 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_83cbbed96b725b3039eedf4e083ce2dc" Content-Transfer-Encoding: 7bit Date: Mon, 20 Dec 2021 21:05:23 +0900 From: Shinya Kato To: Peter Eisentraut , Fujii Masao Cc: Bharath Rupireddy , Daniel Gustafsson , PostgreSQL-development Subject: Re: Emit a warning if the extension's GUC is set incorrectly In-Reply-To: <83b33009-3a1b-9230-8f07-2115763c1853@enterprisedb.com> References: <524fa2c0a34f34b68fbfa90d0760d515@oss.nttdata.com> <681A95E0-0CCA-4C66-A12B-CE0D8D5076D7@yesql.se> <25643eaa81a69416317e85c2fd7d4c0a@oss.nttdata.com> <98d354d3b099d8e24c6b653336bd29d7@oss.nttdata.com> <4a2c5e69b98bf8ffbef2fad2f1850c97@oss.nttdata.com> <9956b3b9-9cc3-49d2-f9e8-7f3ed3c63994@oss.nttdata.com> <9f5e96ca44891915f1d2736bea9fdf45@oss.nttdata.com> <83b33009-3a1b-9230-8f07-2115763c1853@enterprisedb.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: Shinya11.Kato@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_83cbbed96b725b3039eedf4e083ce2dc Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2021-12-17 15:42, Peter Eisentraut wrote: > On 17.12.21 03:25, Shinya Kato wrote: >> For now, I'v attached the patch that fixed the compilation error. > > I think it would be good if you could split the uncontroversial new > EmitErrorsOnPlaceholders() calls into a separate patch. And please > add an explanation what exactly the rest of the patch changes. Thank you for the comment! I splitted the patch. - v6-01-Add-EmitWarningsOnPlaceholders.patch We should use EmitWarningsOnPlaceholders when we use DefineCustomXXXVariable. I don't think there is any room for debate. - v6-0002-Change-error-level-of-EmitWarningsOnPlaceholders.patch This is a patch to change the error level of EmitWarningsOnPlaceholders from WARNING to ERROR. I think it's OK to emit ERROR as well as when the wrong GUC is set for non-extensions, or since it does not behave abnormally, it can be left as WARNING. Thought? - v6-0003-Emit-error-when-invalid-extensions-GUCs-are-set.patch This is a patch to emit error when invalid extension's GUCs are set. No test changes have been made, so the regression test will fail. I have created a patch, but I don't think this is necessary because of the previous discussion. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --=_83cbbed96b725b3039eedf4e083ce2dc Content-Transfer-Encoding: base64 Content-Type: text/x-diff; charset=us-ascii; name=v6-0001-Add-EmitWarningsOnPlaceholders.patch Content-Disposition: attachment; filename=v6-0001-Add-EmitWarningsOnPlaceholders.patch; size=3198 ZGlmZiAtLWdpdCBhL2NvbnRyaWIvYXV0aF9kZWxheS9hdXRoX2RlbGF5LmMgYi9jb250cmliL2F1 dGhfZGVsYXkvYXV0aF9kZWxheS5jCmluZGV4IDU4MjBhYzMyOGQuLmQxMWRkMWU0MTYgMTAwNjQ0 Ci0tLSBhL2NvbnRyaWIvYXV0aF9kZWxheS9hdXRoX2RlbGF5LmMKKysrIGIvY29udHJpYi9hdXRo X2RlbGF5L2F1dGhfZGVsYXkuYwpAQCAtNjcsNiArNjcsOSBAQCBfUEdfaW5pdCh2b2lkKQogCQkJ CQkJCU5VTEwsCiAJCQkJCQkJTlVMTCwKIAkJCQkJCQlOVUxMKTsKKworCUVtaXRXYXJuaW5nc09u UGxhY2Vob2xkZXJzKCJhdXRoX2RlbGF5Iik7CisKIAkvKiBJbnN0YWxsIEhvb2tzICovCiAJb3Jp Z2luYWxfY2xpZW50X2F1dGhfaG9vayA9IENsaWVudEF1dGhlbnRpY2F0aW9uX2hvb2s7CiAJQ2xp ZW50QXV0aGVudGljYXRpb25faG9vayA9IGF1dGhfZGVsYXlfY2hlY2tzOwpkaWZmIC0tZ2l0IGEv Y29udHJpYi9wZ190cmdtL3RyZ21fb3AuYyBiL2NvbnRyaWIvcGdfdHJnbS90cmdtX29wLmMKaW5k ZXggZmIzODEzNWY3YS4uMDQwN2M3ZGQ2NCAxMDA2NDQKLS0tIGEvY29udHJpYi9wZ190cmdtL3Ry Z21fb3AuYworKysgYi9jb250cmliL3BnX3RyZ20vdHJnbV9vcC5jCkBAIC0xMDAsNiArMTAwLDgg QEAgX1BHX2luaXQodm9pZCkKIAkJCQkJCQkgTlVMTCwKIAkJCQkJCQkgTlVMTCwKIAkJCQkJCQkg TlVMTCk7CisKKwlFbWl0V2FybmluZ3NPblBsYWNlaG9sZGVycygicGdfdHJnbSIpOwogfQogCiAv KgpkaWZmIC0tZ2l0IGEvY29udHJpYi9wb3N0Z3Jlc19mZHcvb3B0aW9uLmMgYi9jb250cmliL3Bv c3RncmVzX2Zkdy9vcHRpb24uYwppbmRleCA0OGM3NDE3ZTZlLi4zNjU1NTM5OGVjIDEwMDY0NAot LS0gYS9jb250cmliL3Bvc3RncmVzX2Zkdy9vcHRpb24uYworKysgYi9jb250cmliL3Bvc3RncmVz X2Zkdy9vcHRpb24uYwpAQCAtNDY5LDQgKzQ2OSw2IEBAIF9QR19pbml0KHZvaWQpCiAJCQkJCQkJ ICAgTlVMTCwKIAkJCQkJCQkgICBOVUxMLAogCQkJCQkJCSAgIE5VTEwpOworCisJRW1pdFdhcm5p bmdzT25QbGFjZWhvbGRlcnMoInBvc3RncmVzX2ZkdyIpOwogfQpkaWZmIC0tZ2l0IGEvY29udHJp Yi9zZXBnc3FsL2hvb2tzLmMgYi9jb250cmliL3NlcGdzcWwvaG9va3MuYwppbmRleCAxOWEzZmZi N2ZmLi40NGEwOWMzNWE3IDEwMDY0NAotLS0gYS9jb250cmliL3NlcGdzcWwvaG9va3MuYworKysg Yi9jb250cmliL3NlcGdzcWwvaG9va3MuYwpAQCAtNDU1LDYgKzQ1NSw4IEBAIF9QR19pbml0KHZv aWQpCiAJCQkJCQkJIE5VTEwsCiAJCQkJCQkJIE5VTEwpOwogCisJRW1pdFdhcm5pbmdzT25QbGFj ZWhvbGRlcnMoInNlcGdzcWwiKTsKKwogCS8qIEluaXRpYWxpemUgdXNlcnNwYWNlIGFjY2VzcyB2 ZWN0b3IgY2FjaGUgKi8KIAlzZXBnc3FsX2F2Y19pbml0KCk7CiAKZGlmZiAtLWdpdCBhL3NyYy9w bC90Y2wvcGx0Y2wuYyBiL3NyYy9wbC90Y2wvcGx0Y2wuYwppbmRleCBlMTE4Mzc1NTlkLi4xMzg5 YWEwOTQzIDEwMDY0NAotLS0gYS9zcmMvcGwvdGNsL3BsdGNsLmMKKysrIGIvc3JjL3BsL3RjbC9w bHRjbC5jCkBAIC00NzQsNiArNDc0LDggQEAgX1BHX2luaXQodm9pZCkKIAkJCQkJCQkgICBQR0Nf U1VTRVQsIDAsCiAJCQkJCQkJICAgTlVMTCwgTlVMTCwgTlVMTCk7CiAKKwlFbWl0V2FybmluZ3NP blBsYWNlaG9sZGVycygicGx0Y2x1Iik7CisKIAlwbHRjbF9wbV9pbml0X2RvbmUgPSB0cnVlOwog fQogCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9tb2R1bGVzL2RlbGF5X2V4ZWN1dGlvbi9kZWxheV9l eGVjdXRpb24uYyBiL3NyYy90ZXN0L21vZHVsZXMvZGVsYXlfZXhlY3V0aW9uL2RlbGF5X2V4ZWN1 dGlvbi5jCmluZGV4IGIzZDA4NDFiYTguLjhlYzYyM2FjNTIgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0 L21vZHVsZXMvZGVsYXlfZXhlY3V0aW9uL2RlbGF5X2V4ZWN1dGlvbi5jCisrKyBiL3NyYy90ZXN0 L21vZHVsZXMvZGVsYXlfZXhlY3V0aW9uL2RlbGF5X2V4ZWN1dGlvbi5jCkBAIC05MSw2ICs5MSw4 IEBAIF9QR19pbml0KHZvaWQpCiAJCQkJCQkJTlVMTCwKIAkJCQkJCQlOVUxMKTsKIAorCUVtaXRX YXJuaW5nc09uUGxhY2Vob2xkZXJzKCJkZWxheV9leGVjdXRpb24iKTsKKwogCS8qIEluc3RhbGwg b3VyIGhvb2sgKi8KIAlwcmV2X3BsYW5uZXJfaG9vayA9IHBsYW5uZXJfaG9vazsKIAlwbGFubmVy X2hvb2sgPSBkZWxheV9leGVjdXRpb25fcGxhbm5lcjsKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L21v ZHVsZXMvc3NsX3Bhc3NwaHJhc2VfY2FsbGJhY2svc3NsX3Bhc3NwaHJhc2VfZnVuYy5jIGIvc3Jj L3Rlc3QvbW9kdWxlcy9zc2xfcGFzc3BocmFzZV9jYWxsYmFjay9zc2xfcGFzc3BocmFzZV9mdW5j LmMKaW5kZXggNmIwYTNkYjEwNC4uM2JhMzNlNTAxYyAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvbW9k dWxlcy9zc2xfcGFzc3BocmFzZV9jYWxsYmFjay9zc2xfcGFzc3BocmFzZV9mdW5jLmMKKysrIGIv c3JjL3Rlc3QvbW9kdWxlcy9zc2xfcGFzc3BocmFzZV9jYWxsYmFjay9zc2xfcGFzc3BocmFzZV9m dW5jLmMKQEAgLTQ4LDYgKzQ4LDkgQEAgX1BHX2luaXQodm9pZCkKIAkJCQkJCQkgICBOVUxMLAog CQkJCQkJCSAgIE5VTEwsCiAJCQkJCQkJICAgTlVMTCk7CisKKwlFbWl0V2FybmluZ3NPblBsYWNl aG9sZGVycygic3NsX3Bhc3NwaHJhc2UiKTsKKwogCWlmIChzc2xfcGFzc3BocmFzZSkKIAkJb3Bl bnNzbF90bHNfaW5pdF9ob29rID0gc2V0X3JvdDEzOwogfQpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3Qv bW9kdWxlcy93b3JrZXJfc3BpL3dvcmtlcl9zcGkuYyBiL3NyYy90ZXN0L21vZHVsZXMvd29ya2Vy X3NwaS93b3JrZXJfc3BpLmMKaW5kZXggMGI2MjQ2Njc2Yi4uYWRiMDJkOGNiOCAxMDA2NDQKLS0t IGEvc3JjL3Rlc3QvbW9kdWxlcy93b3JrZXJfc3BpL3dvcmtlcl9zcGkuYworKysgYi9zcmMvdGVz dC9tb2R1bGVzL3dvcmtlcl9zcGkvd29ya2VyX3NwaS5jCkBAIC0zMjIsNiArMzIyLDggQEAgX1BH X2luaXQodm9pZCkKIAkJCQkJCQkgICAwLAogCQkJCQkJCSAgIE5VTEwsIE5VTEwsIE5VTEwpOwog CisJRW1pdFdhcm5pbmdzT25QbGFjZWhvbGRlcnMoIndvcmtlcl9zcGkiKTsKKwogCS8qIHNldCB1 cCBjb21tb24gZGF0YSBmb3IgYWxsIG91ciB3b3JrZXJzICovCiAJbWVtc2V0KCZ3b3JrZXIsIDAs IHNpemVvZih3b3JrZXIpKTsKIAl3b3JrZXIuYmd3X2ZsYWdzID0gQkdXT1JLRVJfU0hNRU1fQUND RVNTIHwK --=_83cbbed96b725b3039eedf4e083ce2dc Content-Transfer-Encoding: base64 Content-Type: text/x-diff; charset=us-ascii; name=v6-0002-Change-error-level-of-EmitWarningsOnPlaceholders.patch Content-Disposition: attachment; filename=v6-0002-Change-error-level-of-EmitWarningsOnPlaceholders.patch; size=935 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjLmMgYi9zcmMvYmFja2VuZC91 dGlscy9taXNjL2d1Yy5jCmluZGV4IDdiMDMwNDYzMDEuLjVlOTQwN2MzNGEgMTAwNjQ0Ci0tLSBh L3NyYy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjLmMKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvbWlz Yy9ndWMuYwpAQCAtOTMzMyw2ICs5MzMzLDEzIEBAIERlZmluZUN1c3RvbUVudW1WYXJpYWJsZShj b25zdCBjaGFyICpuYW1lLAogCWRlZmluZV9jdXN0b21fdmFyaWFibGUoJnZhci0+Z2VuKTsKIH0K IAorLyoKKyAqIEZvciBoaXN0b3JpY2FsIGNvbnRleHQsIHRoaXMgZnVuY3Rpb24gbmFtZSBpcyBF bWl0V2FybmluZ3NPblBsYWNlaG9sZGVycywKKyAqIGJ1dCBpdCBlbWl0cyBhbiBlcnJvciB3aGVu IGFuIGludmFsaWQgY3VzdG9tIEdVQyBpcyBzZXQuCisgKgorICogSWYgd2UgdXNlIERlZmluZUN1 c3RvbVhYWFZhcmlhYmxlLCBpdCBpcyByZWNvbW1lbmRlZCB0aGF0IHRoaXMgZnVuY3Rpb24gaXMK KyAqIGFkZGVkLgorICovCiB2b2lkCiBFbWl0V2FybmluZ3NPblBsYWNlaG9sZGVycyhjb25zdCBj aGFyICpjbGFzc05hbWUpCiB7CkBAIC05MzQ4LDcgKzkzNTUsNyBAQCBFbWl0V2FybmluZ3NPblBs YWNlaG9sZGVycyhjb25zdCBjaGFyICpjbGFzc05hbWUpCiAJCQlzdHJuY21wKGNsYXNzTmFtZSwg dmFyLT5uYW1lLCBjbGFzc0xlbikgPT0gMCAmJgogCQkJdmFyLT5uYW1lW2NsYXNzTGVuXSA9PSBH VUNfUVVBTElGSUVSX1NFUEFSQVRPUikKIAkJewotCQkJZXJlcG9ydChXQVJOSU5HLAorCQkJZXJl cG9ydChFUlJPUiwKIAkJCQkJKGVycmNvZGUoRVJSQ09ERV9VTkRFRklORURfT0JKRUNUKSwKIAkJ CQkJIGVycm1zZygidW5yZWNvZ25pemVkIGNvbmZpZ3VyYXRpb24gcGFyYW1ldGVyIFwiJXNcIiIs CiAJCQkJCQkJdmFyLT5uYW1lKSkpOwo= --=_83cbbed96b725b3039eedf4e083ce2dc Content-Transfer-Encoding: base64 Content-Type: text/x-diff; charset=us-ascii; name=v6-0003-Emit-error-when-invalid-extensions-GUCs-are-set.patch Content-Disposition: attachment; filename=v6-0003-Emit-error-when-invalid-extensions-GUCs-are-set.patch; size=812 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjLmMgYi9zcmMvYmFja2VuZC91 dGlscy9taXNjL2d1Yy5jCmluZGV4IDdiMDMwNDYzMDEuLmRlYjQxYjIwMTEgMTAwNjQ0Ci0tLSBh L3NyYy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjLmMKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvbWlz Yy9ndWMuYwpAQCAtNTQzOSwxMSArNTQzOSwxOSBAQCB2YWxpZF9jdXN0b21fdmFyaWFibGVfbmFt ZShjb25zdCBjaGFyICpuYW1lKQogewogCWJvb2wJCXNhd19zZXAgPSBmYWxzZTsKIAlib29sCQlu YW1lX3N0YXJ0ID0gdHJ1ZTsKKwlpbnQgCQlwbGFjZWhvbGRlcl9sZW5ndGggPSAwOwogCiAJZm9y IChjb25zdCBjaGFyICpwID0gbmFtZTsgKnA7IHArKykKIAl7CisJCXBsYWNlaG9sZGVyX2xlbmd0 aCsrOwogCQlpZiAoKnAgPT0gR1VDX1FVQUxJRklFUl9TRVBBUkFUT1IpCiAJCXsKKwkJCS8qIENo ZWNrIGludmFsaWQgcGxhY2Vob2xkZXIgYW5kIGN1c3RvbSBwYXJhbWV0ZXIqLworCQkJY2hhciAq cGxhY2Vob2xkZXIgPSBtYWxsb2Moc2l6ZW9mKGNoYXIpICogKHBsYWNlaG9sZGVyX2xlbmd0aCAt IDEpKTsKKwkJCXN0cm5jcHkocGxhY2Vob2xkZXIsIG5hbWUsIHBsYWNlaG9sZGVyX2xlbmd0aCAt IDEpOworCQkJcGxhY2Vob2xkZXJbcGxhY2Vob2xkZXJfbGVuZ3RoIC0xXSA9ICdcMCc7CisJCQlF bWl0V2FybmluZ3NPblBsYWNlaG9sZGVycyhwbGFjZWhvbGRlcik7CisKIAkJCWlmIChuYW1lX3N0 YXJ0KQogCQkJCXJldHVybiBmYWxzZTsJLyogZW1wdHkgbmFtZSBjb21wb25lbnQgKi8KIAkJCXNh d19zZXAgPSB0cnVlOwo= --=_83cbbed96b725b3039eedf4e083ce2dc--