Subject: Re: WIP: Faster Expression Processing v4
To: pgsql-hackers@postgresql.org
References: <20161206034955.bh33paeralxbtluv@alap3.anarazel.de>
 <20170209003312.rr7atqepgbrf4xqe@alap3.anarazel.de>
 <20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de>
 <2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com>
 <20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de>
From: Konstantin Knizhnik <k.knizhnik@postgrespro.ru>
Message-ID: <c5a92c98-08e2-2e19-0d39-bc6ea3008e70@postgrespro.ru>
Date: Mon, 13 Mar 2017 20:10:48 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de>
Content-Type: multipart/alternative;
 boundary="------------4712D3609F400DC50D8264EC"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

This is a multi-part message in MIME format.
--------------4712D3609F400DC50D8264EC
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit


On 13.03.2017 11:03, Andres Freund wrote:
> Hi,
>
> On 2017-03-12 05:40:51 +0100, Tomas Vondra wrote:
>> I wanted to do a bit of testing and benchmarking on this, but 0004 seems to
>> be a bit broken.
> Well, "broken" in the sense that it's already outdated, because other
> stuff that got merged.
>
>
>> The patch does not apply anymore - there are some conflicts
>> in execQual.c, but I think I fixed those. But then I ran into a bunch of
>> compile-time errors, because some of the executor nodes still reference bits
>> that were moved elsewhere.
> Updated patch attached.  Note that this patch has two changes I've not
> yet evaluated performance-wise.


I got the following results at my system with Intel(R) Core(TM) i7-4770 
CPU @ 3.40GHz, 16Gb RAM,
TPC-H Q1/Q6 scale 10, sharedBuffers=8Gb, pg_prewarm on lineitem table 
projection:


	Q1
	Q6
Master
	7503 ms 	1171 ms
Your patch 	6420 ms 	1034 ms
VOPS
	396 ms
	249 ms
VOPS + patch 	367 ms
	233 ms


-- 
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


--------------4712D3609F400DC50D8264EC
Content-Type: text/html; charset=windows-1252
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    <br>
    <div class="moz-cite-prefix">On 13.03.2017 11:03, Andres Freund
      wrote:<br>
    </div>
    <blockquote
      cite="mid:20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de"
      type="cite">
      <pre wrap="">Hi,

On 2017-03-12 05:40:51 +0100, Tomas Vondra wrote:
</pre>
      <blockquote type="cite">
        <pre wrap="">I wanted to do a bit of testing and benchmarking on this, but 0004 seems to
be a bit broken.
</pre>
      </blockquote>
      <pre wrap="">
Well, "broken" in the sense that it's already outdated, because other
stuff that got merged.


</pre>
      <blockquote type="cite">
        <pre wrap="">The patch does not apply anymore - there are some conflicts
in execQual.c, but I think I fixed those. But then I ran into a bunch of
compile-time errors, because some of the executor nodes still reference bits
that were moved elsewhere.
</pre>
      </blockquote>
      <pre wrap="">
Updated patch attached.  Note that this patch has two changes I've not
yet evaluated performance-wise.
</pre>
    </blockquote>
    <br>
    <br>
    I got the following results at my system with Intel(R) Core(TM)
    i7-4770 CPU @ 3.40GHz, 16Gb RAM, <br>
    TPC-H Q1/Q6 scale 10, sharedBuffers=8Gb, pg_prewarm on lineitem
    table projection:<br>
    <br>
    <table border="1" cellpadding="2" cellspacing="2" height="139"
      width="421">
      <tbody>
        <tr>
          <td valign="top"><br>
          </td>
          <td valign="top">Q1<br>
          </td>
          <td valign="top">Q6<br>
          </td>
        </tr>
        <tr>
          <td valign="top">Master<br>
          </td>
          <td valign="top">7503 ms </td>
          <td valign="top">1171 ms</td>
        </tr>
        <tr>
          <td valign="top">Your patch</td>
          <td valign="top">6420 ms</td>
          <td valign="top">1034 ms</td>
        </tr>
        <tr>
          <td valign="top">VOPS<br>
          </td>
          <td valign="top">396 ms<br>
          </td>
          <td valign="top">249 ms</td>
        </tr>
        <tr>
          <td valign="top">VOPS + patch</td>
          <td valign="top">367 ms<br>
          </td>
          <td valign="top">233 ms</td>
        </tr>
      </tbody>
    </table>
    <br>
    <br>
    <pre class="moz-signature" cols="72">-- 
Konstantin Knizhnik
Postgres Professional: <a class="moz-txt-link-freetext" href="http://www.postgrespro.com">http://www.postgrespro.com</a>
The Russian Postgres Company </pre>
  </body>
</html>

--------------4712D3609F400DC50D8264EC--