public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alena Rybakina <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Sami Imseih <[email protected]>
Cc: Robert Treat <[email protected]>
Cc: Frédéric Yhuel <[email protected]>
Cc: wenhui qiu <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Imseih (AWS), Sami <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Joe Conway <[email protected]>
Cc: Michael Banck <[email protected]>
Cc: Laurenz Albe <[email protected]>
Cc: Melanie Plageman <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: New GUC autovacuum_max_threshold ?
Date: Tue, 14 Jan 2025 23:35:17 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <Z4XHQR6_AVKiyFjG@nathan>
References: <Zy-G7u43r1siVkQ6@nathan>
<[email protected]>
<CAGjGUAKSvvQA583hk-62HyBRhPvowNbhv5+QiRt+znWMA+5OLg@mail.gmail.com>
<Z32xZZwOi5pXZjYU@nathan>
<[email protected]>
<Z37ZlVqUzSapV3ZD@nathan>
<CABV9wwNxNTEgq0n5DJVDD+mgMbqBJv1-W6R3Dfry4a9C9=z=Uw@mail.gmail.com>
<Z4AQJYdOsvVHNIbt@nathan>
<Z4V1sDjqJ1CnqScY@nathan>
<CAA5RZ0tAqjtJz+2=S1LvDUJfrpGa73nmLccwvr_R1r8CC4HmaA@mail.gmail.com>
<Z4XHQR6_AVKiyFjG@nathan>
Hi! Thanks for your work! it is very useful.
On 14.01.2025 05:09, Nathan Bossart wrote:
> On Mon, Jan 13, 2025 at 05:17:11PM -0600, Sami Imseih wrote:
>> I propose renaming the GUC from "autovacuum_max_threshold" to
>> "autovacuum_vacuum_max_threshold" to clarify that it applies only
>> to the vacuum operation performed by autovacuum, not to the analyze operation.
>> This will also align with naming for other related GUCs, i.e.,
>> "autovacuum_analyze_threshold" and "autovacuum_vacuum_threshold."
>>
>> The "vacuum threshold" calculation described in [1] will also need to be
>> updated.
> Good call. Here is an updated patch.
>
I found one minor mistake in postgresql.conf:
#autovacuum_vacuum_max_threshold = 100000000 # max number of row updates
# before vacuum; -1 disables max
# threshold
I think instead of "# threshold" should be "#vacuum"?
There is a typo:
* if (threshold > vac_max_thresh)
* threshold = vac_max_thres; - here
I think you should add more information to the description of the
Relations_needs_vacanalyze function: what is vac_max_thresh and how is
it calculated. It is not clear what the below condition means.
/* -1 is used to disable max threshold */
vac_max_thresh= (relopts&& relopts->vacuum_max_threshold>= -1)
? relopts->vacuum_max_threshold
: autovacuum_vac_max_thresh;
--
Regards,
Alena Rybakina
Postgres Professional
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: New GUC autovacuum_max_threshold ?
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox