Content-Type: multipart/alternative;
 boundary="------------FbX0CnbFlTLuZPD9M1g2tTKC"
Message-ID: <c5ffe163-4758-4562-b3f6-6bfb00e58f49@dunslane.net>
Date: Fri, 27 Mar 2026 15:08:22 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] pgindent truncates last line of files missing a trailing
 newline
To: Tom Lane <tgl@sss.pgh.pa.us>, Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: 
 <CANxoLDfca8O5SkeDxB_j6SVNXd+pNKaDmVmEW+2yyicdU8fy0w@mail.gmail.com>
 <3bd49b59-7a87-4ab6-9eac-59b5d9cb78de@dunslane.net>
 <1133418.1771260634@sss.pgh.pa.us>
 <CAExHW5uSuG9qcGd=o6o6TiwWUKE4ie7K7nmgKzDzUKxrQ9rYDw@mail.gmail.com>
 <CANxoLDdbhQbap5vd3=01ad67EGbGNKDsvZdYVT3KRUiy-onYqA@mail.gmail.com>
 <1005500.1774542586@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX
 gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd
 BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS
 h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc
 wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE
 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr
 VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T
 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV
 cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr
 GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN
 hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ
 +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq
 QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd
 EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/
 qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL
 vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p
 bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i
 QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm
 VRu7cmw=
In-Reply-To: <1005500.1774542586@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/c5ffe163-4758-4562-b3f6-6bfb00e58f49%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------FbX0CnbFlTLuZPD9M1g2tTKC
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2026-03-26 Th 12:29 PM, Tom Lane wrote:
> Akshay Joshi<akshay.joshi@enterprisedb.com> writes:
>> I have addressed the review comments from Andrew.
>> Attached is the v2 patch, ready for review.
> I'm not sure I want to expend the brain cells to figure out whether
> this is a correct/complete patch.  If pg_bsd_indent were less of an
> undercommented spaghetti-code nightmare, maybe fixing it here would
> be reasonable.  But as things stand, why don't we just fix this in
> the perl wrapper, as attached?


Well, I thought we were trying to reduce the fixups we did in pgindent. 
However, I take your point about the ugly nature of the pg_bsd_indent 
code. So I'm ok with this fix, which is quite straightforward.


>
> (In any case, I'm not in favor of adding a test case, because that
> would require putting a trailing-newline-less .c file into our tree.
> At best there would be a permanent hazard of something "fixing"
> the file.)
>
> 			


fair point.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------FbX0CnbFlTLuZPD9M1g2tTKC
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2026-03-26 Th 12:29 PM, Tom Lane
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:1005500.1774542586@sss.pgh.pa.us">
      <pre wrap="" class="moz-quote-pre">Akshay Joshi <a class="moz-txt-link-rfc2396E" href="mailto:akshay.joshi@enterprisedb.com">&lt;akshay.joshi@enterprisedb.com&gt;</a> writes:
</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">I have addressed the review comments from Andrew.
Attached is the v2 patch, ready for review.
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
I'm not sure I want to expend the brain cells to figure out whether
this is a correct/complete patch.  If pg_bsd_indent were less of an
undercommented spaghetti-code nightmare, maybe fixing it here would
be reasonable.  But as things stand, why don't we just fix this in
the perl wrapper, as attached?</pre>
    </blockquote>
    <p><br>
    </p>
    <p>Well, I thought we were trying to reduce the fixups we did in
      pgindent. However, I take your point about the ugly nature of the
      pg_bsd_indent code. So I'm ok with this fix, which is quite
      straightforward.<br>
    </p>
    <p><br>
    </p>
    <blockquote type="cite" cite="mid:1005500.1774542586@sss.pgh.pa.us">
      <pre wrap="" class="moz-quote-pre">

(In any case, I'm not in favor of adding a test case, because that
would require putting a trailing-newline-less .c file into our tree.
At best there would be a permanent hazard of something "fixing"
the file.)

			</pre>
    </blockquote>
    <p><br>
    </p>
    <p>fair point.</p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<span style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------FbX0CnbFlTLuZPD9M1g2tTKC--