Date: Mon, 6 Jul 2026 14:10:48 +0200
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Ilmar Yunusov <tanswis42@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: File locks for data directory lockfile in the context of Linux
 namespaces
Message-ID: <c5jj2zvhnh36xfvqkcogrvk5fkcut3un5q5hibozfm62h6t4kp@sdlorh7uaf2s>
References: <z2u3jtjzhqofqhrjvfgkwl4cczhpqibz3t47gpx7fbe7ceaihk@i5mveu2wfpxn>
 <xhzl7ll7fwmlecg4htsgvr3fcwcec4cvugqebphofvcz4srkkn@vpwa2zgswuwy>
 <178332300475.2568959.4097339122938147476.pgcf@coridan.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="tks2nr37zts5e6h7"
Content-Disposition: inline
In-Reply-To: 
 <178332300475.2568959.4097339122938147476.pgcf@coridan.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/c5jj2zvhnh36xfvqkcogrvk5fkcut3un5q5hibozfm62h6t4kp%40sdlorh7uaf2s>
Precedence: bulk


--tks2nr37zts5e6h7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> On Mon, Jul 06, 2026 at 07:30:04AM +0000, Ilmar Yunusov wrote:
>
> There is still a build blocker, matching the current CFBot failures. v3 adds a
> typedef named LockFile in src/backend/utils/init/miscinit.c, but that name
> conflicts with the Windows LockFile() function. The CompilerWarnings log
> reports, for example:

Thanks for looking into the build failure. I wanted to check it out what
was happening on Windows, but after the migration from Cirrus to Github
one have to be logged in to see the build logs, and at that moment I
found myself logged off.

Regarding the name, I'm afraid LockFileData has a chance of causing some
confusion due to a common pattern, where structures are named with
"Data" suffix and a pointer type definition without. Since it's about a
name clash with an external library, I suggest PGLockFile instead, but
open for better suggestions.

--tks2nr37zts5e6h7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="v4-0001-Use-open-file-description-locks-for-lockfiles.patch"