Feedback-ID: ie0a040ee:Fastmail
Message-ID: <c6245804-0dfd-4f31-98ab-cd29bb78f5bf@eisentraut.org>
Date: Fri, 28 Mar 2025 15:06:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: support virtual generated column not null constraint
To: jian he <jian.universality@gmail.com>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>
Cc: Xuneng Zhou <xunengzhou@gmail.com>, Navneet Kumar <thanit3111@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: 
 <CACJufxEoYA5ScUr2=CmA1xcpaS_1ixneDbEkVU77X1ctGxY2mA@mail.gmail.com>
 <202503211018.lsboinfrjn7w@alvherre.pgsql>
 <CACJufxEUg7KFv2qXW-wKH1NcSx5GkROXbjML254KtjxvOiwB+g@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CACJufxEUg7KFv2qXW-wKH1NcSx5GkROXbjML254KtjxvOiwB+g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/c6245804-0dfd-4f31-98ab-cd29bb78f5bf%40eisentraut.org>
Precedence: bulk

On 24.03.25 04:26, jian he wrote:
> rebase, and some minor code comments change.

I have committed this.

I did a bit more editing on the naming of various things.  In terms of 
functionality, in ExecConstraints() notnull_virtual_attrs and 
virtual_notnull_check were redundant, so I simplified that.  I also cut 
back a little bit on the assertions.  They were all ok, but I felt in 
some places they bloated the code quite a bit for no real gain.