Message-ID: <c69a6198a05f3e9d74d8240483cbc6dbbaacb86c.camel@cybertec.at>
Subject: Re: Set log_lock_waits=on by default
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: Michael Banck <mbanck@gmx.net>, Tom Lane <tgl@sss.pgh.pa.us>, Nathan
 Bossart <nathandbossart@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: Sun, 07 Sep 2025 23:46:32 +0200
In-Reply-To: 
 <CAOzEurS0jbDrjmVFgE4QQ_O0bnDtJMaaFsy3=pX0RLYXBcjVpg@mail.gmail.com>
References: <b8b8502915e50f44deb111bc0b43a99e2733e117.camel@cybertec.at>
	 <659ffa38.170a0220.eea6a.28fc@mx.google.com>
	 <65b146b9.170a0220.c645b.0891@mx.google.com>
	 <20240206165343.GA3841415@nathanxps13> <524751.1707240550@sss.pgh.pa.us>
	 <6698edb4.5d0a0220.df6fa.5b59@mx.google.com>
	 <5dc4e037f60467da7bf7d17b10f6ec632a7c9095.camel@cybertec.at>
	 <a459b7d045775784617897592632a6eade915def.camel@cybertec.at>
	 <CAOzEurS0jbDrjmVFgE4QQ_O0bnDtJMaaFsy3=pX0RLYXBcjVpg@mail.gmail.com>
Content-Type: multipart/mixed; boundary="=-zSGsUwx2S1WMTJBpqsJ8"
User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/c69a6198a05f3e9d74d8240483cbc6dbbaacb86c.camel%40cybertec.at>
Precedence: bulk

--=-zSGsUwx2S1WMTJBpqsJ8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2025-09-04 at 14:12 +0900, Shinya Kato wrote:
> Due to 635998965 [0], you need to change guc_parameters.dat instead of
> guc_tables.c.

Thanks for pointing that out to me!
Here is an updated patch.

Yours,
Laurenz Albe

--=-zSGsUwx2S1WMTJBpqsJ8
Content-Disposition: attachment;
 filename="v2-0001-Default-to-log_lock_waits-on.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name="v2-0001-Default-to-log_lock_waits-on.patch";
	charset="UTF-8"

RnJvbSBhYTA0ZjZjZjZlN2M4OWYxMTA3ZmZjNmViNjYxZGE2NTA4MjQ1OWZlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogU3VuLCA3IFNlcCAyMDI1IDIzOjQ0OjM4ICswMjAwClN1YmplY3Q6IFtQQVRDSCB2
Ml0gRGVmYXVsdCB0byBsb2dfbG9ja193YWl0cz1vbgoKSWYgc29tZW9uZSBpcyBzdHVjayBiZWhp
bmQgYSBsb2NrIGZvciBtb3JlIHRoYW4gYSBzZWNvbmQsCnRoYXQgaXMgYWxtb3N0IGFsd2F5cyBh
IHByb2JsZW0gdGhhdCBpcyB3b3J0aCBhIGxvZyBlbnRyeS4KCkF1dGhvcjogTGF1cmVueiBBbGJl
IDxsYXVyZW56LmFsYmVAY3liZXJ0ZWMuYXQ+ClJldmlld2VkLUJ5OiBNaWNoYWVsIEJhbmNrIDxt
YmFuY2tAZ214Lm5ldD4KUmV2aWV3ZWQtQnk6IFJvYmVydCBIYWFzIDxyb2JlcnRtaGFhc0BnbWFp
bC5jb20+ClJldmlld2VkLUJ5OiBDaHJpc3RvcGggQmVyZyA8bXlvbkBkZWJpYW4ub3JnPgpSZXZp
ZXdlZC1CeTogU3RlcGhlbiBGcm9zdCA8c2Zyb3N0QHNub3dtYW4ubmV0PgpEaXNjdXNzaW9uOiBo
dHRwczovL3Bvc3Rnci5lcy9tL2I4Yjg1MDI5MTVlNTBmNDRkZWIxMTFiYzBiNDNhOTllMjczM2Ux
MTcuY2FtZWwlNDBjeWJlcnRlYy5hdAotLS0KIGRvYy9zcmMvc2dtbC9jb25maWcuc2dtbCAgICAg
ICAgICAgICAgICAgICAgICB8IDIgKy0KIHNyYy9iYWNrZW5kL3N0b3JhZ2UvbG1nci9wcm9jLmMg
ICAgICAgICAgICAgICB8IDIgKy0KIHNyYy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjX3BhcmFtZXRl
cnMuZGF0ICAgICB8IDIgKy0KIHNyYy9iYWNrZW5kL3V0aWxzL21pc2MvcG9zdGdyZXNxbC5jb25m
LnNhbXBsZSB8IDIgKy0KIDQgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0
aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9jb25maWcuc2dtbCBiL2RvYy9zcmMv
c2dtbC9jb25maWcuc2dtbAppbmRleCAyYTM2ODVmNDc0YS4uM2MzM2Q1ZDBmYmMgMTAwNjQ0Ci0t
LSBhL2RvYy9zcmMvc2dtbC9jb25maWcuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvY29uZmlnLnNn
bWwKQEAgLTc5MjksNyArNzkyOSw3IEBAIGxvZ19saW5lX3ByZWZpeCA9ICclbSBbJXBdICVxJXVA
JWQvJWEgJwogICAgICAgICBDb250cm9scyB3aGV0aGVyIGEgbG9nIG1lc3NhZ2UgaXMgcHJvZHVj
ZWQgd2hlbiBhIHNlc3Npb24gd2FpdHMKICAgICAgICAgbG9uZ2VyIHRoYW4gPHhyZWYgbGlua2Vu
ZD0iZ3VjLWRlYWRsb2NrLXRpbWVvdXQiLz4gdG8gYWNxdWlyZSBhCiAgICAgICAgIGxvY2suICBU
aGlzIGlzIHVzZWZ1bCBpbiBkZXRlcm1pbmluZyBpZiBsb2NrIHdhaXRzIGFyZSBjYXVzaW5nCi0g
ICAgICAgIHBvb3IgcGVyZm9ybWFuY2UuICBUaGUgZGVmYXVsdCBpcyA8bGl0ZXJhbD5vZmY8L2xp
dGVyYWw+LgorICAgICAgICBwb29yIHBlcmZvcm1hbmNlLiAgVGhlIGRlZmF1bHQgaXMgPGxpdGVy
YWw+b248L2xpdGVyYWw+LgogICAgICAgICBPbmx5IHN1cGVydXNlcnMgYW5kIHVzZXJzIHdpdGgg
dGhlIGFwcHJvcHJpYXRlIDxsaXRlcmFsPlNFVDwvbGl0ZXJhbD4KICAgICAgICAgcHJpdmlsZWdl
IGNhbiBjaGFuZ2UgdGhpcyBzZXR0aW5nLgogICAgICAgIDwvcGFyYT4KZGlmZiAtLWdpdCBhL3Ny
Yy9iYWNrZW5kL3N0b3JhZ2UvbG1nci9wcm9jLmMgYi9zcmMvYmFja2VuZC9zdG9yYWdlL2xtZ3Iv
cHJvYy5jCmluZGV4IGU5ZWYwZmJmZTMyLi45NmYyOWFhZmMzOSAxMDA2NDQKLS0tIGEvc3JjL2Jh
Y2tlbmQvc3RvcmFnZS9sbWdyL3Byb2MuYworKysgYi9zcmMvYmFja2VuZC9zdG9yYWdlL2xtZ3Iv
cHJvYy5jCkBAIC02MCw3ICs2MCw3IEBAIGludAkJCUxvY2tUaW1lb3V0ID0gMDsKIGludAkJCUlk
bGVJblRyYW5zYWN0aW9uU2Vzc2lvblRpbWVvdXQgPSAwOwogaW50CQkJVHJhbnNhY3Rpb25UaW1l
b3V0ID0gMDsKIGludAkJCUlkbGVTZXNzaW9uVGltZW91dCA9IDA7Ci1ib29sCQlsb2dfbG9ja193
YWl0cyA9IGZhbHNlOworYm9vbAkJbG9nX2xvY2tfd2FpdHMgPSB0cnVlOwogCiAvKiBQb2ludGVy
IHRvIHRoaXMgcHJvY2VzcydzIFBHUFJPQyBzdHJ1Y3QsIGlmIGFueSAqLwogUEdQUk9DCSAgICpN
eVByb2MgPSBOVUxMOwpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvdXRpbHMvbWlzYy9ndWNfcGFy
YW1ldGVycy5kYXQgYi9zcmMvYmFja2VuZC91dGlscy9taXNjL2d1Y19wYXJhbWV0ZXJzLmRhdApp
bmRleCAwZGEwMTYyN2NmZS4uNmJjNmJlMTNkMmEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0
aWxzL21pc2MvZ3VjX3BhcmFtZXRlcnMuZGF0CisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL21pc2Mv
Z3VjX3BhcmFtZXRlcnMuZGF0CkBAIC01NjYsNyArNTY2LDcgQEAKIHsgbmFtZSA9PiAnbG9nX2xv
Y2tfd2FpdHMnLCB0eXBlID0+ICdib29sJywgY29udGV4dCA9PiAnUEdDX1NVU0VUJywgZ3JvdXAg
PT4gJ0xPR0dJTkdfV0hBVCcsCiAgIHNob3J0X2Rlc2MgPT4gJ0xvZ3MgbG9uZyBsb2NrIHdhaXRz
LicsCiAgIHZhcmlhYmxlID0+ICdsb2dfbG9ja193YWl0cycsCi0gIGJvb3RfdmFsID0+ICdmYWxz
ZScsCisgIGJvb3RfdmFsID0+ICd0cnVlJywKIH0sCiAKIHsgbmFtZSA9PiAnbG9nX2xvY2tfZmFp
bHVyZXMnLCB0eXBlID0+ICdib29sJywgY29udGV4dCA9PiAnUEdDX1NVU0VUJywgZ3JvdXAgPT4g
J0xPR0dJTkdfV0hBVCcsCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9taXNjL3Bvc3Rn
cmVzcWwuY29uZi5zYW1wbGUgYi9zcmMvYmFja2VuZC91dGlscy9taXNjL3Bvc3RncmVzcWwuY29u
Zi5zYW1wbGUKaW5kZXggMjZjMDg2OTM1NjQuLmMzNmZjYjlhYjYxIDEwMDY0NAotLS0gYS9zcmMv
YmFja2VuZC91dGlscy9taXNjL3Bvc3RncmVzcWwuY29uZi5zYW1wbGUKKysrIGIvc3JjL2JhY2tl
bmQvdXRpbHMvbWlzYy9wb3N0Z3Jlc3FsLmNvbmYuc2FtcGxlCkBAIC02MjQsNyArNjI0LDcgQEAK
IAkJCQkJIyAgICAgICAgcHJvY2Vzc2VzCiAJCQkJCSMgICAlJSA9ICclJwogCQkJCQkjIGUuZy4g
JzwldSUlJWQ+ICcKLSNsb2dfbG9ja193YWl0cyA9IG9mZgkJCSMgbG9nIGxvY2sgd2FpdHMgPj0g
ZGVhZGxvY2tfdGltZW91dAorI2xvZ19sb2NrX3dhaXRzID0gb24JCQkjIGxvZyBsb2NrIHdhaXRz
ID49IGRlYWRsb2NrX3RpbWVvdXQKICNsb2dfbG9ja19mYWlsdXJlcyA9IG9mZgkJIyBsb2cgbG9j
ayBmYWlsdXJlcwogI2xvZ19yZWNvdmVyeV9jb25mbGljdF93YWl0cyA9IG9mZgkjIGxvZyBzdGFu
ZGJ5IHJlY292ZXJ5IGNvbmZsaWN0IHdhaXRzCiAJCQkJCSMgPj0gZGVhZGxvY2tfdGltZW91dAot
LSAKMi41MS4wCgo=


--=-zSGsUwx2S1WMTJBpqsJ8--