Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9L4k-0000Cp-F6 for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jun 2023 07:37:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q9L4j-000209-8x for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jun 2023 07:37:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9L4i-000200-V3 for pgsql-hackers@lists.postgresql.org; Wed, 14 Jun 2023 07:37:53 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q9L4g-002I2N-Fe for pgsql-hackers@postgresql.org; Wed, 14 Jun 2023 07:37:52 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1904A5C01DE; Wed, 14 Jun 2023 03:37:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 14 Jun 2023 03:37:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1686728268; x= 1686814668; bh=J0d8j7xbWY8jlGbtdHEzBluqveiovXc3zEzjA3YdcQo=; b=L jagN7qluyvkf0X8RoSXE2tdgbpqRgjSFK7S12Hq3WPvBI4/bBBEVx2Cpy3u7rQIh 6zam+xJnOGCotCcMiIIqTvZxq66Y+To8B3ByH93ChSvqhZut2dB1zCSh1Dmf33zq Kf17/22ZaLmJYtcjXUZl+d5zI789nasVtoVCmoIpT+qBmy3IqqBg4ISYDe3VHOTh 6PhhjBnFzuMtIFD+QsU4U98zCW5YdtBAz3lHnEXkxDd376Za0SgKn7IZb0D8GPHx d6JaXh//XRSaSMB0FBQJvYtOWosTN7hV/geZxUqOfXI997LGFcRdiz8lhLSxJ6/4 8jhqi7/qAkWPD/dphsJ8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1686728268; x=1686814668; bh=J0d8j7xbWY8jl GbtdHEzBluqveiovXc3zEzjA3YdcQo=; b=Fb1xWk0PE+NRvmh52BPJSqLTcrYme 2jZayzKC9a3CsF2CdqmloMs84EKuXZqf7J3zm/+TjTqg2bU4+M+YHXwDjK2NLQxY uqyseglG5Jw4qWX0gLyIgKY4FLB4/oBJ00NAySOEVffEU9VTbYZ+NtVnZrpnlC/5 oOaScHevZky9isbIvW47uNNPU+9QU6/GOmEjAUGXHNZoH+e5Yty96tjRrCcm1Tz/ gKm9Jwe0YePDrSdWoSzQv6dJfxBbnv6jyQEkO0VVSEDxp/6oZ8+v6+9dM6QJ8B26 beIk8AY2NmYuXxjA2u89XWEAbjunIEjjuHPlN3ZXwjQe6bBcqywLu1tUA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeduledgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpegtkfffgggfuffvvehfhfgjsehmtd erredtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghr segvihhsvghnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnheptefghfdugfdule elueelveffledujeeugedvtedutddviefghffftdduudeikeehnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesvghishgvnhhtrh gruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 03:37:47 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------0q5d7BRRTYwIOycLj9l81rOE" Message-ID: Date: Wed, 14 Jun 2023 09:37:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: pgindent vs. pgperltidy command-line arguments Content-Language: en-US To: Tom Lane Cc: pgsql-hackers References: <45aacd8a-5265-d9da-8df2-b8e2c0cf6a07@eisentraut.org> <1471230.1685020832@sss.pgh.pa.us> From: Peter Eisentraut In-Reply-To: <1471230.1685020832@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------0q5d7BRRTYwIOycLj9l81rOE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25.05.23 15:20, Tom Lane wrote: > Peter Eisentraut writes: >> Until PG15, calling pgindent without arguments would process the whole >> tree. Now you get >> No files to process at ./src/tools/pgindent/pgindent line 372. >> Is that intentional? > > It was intentional, cf b16259b3c and the linked discussion. > >> Also, pgperltidy accepts no arguments and always processes the whole >> tree. It would be nice if there were a way to process individual files >> or directories, like pgindent can. > > +1, although I wonder if we shouldn't follow pgindent's new lead > and require some argument(s). That makes sense to me. Here is a small update with this behavior change and associated documentation update. --------------0q5d7BRRTYwIOycLj9l81rOE Content-Type: text/plain; charset=UTF-8; name="v2-0001-Allow-and-require-passing-files-on-command-line-o.patch" Content-Disposition: attachment; filename*0="v2-0001-Allow-and-require-passing-files-on-command-line-o.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0NGY3YmNkY2MwODQ5YTU1NDU5ZDRjMmRhMjdlZTE5NzZjNzA0OTMzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogV2VkLCAxNCBKdW4gMjAyMyAwOTozMzowMyArMDIwMApTdWJqZWN0 OiBbUEFUQ0ggdjJdIEFsbG93IGFuZCByZXF1aXJlIHBhc3NpbmcgZmlsZXMgb24gY29tbWFu ZCBsaW5lIG9mCiBwZ3Blcmx0aWR5CgpwZ3Blcmx0aWR5IGFzIHdlbGwgYXMgcGdwZXJsY3Jp dGljIGFuZCBwZ3BlcmxzeW5jaGVjayBub3cgYWxsb3cKcGFzc2luZyBmaWxlcyBhbmQgZGly ZWN0b3JpZXMgb24gdGhlIGNvbW1hbmQgbGluZSwgbGlrZSBwZ2luZGVudCBkb2VzLgooUHJl dmlvdXNseSwgdGhleSB3b3VsZCBhbHdheXMgb3BlcmF0ZSBvbiB0aGUgd2hvbGUgdHJlZS4p CgpBbHNvLCBmb3IgY29uc2lzdGVuY3kgd2l0aCBwZ2luZGVudCdzIG5ldyBiZWhhdmlvciAo YXMgb2YgYjE2MjU5YjNjMSksCnBhc3NpbmcgYW4gYXJndW1lbnQgaXMgbm93IHJlcXVpcmVk LiAgVG8gZ2V0IHRoZSBwcmV2aW91cyBkZWZhdWx0CmJlaGF2aW9yLCB1c2UgInBncGVybHRp ZHkgLiIgZm9yIGV4YW1wbGUuCgpEaXNjdXNzaW9uOiBodHRwczovL3d3dy5wb3N0Z3Jlc3Fs Lm9yZy9tZXNzYWdlLWlkL2ZsYXQvNDVhYWNkOGEtNTI2NS1kOWRhLThkZjItYjhlMmMwY2Y2 YTA3JTQwZWlzZW50cmF1dC5vcmcKLS0tCiBzcmMvdG9vbHMvcGVybGNoZWNrL2ZpbmRfcGVy bF9maWxlcyB8IDggKysrKysrLS0KIHNyYy90b29scy9wZXJsY2hlY2svcGdwZXJsY3JpdGlj ICAgIHwgMiArLQogc3JjL3Rvb2xzL3BlcmxjaGVjay9wZ3BlcmxzeW5jaGVjayAgfCAyICst CiBzcmMvdG9vbHMvcGdpbmRlbnQvUkVBRE1FICAgICAgICAgICB8IDIgKy0KIHNyYy90b29s cy9wZ2luZGVudC9wZ3Blcmx0aWR5ICAgICAgIHwgMiArLQogNSBmaWxlcyBjaGFuZ2VkLCAx MCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy90b29s cy9wZXJsY2hlY2svZmluZF9wZXJsX2ZpbGVzIGIvc3JjL3Rvb2xzL3BlcmxjaGVjay9maW5k X3BlcmxfZmlsZXMKaW5kZXggZmQ5OWRhYjgzYi4uMjBkY2ViODAwZCAxMDA2NDQKLS0tIGEv c3JjL3Rvb2xzL3BlcmxjaGVjay9maW5kX3BlcmxfZmlsZXMKKysrIGIvc3JjL3Rvb2xzL3Bl cmxjaGVjay9maW5kX3BlcmxfZmlsZXMKQEAgLTMsMTEgKzMsMTUgQEAKICMgc2hlbGwgZnVu Y3Rpb24gdG8gZmluZCBhbGwgcGVybCBmaWxlcyBpbiB0aGUgc291cmNlIHRyZWUKIAogZmlu ZF9wZXJsX2ZpbGVzICgpIHsKKwlpZiBbICQjIC1lcSAwIF07IHRoZW4KKwkJZWNobyAnTm8g ZmlsZXMgdG8gcHJvY2VzcycgMT4mMgorCQlyZXR1cm4KKwlmaQogICAgIHsKIAkJIyB0YWtl IGFsbCAucGwgYW5kIC5wbSBmaWxlcwotCQlmaW5kIC4gLXR5cGUgZiAtbmFtZSAnKi5wW2xt XScgLXByaW50CisJCWZpbmQgIiRAIiAtdHlwZSBmIC1uYW1lICcqLnBbbG1dJyAtcHJpbnQK IAkJIyB0YWtlIGV4ZWN1dGFibGUgZmlsZXMgdGhhdCBmaWxlKDEpIHRoaW5rcyBhcmUgcGVy bCBmaWxlcwotCQlmaW5kIC4gLXR5cGUgZiAtcGVybSAtMTAwIC1leGVjIGZpbGUge30gXDsg LXByaW50IHwKKwkJZmluZCAiJEAiIC10eXBlIGYgLXBlcm0gLTEwMCAtZXhlYyBmaWxlIHt9 IFw7IC1wcmludCB8CiAJCWVncmVwIC1pICc6LipwZXJsWzAtOV0qXD4nIHwKIAkJY3V0IC1k OiAtZjEKIAl9IHwgc29ydCAtdSB8IGdyZXAgLXYgJ15cLi9cLmdpdC8nCmRpZmYgLS1naXQg YS9zcmMvdG9vbHMvcGVybGNoZWNrL3BncGVybGNyaXRpYyBiL3NyYy90b29scy9wZXJsY2hl Y2svcGdwZXJsY3JpdGljCmluZGV4IDFjMmY3ODc1ODAuLjJlYzZmMjBkZTMgMTAwNzU1Ci0t LSBhL3NyYy90b29scy9wZXJsY2hlY2svcGdwZXJsY3JpdGljCisrKyBiL3NyYy90b29scy9w ZXJsY2hlY2svcGdwZXJsY3JpdGljCkBAIC0xNCw3ICsxNCw3IEBAIFBFUkxDUklUSUM9JHtQ RVJMQ1JJVElDOi1wZXJsY3JpdGljfQogCiAuIHNyYy90b29scy9wZXJsY2hlY2svZmluZF9w ZXJsX2ZpbGVzCiAKLWZpbmRfcGVybF9maWxlcyB8IHhhcmdzICRQRVJMQ1JJVElDIFwKK2Zp bmRfcGVybF9maWxlcyAiJEAiIHwgeGFyZ3MgJFBFUkxDUklUSUMgXAogCSAgLS1xdWlldCBc CiAJICAtLXByb2dyYW0tZXh0ZW5zaW9ucyAucGwgXAogCSAgLS1wcm9maWxlPXNyYy90b29s cy9wZXJsY2hlY2svcGVybGNyaXRpY3JjCmRpZmYgLS1naXQgYS9zcmMvdG9vbHMvcGVybGNo ZWNrL3BncGVybHN5bmNoZWNrIGIvc3JjL3Rvb2xzL3BlcmxjaGVjay9wZ3BlcmxzeW5jaGVj awppbmRleCA3MzBmNTkyN2NkLi5kYTU5Yzk3MjdjIDEwMDc1NQotLS0gYS9zcmMvdG9vbHMv cGVybGNoZWNrL3BncGVybHN5bmNoZWNrCisrKyBiL3NyYy90b29scy9wZXJsY2hlY2svcGdw ZXJsc3luY2hlY2sKQEAgLTEzLDQgKzEzLDQgQEAgc2V0IC1lCiAjIGZvciB6c2gKIHNldG9w dCBzaHdvcmRzcGxpdCAyPi9kZXYvbnVsbCB8fCB0cnVlCiAKLWZpbmRfcGVybF9maWxlcyB8 IHhhcmdzIC1MIDEgcGVybCAkSU5DTFVERVMgLWN3IDI+JjEgfCBncmVwIC12IE9LCitmaW5k X3BlcmxfZmlsZXMgIiRAIiB8IHhhcmdzIC1MIDEgcGVybCAkSU5DTFVERVMgLWN3IDI+JjEg fCBncmVwIC12IE9LCmRpZmYgLS1naXQgYS9zcmMvdG9vbHMvcGdpbmRlbnQvUkVBRE1FIGIv c3JjL3Rvb2xzL3BnaW5kZW50L1JFQURNRQppbmRleCBiMmIxMzRlZTZhLi5mNWZkZmM1ZDJm IDEwMDY0NAotLS0gYS9zcmMvdG9vbHMvcGdpbmRlbnQvUkVBRE1FCisrKyBiL3NyYy90b29s cy9wZ2luZGVudC9SRUFETUUKQEAgLTQ1LDcgKzQ1LDcgQEAgRE9JTkcgVEhFIElOREVOVCBS VU46CiAKIDQpIEluZGVudCB0aGUgUGVybCBjb2RlIHVzaW5nIHBlcmx0aWR5OgogCi0Jc3Jj L3Rvb2xzL3BnaW5kZW50L3BncGVybHRpZHkKKwlzcmMvdG9vbHMvcGdpbmRlbnQvcGdwZXJs dGlkeSAuCiAKICAgIElmIHlvdSB3YW50IHRvIHVzZSBzb21lIHBlcmx0aWR5IHZlcnNpb24g dGhhdCdzIG5vdCBpbiB5b3VyIFBBVEgsCiAgICBmaXJzdCBzZXQgdGhlIFBFUkxUSURZIGVu dmlyb25tZW50IHZhcmlhYmxlIHRvIHBvaW50IHRvIGl0LgpkaWZmIC0tZ2l0IGEvc3JjL3Rv b2xzL3BnaW5kZW50L3BncGVybHRpZHkgYi9zcmMvdG9vbHMvcGdpbmRlbnQvcGdwZXJsdGlk eQppbmRleCA1ZTcwNDExOWViLi42YWYyN2QyMWQ1IDEwMDc1NQotLS0gYS9zcmMvdG9vbHMv cGdpbmRlbnQvcGdwZXJsdGlkeQorKysgYi9zcmMvdG9vbHMvcGdpbmRlbnQvcGdwZXJsdGlk eQpAQCAtOSw0ICs5LDQgQEAgUEVSTFRJRFk9JHtQRVJMVElEWTotcGVybHRpZHl9CiAKIC4g c3JjL3Rvb2xzL3BlcmxjaGVjay9maW5kX3BlcmxfZmlsZXMKIAotZmluZF9wZXJsX2ZpbGVz IHwgeGFyZ3MgJFBFUkxUSURZIC0tcHJvZmlsZT1zcmMvdG9vbHMvcGdpbmRlbnQvcGVybHRp ZHlyYworZmluZF9wZXJsX2ZpbGVzICIkQCIgfCB4YXJncyAkUEVSTFRJRFkgLS1wcm9maWxl PXNyYy90b29scy9wZ2luZGVudC9wZXJsdGlkeXJjCgpiYXNlLWNvbW1pdDogMGY4Y2ZhZjg5 MjFmZWQzNWYwYjkyZDkxOGNlOTVlZWM3YjQ2ZmYwNQotLSAKMi40MS4wCgo= --------------0q5d7BRRTYwIOycLj9l81rOE--