Content-Type: multipart/alternative;
 boundary="------------eV5xWm70LyPG5vLWcdKqJLu8"
Message-ID: <c6f2d8f9-ddac-898f-fd2b-5a1946e40dde@dunslane.net>
Date: Tue, 20 Jun 2023 08:04:39 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: run pgindent on a regular basis / scripted manner
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jelte Fennema <postgres@jeltef.nl>, Michael Paquier
 <michael@paquier.xyz>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
 Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>,
 Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
 Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>,
 Magnus Hagander <magnus@hagander.net>,
 Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost
 <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
References: <3d67bc80-4de2-5ba8-e272-e4ad2e59ba04@dunslane.net>
 <4ac8f263-f1bb-faa5-a307-1fffe00f0e3e@dunslane.net>
 <CAGECzQRJrcoxozHh=BRTdLrirFui-3nvdRZru7GGa4F9HJV2Rw@mail.gmail.com>
 <b8f18576-afc0-d961-b33b-c0fa2e63edeb@dunslane.net>
 <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net>
 <CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com>
 <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net>
 <OSZPR01MB63100E1C06045FB66B16728BFDA09@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <e89d122e-6cf6-d0dc-8fe9-1dfa1de8dcab@dunslane.net>
 <CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com>
 <ZEOfzsDrQ1SMOj4Q@paquier.xyz>
 <582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net>
 <CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com>
 <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net>
 <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net>
 <3156045.1687208823@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <3156045.1687208823@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/c6f2d8f9-ddac-898f-fd2b-5a1946e40dde%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------eV5xWm70LyPG5vLWcdKqJLu8
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2023-06-19 Mo 17:07, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>> I have set up a new buildfarm animal called koel which will run the module.
> Is koel tracking the right repo?  It just spit up with a bunch of
> diffs that seem to have little to do with the commit it's claiming
> caused them:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-06-19%2019%3A49%3A03
>
> 			


Yeah, I changed it so that instead of just checking new commits it would 
check the whole tree. The problem with the incremental approach is that 
the next run it might turn green again but the issue would not have been 
fixed.

I think this is a one-off issue. Once we clean up the tree the problem 
would disappear and the commits it shows would be correct. I imaging 
that's going to happen any day now?


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------eV5xWm70LyPG5vLWcdKqJLu8
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2023-06-19 Mo 17:07, Tom Lane wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:3156045.1687208823@sss.pgh.pa.us">
      <pre class="moz-quote-pre" wrap="">Andrew Dunstan <a class="moz-txt-link-rfc2396E" href="mailto:andrew@dunslane.net">&lt;andrew@dunslane.net&gt;</a> writes:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">I have set up a new buildfarm animal called koel which will run the module.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Is koel tracking the right repo?  It just spit up with a bunch of
diffs that seem to have little to do with the commit it's claiming
caused them:

<a class="moz-txt-link-freetext" href="https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&amp;dt=2023-06-19%2019%3A49%3A03">https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&amp;dt=2023-06-19%2019%3A49%3A03</a>

			</pre>
    </blockquote>
    <p><br>
    </p>
    <p>Yeah, I changed it so that instead of just checking new commits
      it would check the whole tree. The problem with the incremental
      approach is that the next run it might turn green again but the
      issue would not have been fixed.</p>
    <p>I think this is a one-off issue. Once we clean up the tree the
      problem would disappear and the commits it shows would be correct.
      I imaging that's going to happen any day now?<br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <pre class="moz-signature" signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------eV5xWm70LyPG5vLWcdKqJLu8--