Feedback-ID: ie0a040ee:Fastmail
Message-ID: <c707f43b-98c9-4fe1-a3e7-05e290cdb5af@eisentraut.org>
Date: Mon, 4 May 2026 16:47:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Bug][patch]: After dropping the last label from a property graph
 element, invoking pg_get_propgraphdef() triggers an assertion failure
To: Chao Li <li.evan.chao@gmail.com>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAHg+QDeP=mTHTV48R23zKMy1SBmCKZ_L7-z5zKnYyw+K0x-gCg@mail.gmail.com>
 <CAExHW5tsOK7ja2dMykD_qQSLwsuZxCTHx_jFyx-7-O+9WRBDXQ@mail.gmail.com>
 <CAHg+QDcXxmeiuySsyR5K=8Wk9Pq2sZ_4HNb6EMonN=yjLz_fyw@mail.gmail.com>
 <CAExHW5t2YtTMnK7qbvL++pBet-5B8bzgU+8wMcC5aqZwBH0C9w@mail.gmail.com>
 <CAHg+QDdAoW2cU2Wa-yKQs2awHxc19mkHGaAvDUZN=PZUDVsD=A@mail.gmail.com>
 <CAExHW5uThebnwqyWHrsF2Z+no-fT8VrM0Yj+RU7YWrYzdavUZg@mail.gmail.com>
 <CAExHW5tiOi=8Oq5Tza8gNz_jYmbWv+vb+p2fARUbfGnm-m7-9Q@mail.gmail.com>
 <0E47B575-A8AE-4366-AD73-7A25BF0D7815@gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <0E47B575-A8AE-4366-AD73-7A25BF0D7815@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/c707f43b-98c9-4fe1-a3e7-05e290cdb5af%40eisentraut.org>
Precedence: bulk

On 29.04.26 14:58, Chao Li wrote:
> As Alvaro commented at [1], I added 0003 to use OidIsValid macro. 0001 and 0002 are unchanged.
> 
> [1]https://www.postgresql.org/message-id/02fe13db-4fba-4e9d-9b4c- 
> e6271a133502@app.fastmail.com

I'm personally not on board with that coding style rule.  At least I 
don't consider this patch necessary right now as we're working toward 
stabilizing the current code.