Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGMiu-0004GW-SR for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Jul 2023 16:48:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qGMit-0005UN-KO for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Jul 2023 16:48:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGMit-0005UE-Aa for pgsql-hackers@lists.postgresql.org; Mon, 03 Jul 2023 16:48:23 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qGMiq-001zM1-Cv for pgsql-hackers@lists.postgresql.org; Mon, 03 Jul 2023 16:48:22 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-98377c5d53eso545925566b.0 for ; Mon, 03 Jul 2023 09:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1688402896; x=1690994896; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tUQ0RwF8hAuScmljhn2wq1p2BmE1xsPUgf+mLfHlM78=; b=ZK7qKjKaEU7Jdg5JD0z40DWwnb9R01VrsGgM2O60werGHM0QjuTK7yRNviBR4MAWjn Akywz0WoEod00RV2BS5uSsenVR6I4ICVRwb3Zn7ttZtehZDsBzBKDSNqdiKkXKZeS8NM c5WoyagY/kb3NPoyl4j6rUbsjzz08Bi+01VdKBiCc4wR7AvxUvMXjm0gmIKn8UY5wU5Z TI/ZOHuzZQIlm9l+RKPzUCHmOk4RVTylclxQ3QK4oR8cxqJCtAN5PniaySlCoGWj1GVS E21N+CczJmrg8E/hAxXlz+/tAlsTWE+GNjr54Lzql9Y5F/CYyVkuU1bLAavKR7eVD8uI 7lZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688402896; x=1690994896; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tUQ0RwF8hAuScmljhn2wq1p2BmE1xsPUgf+mLfHlM78=; b=BsDcxE7Yh25Su2OMgGF0VRhKroJSvLv50dgSS9MLiooK1aZlwi+R9XrMLR2pth3Zt7 CpLThpXKT+mPO/vNKXduBR82t5N0GPv45zqRttQNfCW4Rjixm1jz+FpAvsqgL6HbQEhs aeDkM8Fjm+rOi970L97BFNDt9pNy1eT2AtbE+RkSTzT3QPuDnUCxHuJg/OjRkkl9iz3B ItTzu5AXqL+ACQO2G8pWAigcdicQRkOkzXkRc6zMxaKc4QfwuWbWcdn7te6jTI9ETIdh wK/JOoxucK/8ERj92pg7gEeqNHABO31XsIVgEJd9ID5Dtd+W2xQaZmLYyWL7Qjpoq3zE ZRCQ== X-Gm-Message-State: ABy/qLbeSro/JRqHsTKfiPYyuDubYUPKili3chQIk6SqkK4I2er/32uX J+0sHPJ3LUoKm9yRfBH/QH/9Yg== X-Google-Smtp-Source: APBJJlHIfEwVKIwAEPql/GGmQVg5Jpy4LGEPuug8HEkTSvqw7Qt50TlokyeH2C+5mSbQqfZtTE6mVQ== X-Received: by 2002:a17:907:1742:b0:974:183a:54b6 with SMTP id lf2-20020a170907174200b00974183a54b6mr6907710ejc.33.1688402896704; Mon, 03 Jul 2023 09:48:16 -0700 (PDT) Received: from [10.137.0.17] (static-84-42-175-93.bb.vodafone.cz. [84.42.175.93]) by smtp.gmail.com with ESMTPSA id l16-20020a1709065a9000b00988be3c1d87sm12195953ejq.116.2023.07.03.09.48.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 09:48:16 -0700 (PDT) Message-ID: Date: Mon, 3 Jul 2023 18:48:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: Fdw batch insert error out when set batch_size > 65535 Content-Language: en-US From: Tomas Vondra To: Tom Lane , Andres Freund Cc: Bharath Rupireddy , "houzj.fnst@fujitsu.com" , PostgreSQL Hackers References: <68b4d5bd-d9fd-4337-e677-0bc5b3b7db6f@enterprisedb.com> <1! 271666.1623218746@sss.pgh.pa.us> <1272762.1623220109@sss.pgh.pa.us> <06650e9a-086c-0020-614f-f7ff39609c43@enterprisedb.com> <1291662.1623245310@sss.pgh.pa.us> <6abb33e8-db04-3d39-4f9a-7a22a75e0cc8@enterprisedb.com> <2131017.1623451468@sss.pgh.pa.us> <20230702060949.mh4k7ukle2ain47j@awork3.anarazel.de> <152591.1688304220@sss.pgh.pa.us> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 7/2/23 15:50, Tomas Vondra wrote: > On 7/2/23 15:23, Tom Lane wrote: >> Andres Freund writes: >>> On 2021-06-11 18:44:28 -0400, Tom Lane wrote: >>>> I suggest what we do is leave it in place for long enough to get >>>> a round of reports from those slow animals, and then (assuming >>>> those reports are positive) drop the test. >> >>> I think two years later is long enough to have some confidence in this being >>> fixed? >> >> +1, time to drop it (in the back branches too). >> > > OK, will do (unless someone else wants to handle this) on Monday. > FWIW I've removed the test from all branches where it was present. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company