Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecDGq-0001V5-QT for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jan 2018 16:42:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecDGq-0004ri-7S for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jan 2018 16:42:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ecDGp-0004rU-TX for pgsql-hackers@lists.postgresql.org; Thu, 18 Jan 2018 16:42:32 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ecDGm-0000e8-Fk for pgsql-hackers@postgresql.org; Thu, 18 Jan 2018 16:42:31 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 6649221C1C3F; Thu, 18 Jan 2018 19:42:26 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from mail.postgrespro.ru (cyclops.l.postgrespro.ru [192.168.27.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 3736C21C05F4; Thu, 18 Jan 2018 19:42:26 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1516293746; bh=zS5IO05ahnWlBnF1+7SLfGQtX0mip08g1+xTt3P6/wc=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=J9puWzVVVNRK35TfigsWpfrdJ4p6WA94L2W9y4Gfgqr7cQQS/eegcHWPqe4HeVt2o 61nGIw8YcDTYqlz5cJ2gDlq333yqKAiBw5KhaoQbdV82sG8OEpgNA1mq+pwpZcEB9f 7uv0cIF3dyy3hdeyJx5ilMIqA/dn3NeqmJC+lGdM= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 18 Jan 2018 19:42:26 +0300 From: Marina Polyakova To: Tom Lane Cc: vitus@wagner.pp.ru, Andres Freund , pgsql-hackers@postgresql.org, Alvaro Herrera Subject: Re: master make check fails on Solaris 10 Organization: Postgres Professional In-Reply-To: <16822.1516287408@sss.pgh.pa.us> References: <0d3a9fa264cebe1cb9966f37b7c06e86@postgrespro.ru> <20180111173938.jimybeayp2u5mmup@alap3.anarazel.de> <31a342fa6a025a8bdfc5b8b19c29d56d@postgrespro.ru> <1232.1515780057@sss.pgh.pa.us> <15299.1515867055@sss.pgh.pa.us> <18209.1516059711@sss.pgh.pa.us> <90ab676392c8f9c84431976147097cf0@postgrespro.ru> <17897.1516202926@sss.pgh.pa.us> <1c70bab595a37ffa3a7fafea29fa6f55@postgrespro.ru> <31743.1516206789@sss.pgh.pa.us> <0e183c12a68af526ebc03c5c26206c44@postgrespro.ru> <16822.1516287408@sss.pgh.pa.us> Message-ID: X-Sender: m.polyakova@postgrespro.ru User-Agent: Roundcube Webmail/1.2.4 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 18-01-2018 17:56, Tom Lane wrote: > Marina Polyakova writes: >> Applying your patch on commit f033462d8f77c40b7d6b33c5116e50118fb4699d >> and using the configuration command from [1], I got: >> checking for __int128... yes >> checking for __int128 alignment bug... broken >> ... >> And make check-world passes. Victor said that he used a much simpler >> configuration command, and I'm trying to figure out what's changed.. > > Weird. Maybe the gcc bug only manifests with certain optimization > flags? That's not what I'd have expected from Victor's theory about > why the code is wrong, but if it only shows up some of the time, > it's hard to think of another explanation. Thank you! Using ./configure CC="gcc" CFLAGS="-m64 -O1" on commit 9c7d06d60680 with your patch, I got this: checking for __int128... yes checking for __int128 alignment bug... ok checking alignment of PG_INT128_TYPE... 16 In pg_config.h: /* The normal alignment of `PG_INT128_TYPE', in bytes. */ #define ALIGNOF_PG_INT128_TYPE 16 ... /* Define to the name of a signed 128-bit integer type. */ #define PG_INT128_TYPE __int128 But make check got the same failures, and I see the same debug output as in [1].. P.S. As I understand it, this comment on bugzilla [2] is also about this. [1] https://www.postgresql.org/message-id/90ab676392c8f9c84431976147097cf0%40postgrespro.ru [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83925#c6 -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company