public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: [email protected]
To: Pavel Stehule <[email protected]>
Cc: 曾文旌 <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Konstantin Knizhnik <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Prabhat Sahu <[email protected]>
Cc: tushar <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [Proposal] Global temporary tables
Date: Sun, 28 Mar 2021 09:07:19 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+B_3VmCYnyum9hM0v62vMidNBoxrDcDVRZrqBygAGpXxjcQZg@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CAFj8pRCp+r=WRXryPQ1Lxhq-tfZqomp00FjddUztqWaAOO4Pxg@mail.gmail.com>
<[email protected]>
<CAFj8pRBFhJG0oPWA87pNMhDkP7qvYNBs6ShwET8QTwZzrM_joA@mail.gmail.com>
<[email protected]>
<CAFj8pRAFb0da-+w+8vXB3_OWrC4O183__NQvzOYyGq299z=H6g@mail.gmail.com>
<[email protected]>
<CA+TgmoY6ukoteryMDri2hzweJaCgTvV2wyvmXGSP_4izYtAkcA@mail.gmail.com>
<[email protected]>
<CAFj8pRCB1pQMrG0uNS2s1QNRZ++t7x4n39L4hyYdMOjEBf7fcQ@mail.gmail.com>
<[email protected]>
<CAFj8pRBtq25tF9O1ioKfAUdvUFzgYQL1Zj9ixdyeXJ7vo7pT=A@mail.gmail.com>
<[email protected]>
<CAFj8pRDz55+19kW6JzB9tXieCEMWBRpDSmGNHa+W7J8f4Zxwbg@mail.gmail.com>
<CA+B_3VmCYnyum9hM0v62vMidNBoxrDcDVRZrqBygAGpXxjcQZg@mail.gmail.com>
On 3/17/21 7:59 AM, wenjing wrote:
> ok
>
> The cause of the problem is that the name of the dependent function
> (readNextTransactionID) has changed. I fixed it.
>
> This patch(V43) is base on 9fd2952cf4920d563e9cea51634c5b364d57f71a
>
> Wenjing
>
>
I have fixed this patch so that
a) it applies cleanly
b) it uses project best practice for catalog Oid assignment.
However, as noted elsewhere it fails the recovery TAP test.
I also note this:
diff --git a/src/test/regress/parallel_schedule
b/src/test/regress/parallel_schedule
index 312c11a4bd..d44fa62f4e 100644
--- a/src/test/regress/parallel_schedule
+++ b/src/test/regress/parallel_schedule
@@ -129,3 +129,10 @@ test: fast_default
# run stats by itself because its delay may be insufficient under heavy
load
test: stats
+
+# global temp table test
+test: gtt_stats
+test: gtt_function
+test: gtt_prepare
+test: gtt_parallel_1 gtt_parallel_2
+test: gtt_clean
Tests that need to run in parallel should use either the isolation
tester framework (which is explicitly for testing things concurrently)
or the TAP test framework.
Adding six test files to the regression test suite for this one feature
is not a good idea. You should have one regression test script ideally,
and it should be added as appropriate to both the parallel and serial
schedules (and not at the end). Any further tests should be added using
the other frameworks mentioned.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Attachments:
[application/gzip] global_temporary_table_v44-pg14.patch.gz (50.5K, ../[email protected]/2-global_temporary_table_v44-pg14.patch.gz)
download
view thread (492+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [Proposal] Global temporary tables
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox