Message-ID: <c7ec08db-e5e0-42bf-acaa-4cc09d9649f6@dunslane.net>
Date: Wed, 15 Apr 2026 13:20:03 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add errdetail() with PID and UID about source of termination
 signal
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jakub Wartak <jakub.wartak@enterprisedb.com>,
 Chao Li <li.evan.chao@gmail.com>, Andres Freund <andres@anarazel.de>,
 Jim Jones <jim.jones@uni-muenster.de>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CFD6C011-7D95-418B-B7BA-5F864F682C83@gmail.com>
 <a076e20d-fc56-4b5d-aa47-a52b4e7a5061@dunslane.net>
 <j7gm4f7bx7hprsc6j4tl47nd5r2vfv5aqevco76rsdawvkwfnd@nsbig7xqlqj5>
 <9179378a-42db-4315-9ff6-b849ad5eefaf@dunslane.net>
 <6cj4oxgdpavltoqdbydw2pgxfdbcejc26x3mitasrnswipxne5@7gkaeoibos4l>
 <71930E58-82A8-4DDC-BA8C-5E394331E463@gmail.com>
 <43ab327c-3ec7-4424-88de-22c7906e5529@uni-muenster.de>
 <jygesyr7mwg7ovdbxpmjvvbi3hccptpkcreqb645h7f56puwbz@hmkkwi3melfe>
 <acd7c8a3-9646-4023-8938-d49eb9c6a3f1@dunslane.net>
 <8B3A69A4-8412-472D-BB39-47617E430420@gmail.com>
 <CAKZiRmws3_4xemjzP9kyp=co=gc1GXoZ2VtqZzGuO9-tN8ok8Q@mail.gmail.com>
 <833f045b-286a-45dc-aad1-28854cbacc99@dunslane.net>
 <CAKZiRmwV-46KOYQM5OP4FZWJFqsELAVCTE++_XBHoX8hAFdpAg@mail.gmail.com>
 <d73b6ec7-f053-4175-8b6f-281fcb828899@dunsla! ne.net>
 <1997398.1776263852@sss.pgh.pa.us> <30efa6ac-4b7f-43c3-aab6!
 -c0a3c74daac6@dunslane.net> <2007157.1776269052@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX
 gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd
 BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS
 h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc
 wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE
 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr
 VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T
 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV
 cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr
 GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN
 hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ
 +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq
 QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd
 EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/
 qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL
 vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p
 bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i
 QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm
 VRu7cmw=
In-Reply-To: <2007157.1776269052@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/c7ec08db-e5e0-42bf-acaa-4cc09d9649f6%40dunslane.net>
Precedence: bulk


On 2026-04-15 We 12:04 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 2026-04-15 We 10:37 AM, Tom Lane wrote:
>>> The OpenBSD members of the buildfarm don't seem to like this.
>> Ugh.
>> I'm will take a look later today.
> I reproduced it locally on OpenBSD 7.7.  HAVE_SA_SIGINFO is defined,
> and the code to grab the pid/uid out of siginfo_t is definitely
> getting compiled.  As best I can tell, the kernel is simply passing
> zero for info->si_pid and si_uid.  This does not match up with the
> info available on the net, so I'm not sure what the issue is.
>
> Some googling suggested that on some platforms si_pid will be zero
> if the process signaled itself, but I can eliminate that theory:
> it's still zero if I do the pg_terminate_backend() from another
> session.
>
> As a short-term fix, we could just go back to allowing the regex to
> consider the match optional.
>
> 			


Ok, so we can get the buildfarm green I'll go and do that. But I think 
we should have an open item to tighten the test.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com