Feedback-ID: i131946ab:Fastmail
Message-ID: <c804ba5d-a3d3-d808-f376-ed0cc20f37af@enterprisedb.com>
Date: Tue, 14 Feb 2023 13:51:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: appendBinaryStringInfo stuff
Content-Language: en-US
To: Corey Huinker <corey.huinker@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <a0086cfc-ff0f-2827-20fe-52b591d2666c@enterprisedb.com>
 <783a4edb-84f9-6df2-7470-2ef5ccc6607a@enterprisedb.com>
 <CADkLM=cprBDinpS71gWNKUc48cciRuBQou76Q2gCSfrvboNFxQ@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <CADkLM=cprBDinpS71gWNKUc48cciRuBQou76Q2gCSfrvboNFxQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/c804ba5d-a3d3-d808-f376-ed0cc20f37af%40enterprisedb.com>
Precedence: bulk

On 10.02.23 20:08, Corey Huinker wrote:
> 
> 
> On Fri, Feb 10, 2023 at 7:16 AM Peter Eisentraut 
> <peter.eisentraut@enterprisedb.com 
> <mailto:peter.eisentraut@enterprisedb.com>> wrote:
> 
>     On 19.12.22 07:13, Peter Eisentraut wrote:
>      > Also, the argument type of appendBinaryStringInfo() is char *. 
>     There is
>      > some code that uses this function to assemble some kind of packed
>     binary
>      > layout, which requires a bunch of casts because of this.  I think
>      > functions taking binary data plus length should take void * instead,
>      > like memcpy() for example.
> 
>     I found a little follow-up for this one: Make the same change to
>     pq_sendbytes(), which is a thin wrapper around
>     appendBinaryStringInfo().
>        This would allow getting rid of further casts at call sites.
> 
> 
> +1
> 
> Has all the benefits that 54a177a948b0a773c25c6737d1cc3cc49222a526 had.
> 
> Passes make check-world.

committed, thanks