Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vOKkX-003Bs4-04 for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Nov 2025 19:00:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vOKkU-00171T-0k for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Nov 2025 19:00:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vOKkT-00171L-1s for pgsql-hackers@lists.postgresql.org; Wed, 26 Nov 2025 19:00:18 +0000 Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vOKkP-001ejU-2E for pgsql-hackers@postgresql.org; Wed, 26 Nov 2025 19:00:17 +0000 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id E376BEC0409; Wed, 26 Nov 2025 14:00:10 -0500 (EST) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-06.internal (MEProxy); Wed, 26 Nov 2025 14:00:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1764183610; x=1764270010; bh=qekR78dGju Yqg3v6lkRiKwCgQnyLpAuTNd9rIdnYrB8=; b=FW18z0zJMYs/+Yi6l/d4V3Ufwp bZ33hNG7gUYQk8jQuRISGaLGtX9YTa+8xThWqxMTnCWrLAjNyjUjUu5BcT4XnN5q wow9msb3vneQKuBhYX2wozbP8Y++MXL5XqRO8kCep5fUGa4c1n1AgYhN6sKINU+I QsJUzooXNnirOgFFsFkAijMfbmnLYQaFvOzTkW7Wc2BbdMmNbG+yPDlp2yAQK5Vv OHTozQxtCpJBR4J5joZWJNjwnEyE/Y3Inlc9uHbAQd1LWLGKwgf5GcYkemwtgVeS zw6h644Ld/yzaQM2pgOoRzKew97a2CTkPz9wJR6NnJ3SLooVXRWxAUHv4XRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1764183610; x=1764270010; bh=qekR78dGjuYqg3v6lkRiKwCgQnyLpAuTNd9 rIdnYrB8=; b=k3h2huOJ4UDVIinyvMFntj+/pz7G3btf8mzULTouuz2wJ8cBMwj R88nOmnrYsulSP5XO0NGTwT1Fx6gxzrFM9nVmROf8vCIVmJ+M/CDOFKNeDfJLznC +LMh614TDwQSJtHRygzm/+ChBuH/0ptOL1vihFmR2+1kSysb85WEa5P10SBYP0XE aTh029nWBvdeYVPH1jYed4Y05+H8fzY3h/Qr/DUkLXfDPt5DOKqNTKLe9griqY7J gdfaZPqZYVdNG7HMMFI59Aaact3c8Oy1vwEiOXrM1fD03BVVhBSPpv5+8lrJ/EPD IQ3DF5z5ZNIlpS1/aoE+74eXI1FL0qM8Y3g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeehudefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgesmhdtreerredttdenucfhrhhomhepfdfguhhlvghr ucfvrghvvghirhgrfdcuoegvuhhlvghrsegvuhhlvghrthhordgtohhmqeenucggtffrrg htthgvrhhnpeeffeegkefhledvleffkefhtdeiheeiiedvueeihefghfeigeekjefhvefg leefheenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepvghulhgvrhesvghulhgv rhhtohdrtghomhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtg hpthhtohepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgpdhrtghpthhtohepmhhi tghhrggvlhesphgrqhhuihgvrhdrgiihiidprhgtphhtthhopehpghhsqhhlqdhhrggtkh gvrhhssehpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 44EFF1820054; Wed, 26 Nov 2025 14:00:10 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: AydCylzTmZSF Date: Wed, 26 Nov 2025 15:59:37 -0300 From: "Euler Taveira" To: "Michael Paquier" , "Peter Eisentraut" Cc: pgsql-hackers Message-Id: In-Reply-To: References: <435df33a-129e-4f0c-a803-f3935c5a5ecb@eisentraut.org> Subject: Re: change default default_toast_compression to lz4? Content-Type: multipart/mixed; boundary=3b6f2c455cda40ae95a819ee9bb6d3a3 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --3b6f2c455cda40ae95a819ee9bb6d3a3 Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, Nov 26, 2025, at 1:35 AM, Michael Paquier wrote: > On Fri, Nov 21, 2025 at 12:11:38PM +0100, Peter Eisentraut wrote: >> I suppose one issue is that lz4 support is not compiled-in by default, but >> in practice most users will have it. The default could be lz4 if lz4 >> support is built, otherwise pglz. This would be similar to other parameters >> where the default is the best one depending on the build configuration. > > +1. That makes sense here to flip the default depending on what the > code is built with, with lz4 if available, pglz otherwise. > Since we have an agreement that $SUBJECT is ok, I wrote a patch for it. It selects the compression method based on USE_LZ4. It also adjusts the postgresql.conf if required. -- Euler Taveira EDB https://www.enterprisedb.com/ --3b6f2c455cda40ae95a819ee9bb6d3a3 Content-Disposition: attachment; filename*0="v1-0001-Change-default_toast_compression-to-lz4.patch" Content-Type: text/x-patch; name="=?UTF-8?Q?v1-0001-Change-default=5Ftoast=5Fcompression-to-lz4.patch?=" Content-Transfer-Encoding: base64 RnJvbSA4OTA4NGUxN2RmMTM4MjMwNzdiYWQyZjZhZDRjMWNiMGUwOTVjY2M0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBFdWxlciBUYXZlaXJhIDxldWxlckBldWxlcnRvLmNv bT4KRGF0ZTogV2VkLCAyNiBOb3YgMjAyNSAxMjo0MDo0MyAtMDMwMApTdWJqZWN0OiBbUEFU Q0ggdjFdIENoYW5nZSBkZWZhdWx0X3RvYXN0X2NvbXByZXNzaW9uIHRvIGx6NAoKVGhlIGRl ZmF1bHQgdmFsdWUgZm9yIGRlZmF1bHRfdG9hc3RfY29tcHJlc3Npb24gd2FzIHBnbHouIFRo ZSBtYWluCnJlYXNvbiBpcyB0aGF0IHRoaXMgb3B0aW9uIGlzIGFsd2F5cyBhdmFpbGFibGUu IEhvd2V2ZXIsIGl0IGlzIGtub3duCnRoYXQgcGdseiB1c2VzIG1vcmUgQ1BVIHRoYW4gbHo0 LiBUaGUgZGVmYXVsdCB2YWx1ZSB3aWxsIGJlIGx6NCBpZiBsejQKc3VwcG9ydCBpcyBidWls dCwgb3RoZXJ3aXNlLCBwZ2x6LgotLS0KIGRvYy9zcmMvc2dtbC9jb25maWcuc2dtbCAgICAg ICAgICAgICAgICAgICAgICB8IDMgKystCiBzcmMvYmFja2VuZC9hY2Nlc3MvY29tbW9uL3Rv YXN0X2NvbXByZXNzaW9uLmMgfCAyICstCiBzcmMvYmFja2VuZC91dGlscy9taXNjL2d1Y19w YXJhbWV0ZXJzLmRhdCAgICAgfCAyICstCiBzcmMvYmluL2luaXRkYi9pbml0ZGIuYyAgICAg ICAgICAgICAgICAgICAgICAgfCA1ICsrKysrCiBzcmMvaW5jbHVkZS9hY2Nlc3MvdG9hc3Rf Y29tcHJlc3Npb24uaCAgICAgICAgfCA5ICsrKysrKysrKwogNSBmaWxlcyBjaGFuZ2VkLCAx OCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMv c2dtbC9jb25maWcuc2dtbCBiL2RvYy9zcmMvc2dtbC9jb25maWcuc2dtbAppbmRleCA3Mzdi OTA3MzZiZi4uYzA2M2YwMTNlMmYgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9jb25maWcu c2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwKQEAgLTk5MTAsNyArOTkxMCw4 IEBAIENPUFkgcG9zdGdyZXNfbG9nIEZST00gJy9mdWxsL3BhdGgvdG8vbG9nZmlsZS5jc3Yn IFdJVEggY3N2OwogICAgICAgICBUaGUgc3VwcG9ydGVkIGNvbXByZXNzaW9uIG1ldGhvZHMg YXJlIDxsaXRlcmFsPnBnbHo8L2xpdGVyYWw+IGFuZAogICAgICAgICAoaWYgPHByb2R1Y3Ru YW1lPlBvc3RncmVTUUw8L3Byb2R1Y3RuYW1lPiB3YXMgY29tcGlsZWQgd2l0aAogICAgICAg ICA8b3B0aW9uPi0td2l0aC1sejQ8L29wdGlvbj4pIDxsaXRlcmFsPmx6NDwvbGl0ZXJhbD4u Ci0gICAgICAgIFRoZSBkZWZhdWx0IGlzIDxsaXRlcmFsPnBnbHo8L2xpdGVyYWw+LgorICAg ICAgICBUaGUgZGVmYXVsdCBpcyA8bGl0ZXJhbD5sejQ8L2xpdGVyYWw+IChpZiBhdmFpbGFi bGUpOyBvdGhlcndpc2UsCisgICAgICAgIDxsaXRlcmFsPnBnbHo8L2xpdGVyYWw+LgogICAg ICAgIDwvcGFyYT4KICAgICAgIDwvbGlzdGl0ZW0+CiAgICAgIDwvdmFybGlzdGVudHJ5Pgpk aWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNzL2NvbW1vbi90b2FzdF9jb21wcmVzc2lv bi5jIGIvc3JjL2JhY2tlbmQvYWNjZXNzL2NvbW1vbi90b2FzdF9jb21wcmVzc2lvbi5jCmlu ZGV4IDkyNmYxZTQwMDhhLi40YmIyOTY2NWVhYiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQv YWNjZXNzL2NvbW1vbi90b2FzdF9jb21wcmVzc2lvbi5jCisrKyBiL3NyYy9iYWNrZW5kL2Fj Y2Vzcy9jb21tb24vdG9hc3RfY29tcHJlc3Npb24uYwpAQCAtMjMsNyArMjMsNyBAQAogI2lu Y2x1ZGUgInZhcmF0dC5oIgogCiAvKiBHVUMgKi8KLWludAkJCWRlZmF1bHRfdG9hc3RfY29t cHJlc3Npb24gPSBUT0FTVF9QR0xaX0NPTVBSRVNTSU9OOworaW50CQkJZGVmYXVsdF90b2Fz dF9jb21wcmVzc2lvbiA9IERFRkFVTFRfVE9BU1RfQ09NUFJFU1NJT047CiAKICNkZWZpbmUg Tk9fQ09NUFJFU1NJT05fU1VQUE9SVChtZXRob2QpIFwKIAllcmVwb3J0KEVSUk9SLCBcCmRp ZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9taXNjL2d1Y19wYXJhbWV0ZXJzLmRhdCBi L3NyYy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjX3BhcmFtZXRlcnMuZGF0CmluZGV4IDNiOWQ4 MzQ5MDc4Li5jYmU5YmYwNTViMyAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvdXRpbHMvbWlz Yy9ndWNfcGFyYW1ldGVycy5kYXQKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvbWlzYy9ndWNf cGFyYW1ldGVycy5kYXQKQEAgLTczNSw3ICs3MzUsNyBAQAogeyBuYW1lID0+ICdkZWZhdWx0 X3RvYXN0X2NvbXByZXNzaW9uJywgdHlwZSA9PiAnZW51bScsIGNvbnRleHQgPT4gJ1BHQ19V U0VSU0VUJywgZ3JvdXAgPT4gJ0NMSUVOVF9DT05OX1NUQVRFTUVOVCcsCiAgIHNob3J0X2Rl c2MgPT4gJ1NldHMgdGhlIGRlZmF1bHQgY29tcHJlc3Npb24gbWV0aG9kIGZvciBjb21wcmVz c2libGUgdmFsdWVzLicsCiAgIHZhcmlhYmxlID0+ICdkZWZhdWx0X3RvYXN0X2NvbXByZXNz aW9uJywKLSAgYm9vdF92YWwgPT4gJ1RPQVNUX1BHTFpfQ09NUFJFU1NJT04nLAorICBib290 X3ZhbCA9PiAnREVGQVVMVF9UT0FTVF9DT01QUkVTU0lPTicsCiAgIG9wdGlvbnMgPT4gJ2Rl ZmF1bHRfdG9hc3RfY29tcHJlc3Npb25fb3B0aW9ucycsCiB9LAogCmRpZmYgLS1naXQgYS9z cmMvYmluL2luaXRkYi9pbml0ZGIuYyBiL3NyYy9iaW4vaW5pdGRiL2luaXRkYi5jCmluZGV4 IDkyZmUyZjUzMWY3Li45MmIxMjBkOGFiOCAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9pbml0ZGIv aW5pdGRiLmMKKysrIGIvc3JjL2Jpbi9pbml0ZGIvaW5pdGRiLmMKQEAgLTE0MjQsNiArMTQy NCwxMSBAQCBzZXR1cF9jb25maWcodm9pZCkKIAkJCQkJCQkJCSAgIjA2NDAiLCBmYWxzZSk7 CiAJfQogCisjaWYgVVNFX0xaNAorCWNvbmZsaW5lcyA9IHJlcGxhY2VfZ3VjX3ZhbHVlKGNv bmZsaW5lcywgImRlZmF1bHRfdG9hc3RfY29tcHJlc3Npb24iLAorCQkJCQkJCQkgICJsejQi LCB0cnVlKTsKKyNlbmRpZgorCiAJLyoKIAkgKiBOb3cgcmVwbGFjZSBhbnl0aGluZyB0aGF0 J3Mgb3ZlcnJpZGRlbiB2aWEgLWMgc3dpdGNoZXMuCiAJICovCmRpZmYgLS1naXQgYS9zcmMv aW5jbHVkZS9hY2Nlc3MvdG9hc3RfY29tcHJlc3Npb24uaCBiL3NyYy9pbmNsdWRlL2FjY2Vz cy90b2FzdF9jb21wcmVzc2lvbi5oCmluZGV4IDEzYzQ2MTJjZWVkLi43NTI2ZWE1MGM1YSAx MDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvYWNjZXNzL3RvYXN0X2NvbXByZXNzaW9uLmgKKysr IGIvc3JjL2luY2x1ZGUvYWNjZXNzL3RvYXN0X2NvbXByZXNzaW9uLmgKQEAgLTUyLDYgKzUy LDE1IEBAIHR5cGVkZWYgZW51bSBUb2FzdENvbXByZXNzaW9uSWQKIAogI2RlZmluZSBDb21w cmVzc2lvbk1ldGhvZElzVmFsaWQoY20pICAoKGNtKSAhPSBJbnZhbGlkQ29tcHJlc3Npb25N ZXRob2QpCiAKKy8qCisgKiBDaG9vc2UgYW4gYXBwcm9wcmlhdGUgZGVmYXVsdCB0b2FzdCBj b21wcmVzc2lvbiBtZXRob2QuIElmIGx6NCBpcworICogY29tcGlsZWQtaW4sIHVzZSBpdCwg b3RoZXJ3aXNlLCB1c2UgcGdsei4KKyAqLworI2lmZGVmIFVTRV9MWjQKKyNkZWZpbmUgREVG QVVMVF9UT0FTVF9DT01QUkVTU0lPTglUT0FTVF9MWjRfQ09NUFJFU1NJT04KKyNlbHNlCisj ZGVmaW5lIERFRkFVTFRfVE9BU1RfQ09NUFJFU1NJT04JVE9BU1RfUEdMWl9DT01QUkVTU0lP TgorI2VuZGlmCiAKIC8qIHBnbHogY29tcHJlc3Npb24vZGVjb21wcmVzc2lvbiByb3V0aW5l cyAqLwogZXh0ZXJuIHN0cnVjdCB2YXJsZW5hICpwZ2x6X2NvbXByZXNzX2RhdHVtKGNvbnN0 IHN0cnVjdCB2YXJsZW5hICp2YWx1ZSk7Ci0tIAoyLjM5LjUKCg== --3b6f2c455cda40ae95a819ee9bb6d3a3--