Message-ID: <c82c4dc1-c3a1-45ef-9f22-d9156eb810b4@yeah.net>
Date: Wed, 21 Feb 2024 07:45:22 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Change the bool member of the Query structure to bits
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
References: <d05a1c87-82e9-49a3-a4e2-e0d2b38b2e8b@yeah.net>
 <184953.1708443951@sss.pgh.pa.us>
From: Quan Zongliang <quanzongliang@yeah.net>
In-Reply-To: <184953.1708443951@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/c82c4dc1-c3a1-45ef-9f22-d9156eb810b4%40yeah.net>
Precedence: bulk


On 2024/2/20 23:45, Tom Lane wrote:
> Quan Zongliang <quanzongliang@yeah.net> writes:
>> The Query structure has an increasing number of bool attributes. This is
>> likely to increase in the future. And they have the same properties.
>> Wouldn't it be better to store them in bits? Common statements don't use
>> them, so they have little impact. This also saves memory space.
> 
> I'm -1 on that, for three reasons:
> 
> * The amount of space saved is quite negligible.  If queries had many
> Query structs then it could matter, but they don't.
> 
> * This causes enough code churn to create a headache for back-patching.
> 
> * This'll completely destroy the readability of these flags in
> pprint output.
> 
> I'm not greatly in love with the macro layer you propose, either,
> but those details don't matter because I think we should just
> leave well enough alone.
> 
> 			regards, tom lane
I get it. Withdraw.