MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 14 Jun 2018 15:11:13 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, pgsql-hackers@postgresql.org, Ildus
 Kurbangaliev <i.kurbangaliev@postgrespro.ru>, Teodor Sigaev
 <teodor@sigaev.ru>
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Organization: Postgres Professional
Message-ID: <c89fcc380a19380260b5ea463efc1416@postgrespro.ru>
User-Agent: Roundcube Webmail/1.2.4
Precedence: bulk

On 13-06-2018 22:59, Alvaro Herrera wrote:
> For context: in the backend, elog() is only used for internal messages
> (i.e. "can't-happen" conditions), and ereport() is used for user-facing
> messages.  There are many things ereport() has that elog() doesn't, 
> such
> as additional message fields (HINT, DETAIL, etc) that I think could 
> have
> some use in pgbench as well.  If you use elog() then you can't have 
> that.

AFAIU originally it was not supposed that the pgbench error messages 
have these fields, so will it be good to change the final output to 
stderr?.. For example:

-		fprintf(stderr, "%s", PQerrorMessage(con));
-		fprintf(stderr, "(ignoring this error and continuing anyway)\n");
+		ereport(LOG,
+				(errmsg("Ignoring the server error and continuing anyway"),
+				 errdetail("%s", PQerrorMessage(con))));

-			fprintf(stderr, "%s", PQerrorMessage(con));
-			if (sqlState && strcmp(sqlState, ERRCODE_UNDEFINED_TABLE) == 0)
-			{
-				fprintf(stderr, "Perhaps you need to do initialization (\"pgbench 
-i\") in database \"%s\"\n", PQdb(con));
-			}
-
-			exit(1);
+			ereport(ERROR,
+					(errmsg("Server error"),
+					 errdetail("%s", PQerrorMessage(con)),
+					 sqlState && strcmp(sqlState, ERRCODE_UNDEFINED_TABLE) == 0 ?
+					 errhint("Perhaps you need to do initialization (\"pgbench -i\") 
in database \"%s\"\n",
+							 PQdb(con)) : 0));

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company